Skip to content

Commit 9f33da3

Browse files
committed
Updated errorbar handling of xspans to properly account for when hue column is being used to plot for color_col is not None
1 parent ff3a06f commit 9f33da3

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

dabest/plotter.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,6 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
288288
for i in range(len(idx)):
289289
filled.append(False)
290290
filled.extend([True] * (len(idx[i]) - 1))
291-
print(f"filled is {filled}")
292291

293292
names = color_groups if not color_by_subgroups else idx
294293
n_groups = len(color_groups)
@@ -301,7 +300,6 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
301300
unsat_colors = sns.color_palette(n_colors=n_groups)
302301
if empty_circle and not color_by_subgroups:
303302
unsat_colors = [sns.color_palette("gray")[3]] + unsat_colors
304-
print(unsat_colors)
305303
else:
306304
if isinstance(custom_pal, dict):
307305
groups_in_palette = {
@@ -764,13 +762,13 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
764762
if bootstraps_color_by_group:
765763
line_colors.append(plot_palette_raw[all_plot_groups[jj]])
766764

767-
# Break the loop since hue in Seaborn adds collections to axes and it will result in index out of range
768-
if jj >= n_groups - 1 and color_col is None:
769-
break
770-
771765
if len(line_colors) != len(all_plot_groups):
772766
line_colors = ytick_color
773767

768+
# hue in swarmplot would add collections to axes which will result in len(xspans) = len(all_plot_groups) + len(unique groups in hue)
769+
if len(xspans) > len(all_plot_groups):
770+
xspans = xspans[:len(all_plot_groups)]
771+
774772
error_bar(
775773
plot_data,
776774
x=xvar,

0 commit comments

Comments
 (0)