Skip to content

Commit ffe3062

Browse files
author
Zahraa Chreim
committed
114858: Fix Com/Coll admins' management functionality for roles/groups
1 parent ea92837 commit ffe3062

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/app/access-control/access-control-routes.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
} from '@ng-dynamic-forms/core';
77

88
import { i18nBreadcrumbResolver } from '../core/breadcrumbs/i18n-breadcrumb.resolver';
9+
import { groupAdministratorGuard } from '../core/data/feature-authorization/feature-authorization-guard/group-administrator.guard';
910
import { siteAdministratorGuard } from '../core/data/feature-authorization/feature-authorization-guard/site-administrator.guard';
1011
import {
1112
EPERSON_PATH,
@@ -16,14 +17,15 @@ import { EPeopleRegistryComponent } from './epeople-registry/epeople-registry.co
1617
import { EPersonFormComponent } from './epeople-registry/eperson-form/eperson-form.component';
1718
import { EPersonResolver } from './epeople-registry/eperson-resolver.service';
1819
import { GroupFormComponent } from './group-registry/group-form/group-form.component';
20+
import { groupPageGuard } from './group-registry/group-page.guard';
1921
import { GroupsRegistryComponent } from './group-registry/groups-registry.component';
2022

2123
/**
2224
* Condition for displaying error messages on email form field
2325
*/
2426
export const ValidateEmailErrorStateMatcher: DynamicErrorMessagesMatcher =
2527
(control: AbstractControl, model: any, hasFocus: boolean) => {
26-
return (control.touched && !hasFocus) || (control.errors?.emailTaken && hasFocus);
28+
return ( control.touched && !hasFocus ) || ( control.errors?.emailTaken && hasFocus );
2729
};
2830

2931
const providers = [
@@ -72,7 +74,7 @@ export const ROUTES: Route[] = [
7274
},
7375
providers,
7476
data: { title: 'admin.access-control.groups.title', breadcrumbKey: 'admin.access-control.groups' },
75-
canActivate: [siteAdministratorGuard],
77+
canActivate: [groupAdministratorGuard],
7678
},
7779
{
7880
path: `${GROUP_PATH}/create`,
@@ -85,7 +87,7 @@ export const ROUTES: Route[] = [
8587
title: 'admin.access-control.groups.title.addGroup',
8688
breadcrumbKey: 'admin.access-control.groups.addGroup',
8789
},
88-
canActivate: [siteAdministratorGuard],
90+
canActivate: [groupAdministratorGuard],
8991
},
9092
{
9193
path: `${GROUP_PATH}/:groupId/edit`,
@@ -98,7 +100,7 @@ export const ROUTES: Route[] = [
98100
title: 'admin.access-control.groups.title.singleGroup',
99101
breadcrumbKey: 'admin.access-control.groups.singleGroup',
100102
},
101-
canActivate: [siteAdministratorGuard],
103+
canActivate: [groupPageGuard],
102104
},
103105
{
104106
path: 'bulk-access',

0 commit comments

Comments
 (0)