Skip to content

Commit f887997

Browse files
artlowelAAwouters
authored andcommitted
update tests
1 parent 960bfbb commit f887997

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/app/process-page/overview/table/process-overview-table.component.spec.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,20 @@ import { VarDirective } from '../../../shared/utils/var.directive';
1515
import { TranslateModule } from '@ngx-translate/core';
1616
import { RouterTestingModule } from '@angular/router/testing';
1717
import { PaginationService } from '../../../core/pagination/pagination.service';
18-
import { NO_ERRORS_SCHEMA } from '@angular/core';
1918
import { By } from '@angular/platform-browser';
2019
import { AuthService } from '../../../core/auth/auth.service';
2120
import { AuthServiceMock } from '../../../shared/mocks/auth.service.mock';
2221
import { RouteService } from '../../../core/services/route.service';
2322
import { routeServiceStub } from '../../../shared/testing/route-service.stub';
23+
import { ProcessOverviewService } from '../process-overview.service';
24+
import { take } from 'rxjs/operators';
2425

2526

2627
describe('ProcessOverviewTableComponent', () => {
2728
let component: ProcessOverviewTableComponent;
2829
let fixture: ComponentFixture<ProcessOverviewTableComponent>;
2930

31+
let processOverviewService: ProcessOverviewService;
3032
let processService: ProcessDataService;
3133
let ePersonService: EPersonDataService;
3234
let paginationService; // : PaginationService; Not typed as the stub does not fully implement PaginationService
@@ -78,8 +80,16 @@ describe('ProcessOverviewTableComponent', () => {
7880
]
7981
}
8082
});
83+
processOverviewService = jasmine.createSpyObj('processOverviewService', {
84+
getFindListOptions: {
85+
currentPage: 1,
86+
elementsPerPage: 5,
87+
sort: 'creationTime'
88+
},
89+
getProcessesByProcessStatus: createSuccessfulRemoteDataObject$(createPaginatedList(processes)).pipe(take(1))
90+
});
8191
processService = jasmine.createSpyObj('processService', {
82-
searchBy: createSuccessfulRemoteDataObject$(createPaginatedList(processes))
92+
searchBy: createSuccessfulRemoteDataObject$(createPaginatedList(processes)).pipe(take(1))
8393
});
8494
ePersonService = jasmine.createSpyObj('ePersonService', {
8595
findById: createSuccessfulRemoteDataObject$(ePerson)
@@ -117,6 +127,7 @@ describe('ProcessOverviewTableComponent', () => {
117127
declarations: [ProcessOverviewTableComponent, VarDirective, NgbCollapse],
118128
imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([])],
119129
providers: [
130+
{ provide: ProcessOverviewService, useValue: processOverviewService },
120131
{ provide: ProcessDataService, useValue: processService },
121132
{ provide: EPersonDataService, useValue: ePersonService },
122133
{ provide: PaginationService, useValue: paginationService },
@@ -125,7 +136,6 @@ describe('ProcessOverviewTableComponent', () => {
125136
{ provide: AuthService, useValue: authService },
126137
{ provide: RouteService, useValue: routeService },
127138
],
128-
schemas: [NO_ERRORS_SCHEMA]
129139
}).compileComponents();
130140
}));
131141

src/app/process-page/overview/table/process-overview-table.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ export class ProcessOverviewTableComponent implements OnInit, OnDestroy {
196196
);
197197
}),
198198

199-
).subscribe(this.processesRD$));
199+
).subscribe((next: RemoteData<PaginatedList<ProcessOverviewTableEntry>>) => {
200+
this.processesRD$.next(next);
201+
}));
200202

201203
// Collapse this section when the number of processes is zero the first time processes are retrieved
202204
this.subs.push(this.processesRD$.pipe(

0 commit comments

Comments
 (0)