[UXP-155] fix tests

Author: Andrea Barbasso

src/app/cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/metadataGroup/openstreetmap-group/openstreetmap-group.component.spec.ts

@@ -17,11 +17,14 @@ describe('OpenstreetmapGroupComponent', () => {
   let fixture: ComponentFixture<OpenstreetmapGroupComponent>;
 
   const locationService = jasmine.createSpyObj('locationService', {
-    searchPlace: jasmine.createSpy('searchPlace'),
-    searchCoordinates: jasmine.createSpy('searchCoordinates'),
+    findPlaceCoordinates: jasmine.createSpy('findPlaceCoordinates'),
+    findPlaceAndDecimalCoordinates: jasmine.createSpy('findPlaceAndDecimalCoordinates'),
+    searchByCoordinates: jasmine.createSpy('searchByCoordinates'),
+    isValidDecimalCoordinatePair: jasmine.createSpy('isValidDecimalCoordinatePair'),
+    isDecimalCoordinateString: jasmine.createSpy('isDecimalCoordinateString'),
+    isSexagesimalCoordinateString: jasmine.createSpy('isSexagesimalCoordinateString'),
     isValidCoordinateString: jasmine.createSpy('isValidCoordinateString'),
     parseCoordinates: jasmine.createSpy('parseCoordinates'),
-    isCoordinateString: jasmine.createSpy('isCoordinateString'),
   });
 
   const place: LocationPlace = {
@@ -107,10 +110,10 @@ describe('OpenstreetmapGroupComponent', () => {
 
     fixture = TestBed.createComponent(OpenstreetmapGroupComponent);
     component = fixture.componentInstance;
-    locationService.isCoordinateString.and.returnValue(true);
+    locationService.isDecimalCoordinateString.and.returnValue(true);
     locationService.isValidCoordinateString.and.returnValue(true);
     locationService.parseCoordinates.and.returnValue(place.coordinates);
-    locationService.searchCoordinates.and.returnValue(of(place.displayName));
+    locationService.searchByCoordinates.and.returnValue(of(place.displayName));
     fixture.detectChanges();
   });
 

src/app/shared/open-street-map/open-street-map.component.spec.ts

@@ -9,11 +9,14 @@ describe('OpenStreetMapComponent', () => {
   let fixture: ComponentFixture<OpenStreetMapComponent>;
 
   const locationService = jasmine.createSpyObj('locationService', {
-    searchPlace: jasmine.createSpy('searchPlace'),
-    searchCoordinates: jasmine.createSpy('searchCoordinates'),
+    findPlaceCoordinates: jasmine.createSpy('findPlaceCoordinates'),
+    findPlaceAndDecimalCoordinates: jasmine.createSpy('findPlaceAndDecimalCoordinates'),
+    searchByCoordinates: jasmine.createSpy('searchByCoordinates'),
+    isValidDecimalCoordinatePair: jasmine.createSpy('isValidDecimalCoordinatePair'),
+    isDecimalCoordinateString: jasmine.createSpy('isDecimalCoordinateString'),
+    isSexagesimalCoordinateString: jasmine.createSpy('isSexagesimalCoordinateString'),
     isValidCoordinateString: jasmine.createSpy('isValidCoordinateString'),
     parseCoordinates: jasmine.createSpy('parseCoordinates'),
-    isCoordinateString: jasmine.createSpy('isCoordinateString'),
   });
 
   const coordinates = '52.520008,13.404954';
@@ -65,14 +68,14 @@ describe('OpenStreetMapComponent', () => {
   describe('when coordinates are given', () => {
     beforeEach(() => {
       component.coordinates = coordinates;
-      locationService.isCoordinateString.and.returnValue(true);
+      locationService.isDecimalCoordinateString.and.returnValue(true);
       locationService.isValidCoordinateString.and.returnValue(true);
       locationService.parseCoordinates.and.returnValue(place.coordinates);
     });
 
     describe('and they are found', () => {
       beforeEach(() => {
-        locationService.searchCoordinates.and.returnValue(of(place.displayName));
+        locationService.searchByCoordinates.and.returnValue(of(place.displayName));
         fixture.detectChanges();
       });
 
@@ -88,7 +91,7 @@ describe('OpenStreetMapComponent', () => {
     describe('and they are not found', () => {
       beforeEach(() => {
 
-        locationService.searchCoordinates.and.callFake(() => {
+        locationService.searchByCoordinates.and.callFake(() => {
           return throwError(() => new Error('Fake error'));
         });
         fixture.detectChanges();
@@ -107,12 +110,13 @@ describe('OpenStreetMapComponent', () => {
   describe('when address is given', () => {
     beforeEach(() => {
       component.coordinates = address;
-      locationService.isCoordinateString.and.returnValue(false);
+      locationService.isDecimalCoordinateString.and.returnValue(false);
     });
 
     describe('and exists', () => {
       beforeEach(() => {
-        locationService.searchPlace.and.returnValue(of(placeOnlyCoordinates));
+        locationService.findPlaceCoordinates.and.returnValue(of(placeOnlyCoordinates));
+        locationService.findPlaceAndDecimalCoordinates.and.returnValue(of(place));
         fixture.detectChanges();
       });
 
@@ -128,7 +132,10 @@ describe('OpenStreetMapComponent', () => {
     describe('and is not found', () => {
       beforeEach(() => {
 
-        locationService.searchPlace.and.callFake(() => {
+        locationService.findPlaceCoordinates.and.callFake(() => {
+          return throwError(() => new Error(LocationErrorCodes.API_ERROR));
+        });
+        locationService.findPlaceAndDecimalCoordinates.and.callFake(() => {
           return throwError(() => new Error(LocationErrorCodes.API_ERROR));
         });
         fixture.detectChanges();