Merged in task/ux-plus-cris-2024_02_x/UXP-297 (pull request #76)

[UXP-297] fix e2e tests

Approved-by: Vincenzo Mecca

Author: Andrea Barbasso

cypress/e2e/admin-search-page.cy.ts

@@ -16,6 +16,9 @@ describe('Admin Search Page', () => {
     // (As we want to scan filter section for accessibility issues as well)
     cy.get('[data-test="filter-toggle"]').click({ multiple: true });
     // Analyze <ds-admin-search-page> for accessibility issues
-    testA11y('ds-admin-search-page');
+    testA11y({
+      include: ['ds-admin-search-page'],
+      exclude: ['.noUi-handle'],
+    });
   });
 });

cypress/e2e/admin-workflow-page.cy.ts

@@ -16,6 +16,9 @@ describe('Admin Workflow Page', () => {
     // (As we want to scan filter section for accessibility issues as well)
     cy.get('[data-test="filter-toggle"]').click({ multiple: true });
     // Analyze <ds-admin-workflow-page> for accessibility issues
-    testA11y('ds-admin-workflow-page');
+    testA11y({
+      include: ['ds-admin-workflow-page'],
+      exclude: ['.noUi-handle'],
+    });
   });
 });

cypress/e2e/bulk-access.cy.ts

@@ -17,7 +17,10 @@ describe('Bulk Access', () => {
     // (As we want to scan filter section for accessibility issues as well)
     cy.get('[data-test="filter-toggle"]').click({ multiple: true });
     // Analyze <ds-bulk-access> for accessibility issues
-    testA11y('ds-bulk-access', {
+    testA11y({
+      include: ['ds-bulk-access'],
+      exclude: ['.noUi-handle'],
+    }, {
       rules: {
         // All panels are accordians & fail "aria-required-children" and "nested-interactive".
         // Seem to require updating ng-bootstrap and https://github.com/DSpace/dspace-angular/issues/2216

cypress/e2e/end-user-agreement.cy.ts

@@ -8,6 +8,9 @@ describe('End User Agreement', () => {
     cy.get('ds-end-user-agreement').should('be.visible');
 
     // Analyze <ds-end-user-agreement> for accessibility
-    testA11y('ds-end-user-agreement');
+    testA11y({
+      include: ['ds-end-user-agreement'],
+      exclude: ['ds-markdown-viewer'],
+    });
   });
 });

cypress/e2e/my-dspace.cy.ts

@@ -17,7 +17,10 @@ describe('My DSpace page', () => {
     cy.get('.filter-toggle').click({ multiple: true });
 
     // Analyze <ds-my-dspace-page> for accessibility issues
-    testA11y('ds-my-dspace-page');
+    testA11y({
+      include: ['ds-my-dspace-page'],
+      exclude: ['.noUi-handle'],
+    });
   });
 
   it('should have a working detailed view that passes accessibility tests', () => {

cypress/e2e/submission.cy.ts

@@ -28,21 +28,21 @@ describe('New Submission page', () => {
 
     // Test entire page for accessibility
     testA11y('ds-submission-edit',
-            {
-              rules: {
-                // Author & Subject fields have invalid "aria-multiline" attrs.
-                // See https://github.com/DSpace/dspace-angular/issues/1272
-                'aria-allowed-attr': { enabled: false },
-                // All panels are accordians & fail "aria-required-children" and "nested-interactive".
-                // Seem to require updating ng-bootstrap and https://github.com/DSpace/dspace-angular/issues/2216
-                'aria-required-children': { enabled: false },
-                'nested-interactive': { enabled: false },
-                // All select boxes fail to have a name / aria-label.
-                // This is a bug in ng-dynamic-forms and may require https://github.com/DSpace/dspace-angular/issues/2216
-                'select-name': { enabled: false },
-              },
-
-            } as Options,
+      {
+        rules: {
+          // Author & Subject fields have invalid "aria-multiline" attrs.
+          // See https://github.com/DSpace/dspace-angular/issues/1272
+          'aria-allowed-attr': { enabled: false },
+          // All panels are accordians & fail "aria-required-children" and "nested-interactive".
+          // Seem to require updating ng-bootstrap and https://github.com/DSpace/dspace-angular/issues/2216
+          'aria-required-children': { enabled: false },
+          'nested-interactive': { enabled: false },
+          // All select boxes fail to have a name / aria-label.
+          // This is a bug in ng-dynamic-forms and may require https://github.com/DSpace/dspace-angular/issues/2216
+          'select-name': { enabled: false },
+        },
+
+      } as Options,
     );
 
     // Discard button should work
@@ -123,7 +123,7 @@ describe('New Submission page', () => {
 
     // Confirm the required license by checking checkbox
     // (NOTE: requires "force:true" cause Cypress claims this checkbox is covered by its own <span>)
-    cy.get('input#granted').check( { force: true } );
+    cy.get('input#granted').check({ force: true });
 
     // Before using Cypress drag & drop, we have to manually trigger the "dragover" event.
     // This ensures our UI displays the dropzone that covers the entire submission page.
@@ -187,20 +187,23 @@ describe('New Submission page', () => {
     cy.get('div#section_license').should('be.visible');
 
     // Test entire page for accessibility
-    testA11y('ds-submission-edit',
-            {
-              rules: {
-                // Author & Subject fields have invalid "aria-multiline" attrs.
-                // See https://github.com/DSpace/dspace-angular/issues/1272
-                'aria-allowed-attr': { enabled: false },
-
-                // All panels are accordians & fail "aria-required-children" and "nested-interactive".
-                // Seem to require updating ng-bootstrap and https://github.com/DSpace/dspace-angular/issues/2216
-                'aria-required-children': { enabled: false },
-                'nested-interactive': { enabled: false },
-              },
-
-            } as Options,
+    testA11y({
+      include: ['ds-submission-edit'],
+      exclude: ['.noUi-handle'],
+    },
+      {
+        rules: {
+          // Author & Subject fields have invalid "aria-multiline" attrs.
+          // See https://github.com/DSpace/dspace-angular/issues/1272
+          'aria-allowed-attr': { enabled: false },
+
+          // All panels are accordians & fail "aria-required-children" and "nested-interactive".
+          // Seem to require updating ng-bootstrap and https://github.com/DSpace/dspace-angular/issues/2216
+          'aria-required-children': { enabled: false },
+          'nested-interactive': { enabled: false },
+        },
+
+      } as Options,
     );
 
     // Back on the form, click the discard button to remove new submission