Merge pull request DSpace#2217 from 4Science/DURACOM-138

Parameter box, shown or not

Author: tdonohue

src/app/process-page/form/process-parameters/process-parameters.component.html

@@ -1,11 +1,11 @@
-<div class="form-group" *ngIf="script">
-    <label>{{'process.new.select-parameters' | translate}}</label>
-    <ds-parameter-select
-            *ngFor="let value of parameterValues; let i = index; let last = last"
-            [parameters]="script.parameters"
-            [parameterValue]="value"
-            [removable]="!last"
-            [index]="i"
-            (removeParameter)="removeParameter(i)"
-            (changeParameter)="updateParameter($event, i)"></ds-parameter-select>
+<div class="form-group" *ngIf="script?.parameters?.length" data-testID="parameters-select-container">
+  <label>{{'process.new.select-parameters' | translate}}</label>
+  <ds-parameter-select
+    *ngFor="let value of parameterValues; let i = index; let last = last"
+    [parameters]="script.parameters"
+    [parameterValue]="value"
+    [removable]="!last"
+    [index]="i"
+    (removeParameter)="removeParameter(i)"
+    (changeParameter)="updateParameter($event, i)"></ds-parameter-select>
 </div>

src/app/process-page/form/process-parameters/process-parameters.component.spec.ts

@@ -14,22 +14,21 @@ import { TranslateLoaderMock } from '../../../shared/mocks/translate-loader.mock
 describe('ProcessParametersComponent', () => {
   let component: ProcessParametersComponent;
   let fixture: ComponentFixture<ProcessParametersComponent>;
-  let parameterValues;
-  let script;
+  let mockParameterValues: ProcessParameter[];
+  let mockScript: Script;
 
-  function init() {
+  function initParametersAndScriptMockValues() {
     const param1 = new ScriptParameter();
     const param2 = new ScriptParameter();
-    script = Object.assign(new Script(), { parameters: [param1, param2] });
-    parameterValues = [
+    mockScript = Object.assign(new Script(), { parameters: [param1, param2] });
+    mockParameterValues = [
       Object.assign(new ProcessParameter(), { name: '-a', value: 'bla' }),
       Object.assign(new ProcessParameter(), { name: '-b', value: '123' }),
       Object.assign(new ProcessParameter(), { name: '-c', value: 'value' }),
     ];
   }
 
   beforeEach(waitForAsync(() => {
-    init();
     TestBed.configureTestingModule({
       imports: [
         FormsModule,
@@ -48,17 +47,34 @@ describe('ProcessParametersComponent', () => {
   beforeEach(() => {
     fixture = TestBed.createComponent(ProcessParametersComponent);
     component = fixture.componentInstance;
-    component.script = script;
-    component.parameterValues = parameterValues;
-    fixture.detectChanges();
   });
 
   it('should create', () => {
     expect(component).toBeTruthy();
   });
 
-  it('should render a ParameterSelectComponent for each parameter value of the component', () => {
-    const selectComponents = fixture.debugElement.queryAll(By.directive(ParameterSelectComponent));
-    expect(selectComponents.length).toBe(parameterValues.length);
+  describe('when parameter values and script are initialized', () => {
+
+    beforeEach(() => {
+      initParametersAndScriptMockValues();
+      component.parameterValues = mockParameterValues;
+      component.script = mockScript;
+
+      fixture.detectChanges();
+    });
+
+    it(`should render a ${ParameterSelectComponent.name} for each parameter value`, () => {
+      const selectComponents = fixture.debugElement.queryAll(By.directive(ParameterSelectComponent));
+      expect(selectComponents.length).toBe(mockParameterValues.length);
+    });
+
+    it('should not render a selector box if the parameter array is empty',() => {
+      fixture.componentInstance.script.parameters = [];
+
+      fixture.detectChanges();
+
+      const formGroupComponent = fixture.debugElement.query(By.css('[data-testID=parameters-select-container]'));
+      expect(formGroupComponent).toBeFalsy();
+    });
   });
 });