Merged in DSC-1528-facets-can-disappear-when-filtering (pull request DSpace#1342)

[DSC-1528] feature: fixed filtering and fixed unit-test

Approved-by: Davide Negretti

Author: vNovski

src/app/shared/search/search-filters/search-filters.component.html

@@ -1,4 +1,4 @@
-<div [class.d-none]="searchFilterCount === 0">
+<div [class.d-none]="!availableFilters">
     <h3>{{"search.filters.head" | translate}}</h3>
     <div *ngIf="(filters | async)?.hasSucceeded">
         <div #searchFilter *ngFor="let filter of (filters | async)?.payload; trackBy: trackUpdate">

src/app/shared/search/search-filters/search-filters.component.spec.ts

@@ -76,7 +76,7 @@ describe('SearchFiltersComponent', () => {
     it('should not render component', () => {
       const menu = fixture.debugElement.query(By.css('div.d-none'));
       expect(menu).not.toBeNull();
-      expect(comp.searchFilterCount).toEqual(0);
+      expect(comp.availableFilters).toEqual(false);
     });
 
   });

src/app/shared/search/search-filters/search-filters.component.ts

@@ -63,7 +63,7 @@ export class SearchFiltersComponent implements OnInit, AfterViewChecked, OnDestr
   /**
    * counts for the active filters
    */
-  searchFilterCount = 0;
+  availableFilters = false;
 
   /**
    * Link to the search page
@@ -112,12 +112,7 @@ export class SearchFiltersComponent implements OnInit, AfterViewChecked, OnDestr
   }
 
   ngAfterViewChecked() {
-    this.searchFilterCount = 0;
-    this.searchFilter._results.forEach(element => {
-      if (element.nativeElement?.children[0]?.children.length > 0) {
-        this.searchFilterCount++;
-      }
-    });
+    this.availableFilters = this.searchFilter._results.some(element => element.nativeElement?.children[0]?.children.length > 0);
   }
 
   ngOnDestroy() {