Skip to content

Commit e8cd53a

Browse files
committed
Merge tag 'dspace-cris-2023.02.06' into ux-plus-2023_02_x
Release DSpace-CRIS 2023.02.06
2 parents 6460332 + 82591f1 commit e8cd53a

7 files changed

Lines changed: 30 additions & 13 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "dspace-angular",
3-
"version": "2023.02.06-SNAPHOT",
3+
"version": "2023.02.06",
44
"scripts": {
55
"ng": "ng",
66
"config:watch": "nodemon",

src/app/cris-layout/cris-layout-loader/cris-layout-horizontal/cris-layout-navbar/cris-layout-navbar.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
<div id="collapsingNav">
1212
<ul class="navbar-nav mr-auto shadow-none">
1313
<ng-container *ngIf="!!(activeTab$ |async)">
14-
<ds-cris-layout-sidebar-item *ngFor="let tab of tabs;" [tab]="tab" [layout]="'horizontal'" [activeTab]="(activeTab$ |async)"
14+
<ds-cris-layout-sidebar-item *ngFor="let tab of tabs;" [itemBaseUrl]="itemBaseUrl" [tab]="tab" [layout]="'horizontal'" [activeTab]="(activeTab$ |async)"
1515
(tabSelectedChange)="setActiveTab($event)"></ds-cris-layout-sidebar-item>
1616
</ng-container>
1717
</ul>
1818
</div>
1919
</div>
2020
</div>
21-
</nav>
21+
</nav>

src/app/cris-layout/cris-layout-loader/cris-layout-vertical/cris-layout-sidebar/cris-layout-sidebar.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div>
55
<ul class="list-unstyled components mb-5">
66
<ng-container *ngIf="!!(activeTab$ |async)">
7-
<ds-cris-layout-sidebar-item *ngFor="let tab of tabs;" [tab]="tab" [layout]="'vertical'" [activeTab]="(activeTab$ |async)"
7+
<ds-cris-layout-sidebar-item *ngFor="let tab of tabs;" [itemBaseUrl]="itemBaseUrl" [tab]="tab" [layout]="'vertical'" [activeTab]="(activeTab$ |async)"
88
(tabSelectedChange)="setActiveTab($event)"></ds-cris-layout-sidebar-item>
99
</ng-container>
1010
</ul>

src/app/cris-layout/cris-layout-loader/shared/cris-layout-tabs/cris-layout-tabs.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,16 @@ export abstract class CrisLayoutTabsComponent {
4747
*/
4848
@Output() selectedTab = new EventEmitter<CrisLayoutTab>();
4949

50+
/**
51+
* The item base url
52+
*/
53+
itemBaseUrl: string;
5054

5155
constructor(public location: Location, public router: Router, public route: ActivatedRoute) {
5256
}
5357

5458
init(): void {
59+
this.itemBaseUrl = getItemPageRoute(this.item) + '/';
5560
if (this.tabs && this.tabs.length > 0) {
5661
if (isNotNull(this.route.snapshot.paramMap.get('tab'))) {
5762
this.parseTabs(this.route.snapshot.paramMap.get('tab'));

src/app/cris-layout/cris-layout-loader/shared/sidebar-item/cris-layout-sidebar-item.component.html

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
<li class="sidebar-section h-100" [ngClass]="{ 'active' : !!tab && !!activeTab && (tab.isActive || tab.id == activeTab.id), 'expanded': expanded, 'vertical': layout == 'vertical', 'horizontal': layout == 'horizontal' }">
22
<div class="icon-wrapper" *ngIf="!tab.children || tab.children.length == 0 ">
3-
<a class="nav-item shortcut-icon" href="javascript:;" [ngClass]="{ 'px-4 justify-content-between' : layout == 'vertical' }"
4-
[title]="getTabHeader(tab)" (click)="$event.preventDefault();selectTab(tab)" [innerHTML]="getTabHeader(tab)">
5-
6-
</a>
3+
<a class="nav-item shortcut-icon"
4+
href="javascript:void(0);"
5+
[ngClass]="{ 'px-4 justify-content-between' : layout == 'vertical' }"
6+
[title]="getTabHeader(tab)"
7+
[routerLink]="itemBaseUrl + tab.shortname"
8+
(click)="$event.stopPropagation();$event.preventDefault();selectTab(tab)"
9+
[innerHTML]="getTabHeader(tab)"></a>
710
</div>
811
<div *ngIf="!!tab.children && tab.children.length > 0 " class="sidebar-collapsible h-100">
912
<a class="nav-item shortcut-icon" href="javascript:;" [ngClass]="{ 'px-4 justify-content-between' : layout == 'vertical' }"
@@ -19,10 +22,14 @@
1922
</a>
2023
<ul class="sidebar-sub-level-items list-unstyled" @slide *ngIf="expanded">
2124
<li *ngFor="let subTab of tab.children" [ngClass]="{'active' : !!subTab && !!activeTab && subTab.id == activeTab.id}">
22-
<a class="nav-item shortcut-icon" href="javascript:;" [ngClass]="{ 'px-4 justify-content-between' : layout == 'vertical' }"
23-
(click)="$event.preventDefault();selectTab(subTab)">
24-
<span id="sidebarName-{{subTab.id}}" class="pl-3 section-header-text" [innerHTML]="getTabHeader(subTab)">
25-
</span>
25+
<a class="nav-item shortcut-icon"
26+
href="javascript:void(0);"
27+
[ngClass]="{ 'px-4 justify-content-between' : layout == 'vertical' }"
28+
[routerLink]="itemBaseUrl + subTab.shortname"
29+
(click)="$event.stopPropagation();$event.preventDefault();selectTab(subTab)">
30+
<span id="sidebarName-{{subTab.id}}"
31+
class="pl-3 section-header-text"
32+
[innerHTML]="getTabHeader(subTab)"></span>
2633
</a>
2734
</li>
2835
</ul>

src/app/cris-layout/cris-layout-loader/shared/sidebar-item/cris-layout-sidebar-item.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ import { TranslateService } from '@ngx-translate/core';
1717
animations: [rotate, slide, rotateNavbar]
1818
})
1919
export class CrisLayoutSidebarItemComponent {
20+
/**
21+
* Contains the items base url
22+
*/
23+
@Input() itemBaseUrl: string;
24+
2025
/**
2126
* The tab that will be shown
2227
*/

src/app/cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/metadataGroup/metadata-group.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export abstract class MetadataGroupComponent extends RenderingTypeStructuredMode
125125
* Returns the translated label, if exists, otherwiuse returns a fallback value
126126
*/
127127
getLabel(field: LayoutField): string {
128-
return this.getTranslationIfExists(`${this.fieldI18nPrefix}.${this.item.entityType}.${this.nestedMetadataPrefix}[${field.metadata}]}`) ??
128+
return this.getTranslationIfExists(`${this.fieldI18nPrefix}.${this.item.entityType}.${this.nestedMetadataPrefix}[${field.metadata}]`) ??
129129
this.getTranslationIfExists(`${this.fieldI18nPrefix}.${this.item.entityType}.[${field.metadata}]`) ??
130130
this.getTranslationIfExists(`${this.fieldI18nPrefix}.${this.item.entityType}.${field.metadata}`) ?? // old syntax - do not use
131131
this.getTranslationIfExists(`${this.fieldI18nPrefix}.[${field.metadata}]`) ??

0 commit comments

Comments
 (0)