94481: Use DSONameService to determine the title for the Item page

Author: alexandrevryghem

src/app/core/breadcrumbs/dso-name.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { hasValue } from '../../shared/empty.util';
+import { hasValue, isEmpty } from '../../shared/empty.util';
 import { DSpaceObject } from '../shared/dspace-object.model';
 import { TranslateService } from '@ngx-translate/core';
 
@@ -27,7 +27,15 @@ export class DSONameService {
    */
   private readonly factories = {
     Person: (dso: DSpaceObject): string => {
-      return `${dso.firstMetadataValue('person.familyName')}, ${dso.firstMetadataValue('person.givenName')}`;
+      const familyName = dso.firstMetadataValue('person.familyName');
+      const givenName = dso.firstMetadataValue('person.givenName');
+      if (isEmpty(familyName) && isEmpty(givenName)) {
+        return dso.firstMetadataValue('dc.title') || dso.name;
+      } else if (isEmpty(familyName) || isEmpty(givenName)) {
+        return familyName || givenName;
+      } else {
+        return `${familyName}, ${givenName}`;
+      }
     },
     OrgUnit: (dso: DSpaceObject): string => {
       return dso.firstMetadataValue('organization.legalName');
@@ -52,7 +60,7 @@ export class DSONameService {
     if (hasValue(match)) {
       return this.factories[match](dso);
     } else {
-      return  this.factories.Default(dso);
+      return this.factories.Default(dso);
     }
   }
 

src/app/item-page/simple/field-components/specific-field/title/item-page-title-field.component.html

@@ -2,5 +2,5 @@ <h2 class="item-page-title-field">
   <div *ngIf="item.firstMetadataValue('dspace.entity.type') as type">
     {{ type.toLowerCase() + '.page.titleprefix' | translate }}
   </div>
-  <ds-metadata-values [mdValues]="item?.allMetadata(fields)"></ds-metadata-values>
+  <span class="dont-break-out">{{ dsoNameService.getName(item) }}</span>
 </h2>

src/app/item-page/simple/field-components/specific-field/title/item-page-title-field.component.ts

@@ -1,34 +1,25 @@
 import { Component, Input } from '@angular/core';
 
 import { Item } from '../../../../../core/shared/item.model';
-import { ItemPageFieldComponent } from '../item-page-field.component';
+import { DSONameService } from '../../../../../core/breadcrumbs/dso-name.service';
 
 @Component({
-    selector: 'ds-item-page-title-field',
-    templateUrl: './item-page-title-field.component.html'
+  selector: 'ds-item-page-title-field',
+  templateUrl: './item-page-title-field.component.html'
 })
 /**
- * This component is used for displaying the title (dc.title) of an item
+ * This component is used for displaying the title (defined by the {@link DSONameService}) of an item
  */
-export class ItemPageTitleFieldComponent extends ItemPageFieldComponent {
+export class ItemPageTitleFieldComponent {
 
-    /**
-     * The item to display metadata for
-     */
-    @Input() item: Item;
+  /**
+   * The item to display metadata for
+   */
+  @Input() item: Item;
 
-    /**
-     * Separator string between multiple values of the metadata fields defined
-     * @type {string}
-     */
-    separator: string;
-
-    /**
-     * Fields (schema.element.qualifier) used to render their values.
-     * In this component, we want to display values for metadata 'dc.title'
-     */
-    fields: string[] = [
-        'dc.title'
-    ];
+  constructor(
+    public dsoNameService: DSONameService,
+  ) {
+  }
 
 }