Merged in task/dspace-cris-2023_02_x/DSC-2166 (pull request DSpace#2770)

[DSC-2166] fix tests failing because of multiple spy registrations

Approved-by: Francesco Molinaro

Author: Andrea Barbasso

src/app/lucky-search/search/lucky-search.component.spec.ts

@@ -139,7 +139,7 @@ describe('LuckySearchComponent', () => {
           }
         })
       });
-      spyOn(routerStub, 'parseUrl').and.returnValue(urlTree);
+      routerStub.parseUrl.and.returnValue(urlTree);
       const data = createSuccessfulRemoteDataObject(createPaginatedList([
         firstSearchResult, secondSearchResult
       ]));
@@ -203,7 +203,7 @@ describe('LuckySearchComponent', () => {
       spyOn((component as any), 'loadBitstreamsAndRedirectIfNeeded').and.returnValue(observableOf([bitstream]));
       spyOn((component as any), 'hasBitstreamFilters').and.returnValue(true);
       spyOn(component, 'redirect');
-      spyOn(routerStub, 'parseUrl').and.returnValue(bitstreamSearchTree);
+      routerStub.parseUrl.and.returnValue(bitstreamSearchTree);
 
       component.resultsRD$.next(data);
 
@@ -266,7 +266,7 @@ describe('LuckySearchComponent', () => {
       spyOn((component as any), 'loadBitstreamsAndRedirectIfNeeded').and.returnValue(observableOf([bitstream]));
       spyOn((component as any), 'hasBitstreamFilters').and.returnValue(true);
       spyOn(component, 'redirect');
-      spyOn(routerStub, 'parseUrl').and.returnValue(bitstreamSearchTree);
+      routerStub.parseUrl.and.returnValue(bitstreamSearchTree);
 
       component.resultsRD$.next(data);
 

src/app/shared/mocks/router.mock.ts

@@ -18,6 +18,7 @@ export class RouterMock {
   // noinspection TypeScriptUnresolvedFunction
   navigate = jasmine.createSpy('navigate');
   navigateByUrl = jasmine.createSpy('navigateByUrl');
+  parseUrl = jasmine.createSpy('parseUrl');
 
   serializeUrl(url: UrlTree): string {
     return url ? url.toString() : '';
@@ -38,8 +39,4 @@ export class RouterMock {
   get url() {
     return this.routerState.snapshot.url;
   }
-
-  parseUrl(url: string): UrlTree {
-    return null;
-  }
 }