[DURACOM-426] fix some tests

Author: FrancescoMolinaro

src/app/shared/metadata-link-view/metadata-link-view-avatar-popover/metadata-link-view-avatar-popover.component.spec.ts

@@ -11,11 +11,12 @@ import {
   of,
 } from 'rxjs';
 
-import { AuthService } from '../../../core/auth/auth.service';
-import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
-import { FileService } from '../../../core/shared/file.service';
+import { AuthService } from '@dspace/core/auth/auth.service';
+import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
+import { FileService } from '@dspace/core/shared/file.service';
 import { ThemedLoadingComponent } from '../../loading/themed-loading.component';
 import { MetadataLinkViewAvatarPopoverComponent } from './metadata-link-view-avatar-popover.component';
+import { getMockTranslateService } from "@dspace/core/testing/translate.service.mock";
 
 describe('MetadataLinkViewAvatarPopoverComponent', () => {
   let component: MetadataLinkViewAvatarPopoverComponent;
@@ -35,19 +36,13 @@ describe('MetadataLinkViewAvatarPopoverComponent', () => {
     fileService = jasmine.createSpyObj('FileService', {
       retrieveFileDownloadLink: null,
     });
-    translateServiceStub = {
-      get: () => of('translated-text'),
-      onLangChange: new EventEmitter(),
-      onTranslationChange: new EventEmitter(),
-      onDefaultLangChange: new EventEmitter(),
-    };
     TestBed.configureTestingModule({
       imports: [MetadataLinkViewAvatarPopoverComponent],
       providers: [
         { provide: AuthService, useValue: authService },
         { provide: AuthorizationDataService, useValue: authorizationService },
         { provide: FileService, useValue: fileService },
-        { provide: TranslateService, useValue: translateServiceStub },
+        { provide: TranslateService, useValue: getMockTranslateService() },
       ],
     })
       .overrideComponent(MetadataLinkViewAvatarPopoverComponent, { remove: { imports: [ThemedLoadingComponent] } }).compileComponents();

src/app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.spec.ts

@@ -10,10 +10,10 @@ import {
 import { Item } from 'src/app/core/shared/item.model';
 import { MetadataValue } from 'src/app/core/shared/metadata.models';
 
-import { createSuccessfulRemoteDataObject$ } from '../../remote-data.utils';
-import { ConfigurationDataService } from './../../../core/data/configuration-data.service';
-import { TranslateLoaderMock } from './../../testing/translate-loader.mock';
+import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
 import { MetadataLinkViewOrcidComponent } from './metadata-link-view-orcid.component';
+import { TranslateLoaderMock } from "@dspace/core/testing/translate-loader.mock";
+import { createSuccessfulRemoteDataObject$ } from "@dspace/core/utilities/remote-data.utils";
 
 describe('MetadataLinkViewOrcidComponent', () => {
   let component: MetadataLinkViewOrcidComponent;

src/app/shared/metadata-link-view/metadata-link-view-popover/metadata-link-view-popover.component.spec.ts

@@ -1,8 +1,7 @@
 import { NO_ERRORS_SCHEMA } from '@angular/core';
 import {
-  async,
   ComponentFixture,
-  TestBed,
+  TestBed, waitForAsync,
 } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { ActivatedRoute } from '@angular/router';
@@ -12,10 +11,10 @@ import { Item } from 'src/app/core/shared/item.model';
 import { MetadataValueFilter } from 'src/app/core/shared/metadata.models';
 import { environment } from 'src/environments/environment.test';
 
-import { createSuccessfulRemoteDataObject$ } from '../../remote-data.utils';
 import { MetadataLinkViewAvatarPopoverComponent } from '../metadata-link-view-avatar-popover/metadata-link-view-avatar-popover.component';
 import { MetadataLinkViewOrcidComponent } from '../metadata-link-view-orcid/metadata-link-view-orcid.component';
 import { MetadataLinkViewPopoverComponent } from './metadata-link-view-popover.component';
+import { createSuccessfulRemoteDataObject$ } from "@dspace/core/utilities/remote-data.utils";
 
 describe('MetadataLinkViewPopoverComponent', () => {
   let component: MetadataLinkViewPopoverComponent;
@@ -71,7 +70,7 @@ describe('MetadataLinkViewPopoverComponent', () => {
     thumbnail: createSuccessfulRemoteDataObject$(new Bitstream()),
   });
 
-  beforeEach(async(() => {
+  beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot(), MetadataLinkViewPopoverComponent],
       schemas: [NO_ERRORS_SCHEMA],

src/app/shared/metadata-link-view/metadata-link-view.component.spec.ts

@@ -13,14 +13,12 @@ import { ItemDataService } from '../../core/data/item-data.service';
 import { Item } from '../../core/shared/item.model';
 import { MetadataValue } from '../../core/shared/metadata.models';
 import { EntityIconDirective } from '../entity-icon/entity-icon.directive';
-import {
-  createFailedRemoteDataObject$,
-  createSuccessfulRemoteDataObject$,
-} from '../remote-data.utils';
+
 import { VarDirective } from '../utils/var.directive';
 import { MetadataLinkViewComponent } from './metadata-link-view.component';
 import SpyObj = jasmine.SpyObj;
 import { MetadataLinkViewPopoverComponent } from './metadata-link-view-popover/metadata-link-view-popover.component';
+import { createFailedRemoteDataObject$, createSuccessfulRemoteDataObject$ } from "@dspace/core/utilities/remote-data.utils";
 
 describe('MetadataLinkViewComponent', () => {
   let component: MetadataLinkViewComponent;

src/app/shared/object-list/item-list-element/item-types/item/item-list-element.component.spec.ts

@@ -26,6 +26,8 @@ import { ThemeService } from '../../../../theme-support/theme.service';
 import { TruncatableService } from '../../../../truncatable/truncatable.service';
 import { TruncatePipe } from '../../../../utils/truncate.pipe';
 import { ItemListElementComponent } from './item-list-element.component';
+import { provideMockStore } from "@ngrx/store/testing";
+import { APP_DATA_SERVICES_MAP } from "@dspace/core/data-services-map-type";
 
 const mockItem: Item = Object.assign(new Item(), {
   bundles: of({}),
@@ -85,8 +87,6 @@ describe('ItemListElementComponent', () => {
         TranslateModule.forRoot(),
         TruncatePipe,
       ],
-      declarations: [
-      ],
       providers: [
         { provide: DSONameService, useValue: new DSONameServiceMock() },
         { provide: APP_CONFIG, useValue: environment },
@@ -96,6 +96,8 @@ describe('ItemListElementComponent', () => {
         { provide: ThemeService, useValue: themeService },
         { provide: TruncatableService, useValue: truncatableService },
         { provide: XSRFService, useValue: {} },
+        { provide: APP_DATA_SERVICES_MAP, useValue: {} },
+        provideMockStore(),
       ],
     }).overrideComponent(ItemListElementComponent, {
       set: { changeDetection: ChangeDetectionStrategy.Default },

src/app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component.spec.ts

@@ -30,6 +30,7 @@ import { ThemeService } from '../../../../../theme-support/theme.service';
 import { TruncatableService } from '../../../../../truncatable/truncatable.service';
 import { TruncatePipe } from '../../../../../utils/truncate.pipe';
 import { ItemSearchResultListElementComponent } from './item-search-result-list-element.component';
+import { provideMockStore } from "@ngrx/store/testing";
 
 let publicationListElementComponent: ItemSearchResultListElementComponent;
 let fixture: ComponentFixture<ItemSearchResultListElementComponent>;
@@ -225,6 +226,7 @@ describe('ItemSearchResultListElementComponent', () => {
             'invalidateAuthorizationsRequestCache',
           ]),
         },
+        provideMockStore()
       ],
       schemas: [NO_ERRORS_SCHEMA],
     }).overrideComponent(ItemSearchResultListElementComponent, {

src/app/shared/object-list/search-result-list-element/search-result-list-element.component.ts

@@ -31,7 +31,7 @@ export class SearchResultListElementComponent<T extends SearchResult<K>, K exten
   /**
    * Limit of additional metadata values to show
    */
-  additionalMetadataLimit;
+  additionalMetadataLimit: number;
 
   public constructor(protected truncatableService: TruncatableService,
                      public dsoNameService: DSONameService,
@@ -43,7 +43,7 @@ export class SearchResultListElementComponent<T extends SearchResult<K>, K exten
    * Retrieve the dso from the search result
    */
   ngOnInit(): void {
-    this.additionalMetadataLimit = this.appConfig.followAuthorityMetadataValuesLimit;
+    this.additionalMetadataLimit = this.appConfig?.followAuthorityMetadataValuesLimit;
     if (hasValue(this.object)) {
       this.dso = this.object.indexableObject;
       this.dsoTitle = this.dsoNameService.getHitHighlights(this.object, this.dso, true);

src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.spec.ts

@@ -17,6 +17,8 @@ import { TranslateModule } from '@ngx-translate/core';
 
 import { TruncatableService } from '../../truncatable/truncatable.service';
 import { VarDirective } from '../../utils/var.directive';
+import { TruncatablePartComponent } from "../../truncatable/truncatable-part/truncatable-part.component";
+import { APP_CONFIG } from "@dspace/config/app-config.interface";
 
 export function createSidebarSearchListElementTests(
   componentClass: any,
@@ -33,6 +35,12 @@ export function createSidebarSearchListElementTests(
 
     let linkService;
 
+    const environment = {
+      browseBy: {
+        showThumbnails: true,
+      },
+    };
+
     beforeEach(waitForAsync(() => {
       linkService = jasmine.createSpyObj('linkService', {
         resolveLink: Object.assign(new HALResource(), {
@@ -44,11 +52,12 @@ export function createSidebarSearchListElementTests(
         providers: [
           { provide: TruncatableService, useValue: mockTruncatableService },
           { provide: LinkService, useValue: linkService },
+          { provide: APP_CONFIG, useValue: environment },
           DSONameService,
           ...extraProviders,
         ],
         schemas: [NO_ERRORS_SCHEMA],
-      }).compileComponents();
+      }).overrideComponent(componentClass, { remove: { imports: [TruncatablePartComponent] } }).compileComponents();
     }));
 
     beforeEach(() => {

src/environments/environment.test.ts

@@ -2,6 +2,11 @@
 import { NotificationAnimationsType } from '@dspace/config/notifications-config.interfaces';
 import { RestRequestMethod } from '@dspace/config/rest-request-method';
 import { BuildConfig } from 'src/config/build-config.interface';
+import { CrisLayoutConfig } from "@dspace/config/layout-config.interfaces";
+import { SearchResultConfig } from "@dspace/config/search-result-config.interface";
+import { MetadataLinkViewPopoverDataConfig } from "@dspace/config/metadata-link-view-popoverdata-config.interface";
+import { IdentifierSubtypesConfig } from "@dspace/config/identifier-subtypes-config.interface";
+import { FollowAuthorityMetadata } from "@dspace/config/search-follow-metadata.interface";
 
 export const environment: BuildConfig = {
   production: false,
@@ -476,4 +481,101 @@ export const environment: BuildConfig = {
   accessibility: {
     cookieExpirationDuration: 7,
   },
+
+  crisLayout: {
+    crisRef: [
+      {
+        entityType: 'DEFAULT',
+        entityStyle: {
+          default: {
+            icon: 'fa fa-info',
+            style: 'text-info',
+          },
+        },
+      },
+      {
+        entityType: 'PERSON',
+        entityStyle: {
+          default: {
+            icon: 'fa fa-user',
+            style: 'text-info',
+          },
+        },
+      },
+      {
+        entityType: 'ORGUNIT',
+        entityStyle: {
+          default: {
+            icon: 'fa fa-university',
+            style: 'text-info',
+          },
+        },
+      },
+      {
+        entityType: 'PROJECT',
+        entityStyle: {
+          default: {
+            icon: 'fas fa-project-diagram',
+            style: 'text-info',
+          },
+        },
+      },
+    ],
+    crisRefStyleMetadata: {
+      default: 'cris.entity.style',
+    },
+  },
+
+  searchResult: {
+    additionalMetadataFields: [],
+    authorMetadata: ['dc.contributor.author', 'dc.creator', 'dc.contributor.*'],
+  },
+
+  metadataLinkViewPopoverData:  {
+    fallbackMetdataList: ['dc.description.abstract'],
+
+    entityDataConfig: [
+      {
+        entityType: 'Person',
+        metadataList: ['person.affiliation.name', 'person.email', 'person.identifier.orcid', 'dc.description.abstract'],
+      },
+      {
+        entityType: 'OrgUnit',
+        metadataList: ['organization.parentOrganization', 'organization.identifier.ror', 'crisou.director', 'dc.description.abstract'],
+      },
+      {
+        entityType: 'Project',
+        metadataList: ['oairecerif.project.status', 'dc.description.abstract'],
+      },
+      {
+        entityType: 'Funding',
+        metadataList: ['oairecerif.funder', 'oairecerif.fundingProgram', 'dc.description.abstract'],
+      },
+      {
+        entityType: 'Publication',
+        metadataList: ['dc.identifier.doi', 'dc.identifier.uri', 'dc.description.abstract'],
+      },
+    ],
+  },
+
+  identifierSubtypes: [],
+
+  followAuthorityMaxItemLimit: 100,
+
+  followAuthorityMetadataValuesLimit: 5,
+
+  followAuthorityMetadata:   [
+    {
+      type: 'Publication',
+      metadata: ['dc.contributor.author'],
+    },
+    {
+      type: 'Product',
+      metadata: ['dc.contributor.author'],
+    },
+    {
+      type: 'Patent',
+      metadata: ['dc.contributor.author'],
+    },
+  ]
 };