117287: Fixed various layout issues

- The unthemed home news didn't stick to the header like the dspace theme
- Impersonate user button has additional margin
- Submission form loading icon is not translatable
- Create resource policy page doesn't have the correct heading

(cherry picked from commit 56e45a9)

Author: alexandrevryghem

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts

@@ -1,6 +1,5 @@
 import {
   AsyncPipe,
-  NgClass,
   NgFor,
   NgIf,
 } from '@angular/common';
@@ -88,7 +87,6 @@ import { ValidateEmailNotTaken } from './validators/email-taken.validator';
     NgFor,
     AsyncPipe,
     TranslateModule,
-    NgClass,
     ThemedLoadingComponent,
     PaginationComponent,
     RouterLink,

src/app/shared/resource-policies/create/resource-policy-create.component.html

@@ -1,5 +1,5 @@
 <div class="container">
-  <h4 class="mb-3">{{'resource-policies.create.page.heading' | translate}} {{targetResourceName}}</h4>
+  <h1 class="mb-3">{{'resource-policies.create.page.heading' | translate}} {{targetResourceName}}</h1>
 
   <ds-resource-policy-form [isProcessing]="isProcessing()"
                            (reset)="redirectToAuthorizationsPage()"

src/app/submission/form/submission-form.component.html

@@ -27,7 +27,7 @@
     </div>
 
     <div class="submission-form-content">
-        <ds-loading *ngIf="(isLoading$ | async)" message="Loading..."></ds-loading>
+        <ds-loading *ngIf="(isLoading$ | async)" [message]="'form.loading' | translate"></ds-loading>
         <ng-container *ngFor="let object of $any(submissionSections | async)">
             <ds-submission-section-container [collectionId]="collectionId"
                                              [submissionId]="submissionId"

src/app/submission/form/submission-form.component.spec.ts

@@ -1,7 +1,6 @@
 import {
   ChangeDetectorRef,
   Component,
-  NO_ERRORS_SCHEMA,
   SimpleChange,
 } from '@angular/core';
 import {
@@ -10,6 +9,7 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
+import { TranslateModule } from '@ngx-translate/core';
 import {
   cold,
   getTestScheduler,
@@ -31,12 +31,10 @@ import {
   mockSubmissionSelfUrl,
   mockSubmissionState,
 } from '../../shared/mocks/submission.mock';
-import { getMockThemeService } from '../../shared/mocks/theme-service.mock';
 import { AuthServiceStub } from '../../shared/testing/auth-service.stub';
 import { HALEndpointServiceStub } from '../../shared/testing/hal-endpoint-service.stub';
 import { SubmissionServiceStub } from '../../shared/testing/submission-service.stub';
 import { createTestComponent } from '../../shared/testing/utils.test';
-import { ThemeService } from '../../shared/theme-support/theme.service';
 import { SubmissionSectionContainerComponent } from '../sections/container/section-container.component';
 import { SectionsService } from '../sections/sections.service';
 import { VisibilityType } from '../sections/visibility-type';
@@ -67,18 +65,19 @@ describe('SubmissionFormComponent', () => {
 
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
-      imports: [SubmissionFormComponent, TestComponent,
+      imports: [
+        SubmissionFormComponent,
+        TestComponent,
+        TranslateModule.forRoot(),
       ],
       providers: [
         { provide: AuthService, useClass: AuthServiceStub },
         { provide: HALEndpointService, useValue: new HALEndpointServiceStub('workspaceitems') },
         { provide: SubmissionService, useValue: submissionServiceStub },
         { provide: SectionsService, useValue: { isSectionTypeAvailable: () => observableOf(true) } },
-        { provide: ThemeService, useValue: getMockThemeService() },
         ChangeDetectorRef,
         SubmissionFormComponent,
       ],
-      schemas: [NO_ERRORS_SCHEMA],
     })
       .overrideComponent(SubmissionFormComponent, {
         remove: {

src/app/submission/form/submission-form.component.ts

@@ -7,6 +7,7 @@ import {
   OnDestroy,
   SimpleChanges,
 } from '@angular/core';
+import { TranslateModule } from '@ngx-translate/core';
 import isEqual from 'lodash/isEqual';
 import {
   Observable,
@@ -64,6 +65,7 @@ import { ThemedSubmissionUploadFilesComponent } from './submission-upload-files/
     ThemedSubmissionUploadFilesComponent,
     SubmissionFormCollectionComponent,
     SubmissionFormSectionAddComponent,
+    TranslateModule,
   ],
   standalone: true,
 })