Skip to content

Commit d1dc8e6

Browse files
[DURACOM-195] replace ul/li with div in sidebar
1 parent 8e35c0f commit d1dc8e6

4 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<li role="presentation">
1+
<div>
22
<a class="sidebar-section-wrapper"
33
[ngClass]="{ disabled: isDisabled }"
44
role="menuitem"
@@ -18,4 +18,4 @@
1818
</div>
1919
</div>
2020
</a>
21-
</li>
21+
</div>

src/app/admin/admin-sidebar/admin-sidebar.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ <h4 class="my-1">{{ 'menu.header.admin' | translate }}</h4>
2828
<!-- ITEMS -->
2929

3030
<div class="sidebar-full-width-container" id="sidebar-top-level-items-container">
31-
<ul class="sidebar-full-width-container" id="sidebar-top-level-items" role="menubar"
31+
<div class="sidebar-full-width-container" id="sidebar-top-level-items" role="menubar"
3232
[attr.aria-label]="'menu.header.admin.description' |translate">
3333
<ng-container *ngFor="let section of (sections | async)">
3434
<ng-container
3535
*ngComponentOutlet="(sectionMap$ | async).get(section.id).component; injector: (sectionMap$ | async).get(section.id).injector;"></ng-container>
3636
</ng-container>
37-
</ul>
37+
</div>
3838
</div>
3939

4040
<!-- TOGGLER -->

src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<li [ngClass]="{'expanded': (isExpanded$ | async)}" role="presentation"
1+
<div [ngClass]="{'expanded': (isExpanded$ | async)}"
22
[@bgColor]="{
33
value: ((isExpanded$ | async) ? 'endBackground' : 'startBackground'),
44
params: {endColor: (sidebarActiveBg$ | async)}
@@ -33,14 +33,14 @@
3333
<div class="sidebar-fixed-element-wrapper"></div>
3434
<div class="sidebar-collapsible-element-outer-wrapper">
3535
<div class="sidebar-collapsible-element-inner-wrapper">
36-
<ul class="sidebar-sub-level-item-list" role="menu" [id]="adminMenuSectionId(section.id)" [attr.aria-label]="('menu.section.' + section.id) | translate">
37-
<li class="sidebar-item" role="presentation" *ngFor="let subSection of (subSections$ | async)">
36+
<div class="sidebar-sub-level-item-list" role="menu" [id]="adminMenuSectionId(section.id)" [attr.aria-label]="('menu.section.' + section.id) | translate">
37+
<div class="sidebar-item" *ngFor="let subSection of (subSections$ | async)">
3838
{{ (sectionMap$ | async).get(subSection.id).component | json}}
3939
<ng-container
4040
*ngComponentOutlet="(sectionMap$ | async).get(subSection.id).component; injector: (sectionMap$ | async).get(subSection.id).injector;"></ng-container>
41-
</li>
42-
</ul>
41+
</div>
42+
</div>
4343
</div>
4444
</div>
4545
</div>
46-
</li>
46+
</div>

src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
:host {
2-
ul.sidebar-sub-level-item-list {
2+
.sidebar-sub-level-item-list {
33
list-style: none;
44
margin: 0;
55
padding: 0;

0 commit comments

Comments
 (0)