94301: Limit error propagation to concat groups

Author: ybnd

src/app/shared/form/form.service.spec.ts

@@ -186,7 +186,9 @@ describe('FormService test suite', () => {
     expect(formGroup.controls.description.touched).toBe(true);
   });
 
-  it('should add errors to fields of group', () => {
+  it('should add errors to fields of concat group', () => {
+    (builderService as any).isConcatGroup.and.returnValue(true);
+
     let control = controls.addressLocation;
     let model = formModel.find((mdl: DynamicFormControlModel) => mdl.id === 'addressLocation');
     let errorKeys: string[];
@@ -240,7 +242,9 @@ describe('FormService test suite', () => {
     expect(formGroup.controls.description.touched).toBe(false);
   });
 
-  it('should remove errors from fields of group', () => {
+  it('should remove errors from fields of concat group', () => {
+    (builderService as any).isConcatGroup.and.returnValue(true);
+
     let control = controls.addressLocation;
     let model = formModel.find((mdl: DynamicFormControlModel) => mdl.id === 'addressLocation');
     let errorKeys: string[];

src/app/shared/form/form.service.ts

@@ -161,8 +161,8 @@ export class FormService {
       field.setErrors(error);
     }
 
-    // if the field in question is a group, pass down the error to its fields
-    if (field instanceof FormGroup && model instanceof DynamicFormGroupModel) {
+    // if the field in question is a concat group, pass down the error to its fields
+    if (field instanceof FormGroup && model instanceof DynamicFormGroupModel && this.formBuilderService.isConcatGroup(model)) {
       model.group.forEach((subModel) => {
         const subField = field.controls[subModel.id];
 
@@ -182,8 +182,8 @@ export class FormService {
       field.setErrors(error);
     }
 
-    // if the field in question is a group, clear the error from its fields
-    if (field instanceof FormGroup && model instanceof DynamicFormGroupModel) {
+    // if the field in question is a concat group, clear the error from its fields
+    if (field instanceof FormGroup && model instanceof DynamicFormGroupModel && this.formBuilderService.isConcatGroup(model)) {
       model.group.forEach((subModel) => {
         const subField = field.controls[subModel.id];
 

src/app/shared/mocks/form-builder-service.mock.ts

@@ -19,6 +19,7 @@ export function getMockFormBuilderService(): FormBuilderService {
     isQualdropGroup: false,
     isModelInCustomGroup: true,
     isRelationGroup: true,
+    isConcatGroup: false,
     hasArrayGroupValue: true,
     getTypeBindModel: new DsDynamicInputModel({
         name: 'dc.type',