[UXP-111] feautre: implemented the service into functionality

Author: vNovski

src/app/core/core.module.ts

@@ -239,6 +239,7 @@ import { ProductDatasetSchemaType } from './metadata/schema-json-ld/schema-types
 import { PersonSchemaType } from './metadata/schema-json-ld/schema-types/Person/person-schema-type';
 import { InternalLinkService } from './services/internal-link.service';
 import { UnpaywallItemService } from './data/unpaywall-item.service';
+import { InternalLinkService } from './services/internal-link.service';
 
 /**
  * When not in production, endpoint responses can be mocked for testing purposes

src/app/core/services/internal-link.service.spec.ts

@@ -47,22 +47,22 @@ describe('InternalLinkService', () => {
 
   describe('transformInternalLink', () => {
     it('should transform internal link by removing currentURL', () => {
-      const result = service.transformInternalLink('https://currentdomain/my-link');
+      const result = service.getRelativePath('https://currentdomain/my-link');
       expect(result).toBe('/my-link');
     });
 
     it('should transform internal link by adding leading "/" if missing', () => {
-      const result = service.transformInternalLink('currentdomain/my-link');
+      const result = service.getRelativePath('currentdomain/my-link');
       expect(result).toBe('/my-link');
     });
 
     it('should return unchanged link for external link', () => {
-      const result = service.transformInternalLink('https://externalDomain/my-link');
+      const result = service.getRelativePath('https://externalDomain/my-link');
       expect(result).toBe('https://externalDomain/my-link');
     });
 
     it('should return unchanged link for internal link with leading "/"', () => {
-      const result = service.transformInternalLink('/my-link');
+      const result = service.getRelativePath('/my-link');
       expect(result).toBe('/my-link');
     });
   });

src/app/shared/carousel/carousel.component.html

@@ -1,10 +1,10 @@
 <ngb-carousel #carousel [interval]="2000" (slide)="onSlide($event)" class="ds-carousel">
   <ng-template ngbSlide *ngFor="let item of items; let i = index; let last = last">
     <ng-container *ngIf="getItemLink(item.indexableObject); let currentLink; else carouselContent">
-      <a *ngIf="isLinkInternal(currentLink)" [routerLink]="transformInternalLink(currentLink)">
+      <a *ngIf="internalLinkService.isLinkInternal(currentLink)" [routerLink]="internalLinkService.getRelativePath(currentLink)">
         <ng-container *ngTemplateOutlet="carouselContent"></ng-container>
       </a>
-      <a *ngIf="!isLinkInternal(currentLink)" [href]="currentLink" [target]="carouselOptions.targetBlank ? '_blank' : null">
+      <a *ngIf="!internalLinkService.isLinkInternal(currentLink)" [href]="currentLink" [target]="carouselOptions.targetBlank ? '_blank' : null">
         <ng-container *ngTemplateOutlet="carouselContent"></ng-container>
       </a>
     </ng-container>

src/app/shared/carousel/carousel.component.ts

@@ -8,6 +8,7 @@ import {Bitstream} from '../../core/shared/bitstream.model';
 import {BitstreamDataService} from '../../core/data/bitstream-data.service';
 import {NativeWindowRef, NativeWindowService} from '../../core/services/window.service';
 import {getFirstCompletedRemoteData} from '../../core/shared/operators';
+import {InternalLinkService} from '../../core/services/internal-link.service';
 import {hasValue} from '../empty.util';
 import {ItemSearchResult} from '../object-collection/shared/item-search-result.model';
 import {followLink} from '../utils/follow-link-config.model';
@@ -87,6 +88,7 @@ export class CarouselComponent implements OnInit {
   isLoading$ = new BehaviorSubject(true);
 
   constructor(
+    public internalLinkService: InternalLinkService,
     protected bitstreamDataService: BitstreamDataService,
     @Inject(NativeWindowService) private _window: NativeWindowRef,
   ) {
@@ -163,19 +165,6 @@ export class CarouselComponent implements OnInit {
     return item.firstMetadataValue(this.link);
   }
 
-  isLinkInternal(link: string) {
-    return link.startsWith('/') || link.startsWith(this.currentURL);
-  }
-
-  transformInternalLink(link: string) {
-    if (link.startsWith(this.currentURL)) {
-      const currentSegments = link.substring(this.currentURL.length);
-      return currentSegments.startsWith('/') ? currentSegments : `/${currentSegments}`;
-    } else {
-      return link;
-    }
-  }
-
   /**
    * to open a link of an item
    */