Skip to content

Commit c517ed0

Browse files
committed
93803: Fix broken SearchDataImpl
I'd originally removed this `...linksToFollow` but it's actually required here because it's used when constructing the RemoteData Added cypress/downloads to .gitignore because I'd accidentally committed a downloads.html file after running e2e tests locally
1 parent 919b406 commit c517ed0

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

cypress/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
screenshots/
22
videos/
3+
downloads/

src/app/core/data/base/search-data.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ describe('SearchDataImpl', () => {
134134
const out: any = service.searchBy('testMethod', options, false, true, ...linksToFollow);
135135

136136
expect(service.getSearchByHref).toHaveBeenCalledWith('testMethod', options, ...linksToFollow);
137-
expect(service.findListByHref).toHaveBeenCalledWith('endpoint', undefined, false, true);
137+
expect(service.findListByHref).toHaveBeenCalledWith('endpoint', undefined, false, true, ...linksToFollow);
138138
expect(out).toBe('resulting remote data');
139139
});
140140
});

src/app/core/data/base/search-data.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export class SearchDataImpl<T extends CacheableObject> extends BaseDataService<T
9999
searchBy(searchMethod: string, options: FindListOptions = {}, useCachedVersionIfAvailable = true, reRequestOnStale = true, ...linksToFollow: FollowLinkConfig<T>[]): Observable<RemoteData<PaginatedList<T>>> {
100100
const hrefObs = this.getSearchByHref(searchMethod, options, ...linksToFollow);
101101

102-
return this.findListByHref(hrefObs, undefined, useCachedVersionIfAvailable, reRequestOnStale);
102+
return this.findListByHref(hrefObs, undefined, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow);
103103
}
104104

105105
/**

0 commit comments

Comments
 (0)