Skip to content

Commit c23500b

Browse files
Merge remote-tracking branch 'alex/create-themable-comcolpage-content_contribute-7.4' into minor-themed-component-fixes_contribute-main
# Conflicts: # src/app/browse-by/browse-by-metadata-page/browse-by-metadata-page.component.html # src/app/collection-page/collection-page.component.html # src/app/community-page/community-page.component.html # src/app/shared/comcol/comcol.module.ts
2 parents bb490f8 + 106182d commit c23500b

5 files changed

Lines changed: 66 additions & 16 deletions

File tree

src/app/collection-page/collection-page.component.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
[title]="'collection.page.handle'">
2323
</ds-themed-comcol-page-handle>
2424
<!-- Introductory text -->
25-
<ds-comcol-page-content
25+
<ds-themed-comcol-page-content
2626
[content]="collection.introductoryText"
2727
[hasInnerHtml]="true">
28-
</ds-comcol-page-content>
28+
</ds-themed-comcol-page-content>
2929
<!-- News -->
30-
<ds-comcol-page-content
30+
<ds-themed-comcol-page-content
3131
[content]="collection.sidebarText"
3232
[hasInnerHtml]="true"
3333
[title]="'collection.page.news'">
34-
</ds-comcol-page-content>
34+
</ds-themed-comcol-page-content>
3535
</header>
3636
<ds-dso-edit-menu></ds-dso-edit-menu>
3737
</div>
@@ -46,10 +46,10 @@
4646
</section>
4747
<footer *ngIf="collection.copyrightText" class="border-top my-5 pt-4">
4848
<!-- Copyright -->
49-
<ds-comcol-page-content
49+
<ds-themed-comcol-page-content
5050
[content]="collection.copyrightText"
5151
[hasInnerHtml]="true">
52-
</ds-comcol-page-content>
52+
</ds-themed-comcol-page-content>
5353
</footer>
5454
</div>
5555
</div>
@@ -58,4 +58,4 @@
5858
<ds-themed-loading *ngIf="collectionRD?.isLoading"
5959
message="{{'loading.collection' | translate}}"></ds-themed-loading>
6060
</div>
61-
</div>
61+
</div>

src/app/community-page/community-page.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
<ds-themed-comcol-page-handle [content]="communityPayload.handle" [title]="'community.page.handle'">
1414
</ds-themed-comcol-page-handle>
1515
<!-- Introductory text -->
16-
<ds-comcol-page-content [content]="communityPayload.introductoryText" [hasInnerHtml]="true">
17-
</ds-comcol-page-content>
16+
<ds-themed-comcol-page-content [content]="communityPayload.introductoryText" [hasInnerHtml]="true">
17+
</ds-themed-comcol-page-content>
1818
<!-- News -->
19-
<ds-comcol-page-content [content]="communityPayload.sidebarText" [hasInnerHtml]="true"
19+
<ds-themed-comcol-page-content [content]="communityPayload.sidebarText" [hasInnerHtml]="true"
2020
[title]="'community.page.news'">
21-
</ds-comcol-page-content>
21+
</ds-themed-comcol-page-content>
2222
</header>
2323
<ds-dso-edit-menu></ds-dso-edit-menu>
2424
</div>
@@ -32,8 +32,8 @@
3232
</section>
3333
<footer *ngIf="communityPayload.copyrightText" class="border-top my-5 pt-4">
3434
<!-- Copyright -->
35-
<ds-comcol-page-content [content]="communityPayload.copyrightText" [hasInnerHtml]="true">
36-
</ds-comcol-page-content>
35+
<ds-themed-comcol-page-content [content]="communityPayload.copyrightText" [hasInnerHtml]="true">
36+
</ds-themed-comcol-page-content>
3737
</footer>
3838
</div>
3939
</div>

src/app/shared/comcol/comcol-page-content/comcol-page-content.component.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,19 @@ import {
1616
})
1717
export class ComcolPageContentComponent {
1818

19-
// Optional title
19+
/**
20+
* Optional title
21+
*/
2022
@Input() title: string;
2123

22-
// The content to render. Might be html
24+
/**
25+
* The content to render. Might be html
26+
*/
2327
@Input() content: string;
2428

25-
// flag whether the content contains html syntax or not
29+
/**
30+
* flag whether the content contains html syntax or not
31+
*/
2632
@Input() hasInnerHtml: boolean;
2733

2834
}
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
import {
2+
Component,
3+
Input,
4+
} from '@angular/core';
5+
6+
import { ThemedComponent } from '../../theme-support/themed.component';
7+
import { ComcolPageContentComponent } from './comcol-page-content.component';
8+
9+
/**
10+
* Themed wrapper for {@link ComcolPageContentComponent}
11+
*/
12+
@Component({
13+
selector: 'ds-themed-comcol-page-content',
14+
templateUrl: '../../theme-support/themed.component.html',
15+
})
16+
export class ThemedComcolPageContentComponent extends ThemedComponent<ComcolPageContentComponent> {
17+
18+
@Input() title: string;
19+
20+
@Input() content: string;
21+
22+
@Input() hasInnerHtml: boolean;
23+
24+
protected inAndOutputNames: (keyof ComcolPageContentComponent & keyof this)[] = [
25+
'title',
26+
'content',
27+
'hasInnerHtml',
28+
];
29+
30+
protected getComponentName(): string {
31+
return 'ComcolPageContentComponent';
32+
}
33+
34+
protected importThemedComponent(themeName: string): Promise<any> {
35+
return import(`../../../../themes/${themeName}/app/admin/admin-sidebar/admin-sidebar.component`);
36+
}
37+
38+
protected importUnthemedComponent(): Promise<any> {
39+
return import('./comcol-page-content.component');
40+
}
41+
42+
}

src/app/shared/comcol/comcol.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { EditComColPageComponent } from './comcol-forms/edit-comcol-page/edit-co
1414
import { ComcolPageBrowseByComponent } from './comcol-page-browse-by/comcol-page-browse-by.component';
1515
import { ThemedComcolPageBrowseByComponent } from './comcol-page-browse-by/themed-comcol-page-browse-by.component';
1616
import { ComcolPageContentComponent } from './comcol-page-content/comcol-page-content.component';
17+
import { ThemedComcolPageContentComponent } from './comcol-page-content/themed-comcol-page-content.component';
1718
import { ComcolPageHandleComponent } from './comcol-page-handle/comcol-page-handle.component';
1819
import { ThemedComcolPageHandleComponent } from './comcol-page-handle/themed-comcol-page-handle.component';
1920
import { ComcolPageHeaderComponent } from './comcol-page-header/comcol-page-header.component';
@@ -23,6 +24,7 @@ import { ComcolSearchSectionComponent } from './sections/comcol-search-section/c
2324

2425
const COMPONENTS = [
2526
ComcolPageContentComponent,
27+
ThemedComcolPageContentComponent,
2628
ComcolPageHandleComponent,
2729
ComcolPageHeaderComponent,
2830
ComcolPageLogoComponent,

0 commit comments

Comments
 (0)