Skip to content

Commit c088ccb

Browse files
authored
Merge pull request DSpace#3119 from tdonohue/port_3067_to_7x
[Port dspace-7_x] Fix "Browse by Author" remaining serious accessibility issues
2 parents 09bf25a + ebb846f commit c088ccb

5 files changed

Lines changed: 16 additions & 3 deletions

File tree

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
<form class="w-100" [formGroup]="formData" (ngSubmit)="submitForm(formData.value)">
2+
<div class="mb-3">
23
<div class="row">
3-
<div class="form-group input-group col-8 col-sm-12 col-md-6">
4-
<input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.startsWith.type_text' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" />
4+
<div class="form-group input-group col-sm-12 col-md-6 col-auto">
5+
<input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.search-form.placeholder' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" />
56
<span class="input-group-append">
67
<button class="btn btn-primary" type="submit"><i class="fas fa-book-open"></i> {{'browse.startsWith.submit' | translate}}</button>
78
</span>
89
</div>
910
</div>
11+
<small class="text-muted">{{'browse.startsWith.type_text' | translate}}</small>
12+
</div>
1013
</form>

src/app/shared/starts-with/text/starts-with-text.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,7 @@
33
background-color: var(--bs-input-bg);
44
color: var(--bs-input-color);
55
}
6+
7+
.form-group {
8+
margin-bottom: 0;
9+
}

src/assets/i18n/en.json5

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5366,4 +5366,5 @@
53665366

53675367
"process.overview.unknown.user": "Unknown",
53685368

5369+
"browse.search-form.placeholder": "Search the repository",
53695370
}

src/assets/i18n/es.json5

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7828,6 +7828,8 @@
78287828
// "access-control-option-end-date-note": "Select the date until which the related access condition is applied",
78297829
"access-control-option-end-date-note": "Escoja la fecha hasta la cuál se aplicarán las condiciones de acceso especificadas",
78307830

7831+
//"browse.search-form.placeholder": "Search the repository",
7832+
"browse.search-form.placeholder": "Buscar en el repositorio",
78317833

78327834

78337835
}

src/assets/i18n/pt-BR.json5

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1290,7 +1290,7 @@
12901290
"browse.startsWith.type_date.label": "Ou digite na data (year-month) e clique no botão de Ir",
12911291

12921292
// "browse.startsWith.type_text": "Filter results by typing the first few letters",
1293-
"browse.startsWith.type_text": "Filtrar resultados informando as primeiras letras:",
1293+
"browse.startsWith.type_text": "Filtrar resultados informando as primeiras letras",
12941294

12951295
// "browse.startsWith.input": "Filter", (Auto-Translated)
12961296
"browse.startsWith.input": "Filtro",
@@ -7854,4 +7854,7 @@
78547854

78557855
// "access-control-option-end-date-note": "Select the date until which the related access condition is applied", (Auto-Translated)
78567856
"access-control-option-end-date-note": "Selecione a data até a qual a condição de acesso relacionada é aplicada",
7857+
7858+
//"browse.search-form.placeholder": "Search the repository",
7859+
"browse.search-form.placeholder": "Buscar no repositório",
78577860
}

0 commit comments

Comments
 (0)