Skip to content

Commit bf5e9b9

Browse files
authored
Merge pull request DSpace#3067 from Neki-IT/BrowseByAuthorSeriousIssues
Fix "Browse by Author" remaining serious accessibility issues
2 parents 4e93255 + ff68eac commit bf5e9b9

5 files changed

Lines changed: 17 additions & 3 deletions

File tree

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
<form class="w-100" [formGroup]="formData" (ngSubmit)="submitForm(formData.value)">
2+
<div class="mb-3">
23
<div class="row">
3-
<div class="form-group input-group col-8 col-sm-12 col-md-6">
4-
<input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.startsWith.type_text' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" />
4+
<div class="form-group input-group col-sm-12 col-md-6 col-auto">
5+
<input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.search-form.placeholder' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" />
56
<span class="input-group-append">
67
<button class="btn btn-primary" type="submit"><i class="fas fa-book-open"></i> {{'browse.startsWith.submit' | translate}}</button>
78
</span>
89
</div>
910
</div>
11+
<small class="text-muted">{{'browse.startsWith.type_text' | translate}}</small>
12+
</div>
1013
</form>

src/app/shared/starts-with/text/starts-with-text.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,7 @@
33
background-color: var(--bs-input-bg);
44
color: var(--bs-input-color);
55
}
6+
7+
.form-group {
8+
margin-bottom: 0;
9+
}

src/assets/i18n/en.json5

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6737,4 +6737,6 @@
67376737
"item.page.cc.license.title": "Creative Commons license",
67386738

67396739
"item.page.cc.license.disclaimer": "Except where otherwised noted, this item's license is described as",
6740+
6741+
"browse.search-form.placeholder": "Search the repository",
67406742
}

src/assets/i18n/es.json5

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8254,6 +8254,8 @@
82548254
// "access-control-option-end-date-note": "Select the date until which the related access condition is applied",
82558255
"access-control-option-end-date-note": "Escoja la fecha hasta la cuál se aplicarán las condiciones de acceso especificadas",
82568256

8257+
//"browse.search-form.placeholder": "Search the repository",
8258+
"browse.search-form.placeholder": "Buscar en el repositorio",
82578259

82588260

82598261
}

src/assets/i18n/pt-BR.json5

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1693,7 +1693,7 @@
16931693
"browse.startsWith.type_date.label": "Ou digite na data (year-month) e clique no botão de Ir",
16941694

16951695
// "browse.startsWith.type_text": "Filter results by typing the first few letters",
1696-
"browse.startsWith.type_text": "Filtrar resultados informando as primeiras letras:",
1696+
"browse.startsWith.type_text": "Filtrar resultados informando as primeiras letras",
16971697

16981698
// "browse.startsWith.input": "Filter", (Auto-Translated)
16991699
"browse.startsWith.input": "Filtro",
@@ -8274,4 +8274,7 @@
82748274

82758275
// "access-control-option-end-date-note": "Select the date until which the related access condition is applied", (Auto-Translated)
82768276
"access-control-option-end-date-note": "Selecione a data até a qual a condição de acesso relacionada é aplicada",
8277+
8278+
//"browse.search-form.placeholder": "Search the repository",
8279+
"browse.search-form.placeholder": "Buscar no repositório",
82778280
}

0 commit comments

Comments
 (0)