Skip to content

Commit badf002

Browse files
author
Kuno Vercammen
committed
113124: Allow opening ds-metadata-uri-values links in a new window
1 parent 4c693a1 commit badf002

3 files changed

Lines changed: 14 additions & 1 deletion

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<ds-metadata-field-wrapper [label]="label | translate">
2-
<a class="dont-break-out" *ngFor="let mdValue of mdValues; let last=last;" [href]="mdValue.value">
2+
<a class="dont-break-out" *ngFor="let mdValue of mdValues; let last=last;" [href]="mdValue.value" [target]="linkTarget">
33
{{ linktext || mdValue.value }}<span *ngIf="!last" [innerHTML]="separator"></span>
44
</a>
55
</ds-metadata-field-wrapper>

src/app/item-page/field-components/metadata-uri-values/metadata-uri-values.component.spec.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,13 @@ describe('MetadataUriValuesComponent', () => {
7373
expect(separators.length).toBe(mockMetadata.length - 1);
7474
});
7575

76+
it('should contain the correct target attribute for metadata links', () => {
77+
const links = fixture.debugElement.queryAll(By.css('a'));
78+
for (const link of links) {
79+
expect(link.nativeElement.getAttribute('target')).toBe('_blank');
80+
}
81+
});
82+
7683
describe('when linktext is defined', () => {
7784

7885
beforeEach(() => {

src/app/item-page/field-components/metadata-uri-values/metadata-uri-values.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,10 @@ export class MetadataUriValuesComponent extends MetadataValuesComponent {
3737
* The label for this iteration of metadata values
3838
*/
3939
@Input() label: string;
40+
41+
/**
42+
* The target attribute for the metadata links.
43+
* Defaults to '_blank' to open links in a new window/tab.
44+
*/
45+
@Input() linkTarget = '_blank';
4046
}

0 commit comments

Comments
 (0)