Skip to content

Commit ba2f173

Browse files
committed
Address review: add missing templates, commented references to them, reference original templates by default.
1 parent 1f1b04e commit ba2f173

15 files changed

Lines changed: 57 additions & 12 deletions

src/themes/custom/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.html renamed to src/themes/custom/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.html

File renamed without changes.

src/themes/custom/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.scss

Whitespace-only changes.
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
import { Component } from '@angular/core';
22
import {
33
CreateCollectionParentSelectorComponent as BaseComponent
4-
} from 'src/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component';
4+
} from '../../../../../../../app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component';
55

66
@Component({
77
selector: 'ds-create-collection-parent-selector',
8-
templateUrl: '../dso-selector-modal-wrapper.component.html',
8+
// styleUrls: ['./create-collection-parent-selector.component.scss'],
9+
// templateUrl: './create-collection-parent-selector.component.html',
10+
templateUrl: '../../../../../../../app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.html',
911
})
1012
export class CreateCollectionParentSelectorComponent extends BaseComponent {
1113
}
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
import { Component } from '@angular/core';
22
import {
33
CreateCommunityParentSelectorComponent as BaseComponent
4-
} from 'src/app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component';
4+
} from '../../../../../../../app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component';
55

66
@Component({
77
selector: 'ds-create-community-parent-selector',
8-
styleUrls: ['./create-community-parent-selector.component.scss'],
9-
templateUrl: './create-community-parent-selector.component.html',
8+
// styleUrls: ['./create-community-parent-selector.component.scss'],
9+
styleUrls: ['../../../../../../../app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.scss'],
10+
// templateUrl: './create-community-parent-selector.component.html',
11+
templateUrl: '../../../../../../../app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.html',
1012
})
1113
export class CreateCommunityParentSelectorComponent extends BaseComponent {
1214
}

src/themes/custom/app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.scss

Whitespace-only changes.
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
import {Component} from '@angular/core';
22
import {
33
CreateItemParentSelectorComponent as BaseComponent
4-
} from 'src/app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component';
4+
} from '../../../../../../../app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component';
55

66
@Component({
77
selector: 'ds-create-item-parent-selector',
8-
templateUrl: './create-item-parent-selector.component.html',
8+
// styleUrls: ['./create-item-parent-selector.component.scss'],
9+
// templateUrl: './create-item-parent-selector.component.html',
10+
templateUrl: '../../../../../../../app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.html',
911
})
1012
export class CreateItemParentSelectorComponent extends BaseComponent {
1113
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<div>
2+
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
3+
<button type="button" class="close" (click)="close()" aria-label="Close">
4+
<span aria-hidden="true">×</span>
5+
</button>
6+
</div>
7+
<div class="modal-body">
8+
<h5 *ngIf="header" class="px-2">{{header | translate}}</h5>
9+
<ds-dso-selector [currentDSOId]="dsoRD?.payload.uuid" [types]="selectorTypes" (onSelect)="selectObject($event)"></ds-dso-selector>
10+
</div>
11+
</div>

src/themes/custom/app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.scss

Whitespace-only changes.
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
import { Component } from '@angular/core';
22
import {
33
EditCollectionSelectorComponent as BaseComponent
4-
} from 'src/app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component';
4+
} from '../../../../../../../app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component';
55

66
@Component({
77
selector: 'ds-edit-collection-selector',
8-
templateUrl: '../dso-selector-modal-wrapper.component.html',
8+
// styleUrls: ['./edit-collection-selector.component.scss'],
9+
// templateUrl: './edit-collection-selector.component.html',
10+
templateUrl: '../../../../../../../app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.html',
911
})
1012
export class EditCollectionSelectorComponent extends BaseComponent {
1113
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<div>
2+
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
3+
<button type="button" class="close" (click)="close()" aria-label="Close">
4+
<span aria-hidden="true">×</span>
5+
</button>
6+
</div>
7+
<div class="modal-body">
8+
<h5 *ngIf="header" class="px-2">{{header | translate}}</h5>
9+
<ds-dso-selector [currentDSOId]="dsoRD?.payload.uuid" [types]="selectorTypes" (onSelect)="selectObject($event)"></ds-dso-selector>
10+
</div>
11+
</div>

0 commit comments

Comments
 (0)