[UXP-114] add and fix tests

Author: Andrea Barbasso

src/app/core/shared/math.directive.spec.ts

@@ -1,16 +1,47 @@
 import { TestBed } from '@angular/core/testing';
+import { Observable, of } from 'rxjs';
+import { MathService, MathJaxConfig } from './math.service';
 
-import { MathService } from './math.service';
+export class MockMathService extends MathService {
+  protected mathJaxOptions: any = {};
+  protected mathJax: MathJaxConfig = { source: '', id: '' };
+  protected mathJaxFallback: MathJaxConfig = { source: '', id: '' };
+
+  protected registerMathJaxAsync(config: MathJaxConfig): Promise<any> {
+    return Promise.resolve();
+  }
+
+  ready(): Observable<boolean> {
+    return of(true);
+  }
+
+  render(element: HTMLElement): void {
+    return;
+  }
+}
 
 describe('MathService', () => {
-  let service: MathService;
+  let service: MockMathService;
 
   beforeEach(() => {
     TestBed.configureTestingModule({});
-    service = TestBed.inject(MathService);
+    service = new MockMathService();
+    spyOn(service, 'render');
   });
 
   it('should be created', () => {
     expect(service).toBeTruthy();
   });
+
+  it('should be ready', (done) => {
+    service.ready().subscribe(isReady => {
+      expect(isReady).toBe(true);
+      done();
+    });
+  });
+
+  it('should render', () => {
+    service.render(document.createElement('div'));
+    expect(service.render).toHaveBeenCalled();
+  });
 });

src/app/core/shared/math.service.spec.ts

@@ -22,7 +22,7 @@
             <ng-container *ngFor="let mdEntry of (metadata$ | async) | keyvalue">
               <tr *ngFor="let mdValue of mdEntry.value">
                 <td>{{mdEntry.key}}</td>
-                <td><ds-markdown-viewer [value]="mdValue.value"></ds-markdown-viewer></td>
+                <td>{{mdValue.value}}</td>
                 <td>{{mdValue.language}}</td>
               </tr>
             </ng-container>

src/app/item-page/full/full-item-page.component.html

@@ -9,13 +9,14 @@ import { MetadataMap, MetadataValue } from '../../../../core/shared/metadata.mod
 import { createSuccessfulRemoteDataObject$ } from '../../../../shared/remote-data.utils';
 import { createPaginatedList } from '../../../../shared/testing/utils.test';
 import { environment } from '../../../../../environments/environment';
-import { MarkdownPipe } from '../../../../shared/utils/markdown.pipe';
 import { SharedModule } from '../../../../shared/shared.module';
 import { APP_CONFIG } from '../../../../../config/app-config.interface';
 import { By } from '@angular/platform-browser';
 import { BrowseDefinitionDataService } from '../../../../core/browse/browse-definition-data.service';
 import { BrowseDefinitionDataServiceStub } from '../../../../shared/testing/browse-definition-data-service.stub';
 import { RouterTestingModule } from '@angular/router/testing';
+import { MarkdownDirective } from '../../../../shared/utils/markdown.directive';
+import { MathService } from '../../../../core/shared/math.service';
 
 let comp: ItemPageFieldComponent;
 let fixture: ComponentFixture<ItemPageFieldComponent>;
@@ -51,14 +52,15 @@ describe('ItemPageFieldComponent', () => {
       ],
       providers: [
         { provide: APP_CONFIG, useValue: appConfig },
-        { provide: BrowseDefinitionDataService, useValue: BrowseDefinitionDataServiceStub }
+        { provide: BrowseDefinitionDataService, useValue: BrowseDefinitionDataServiceStub },
+        { provide: MathService, useValue: {} }
       ],
       declarations: [ItemPageFieldComponent, MetadataValuesComponent],
       schemas: [NO_ERRORS_SCHEMA]
     }).overrideComponent(ItemPageFieldComponent, {
       set: { changeDetection: ChangeDetectionStrategy.Default }
     }).compileComponents();
-    markdownSpy = spyOn(MarkdownPipe.prototype, 'transform');
+    markdownSpy = spyOn(MarkdownDirective.prototype, 'render');
     fixture = TestBed.createComponent(ItemPageFieldComponent);
     comp = fixture.componentInstance;
     comp.item = mockItemWithMetadataFieldsAndValue(mockFields, mockValue);

src/app/item-page/simple/field-components/specific-field/item-page-field.component.spec.ts

@@ -1,16 +1,21 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { MarkdownViewerComponent } from './markdown-viewer.component';
-import { MarkdownPipe } from '../utils/markdown.pipe';
 import { By } from '@angular/platform-browser';
+import { MarkdownDirective } from '../utils/markdown.directive';
+import { MathService } from '../../core/shared/math.service';
 
 describe('DsMarkdownViewerComponent', () => {
   let component: MarkdownViewerComponent;
   let fixture: ComponentFixture<MarkdownViewerComponent>;
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      declarations: [ MarkdownViewerComponent, MarkdownPipe ]
+      declarations: [ MarkdownViewerComponent, MarkdownDirective ],
+      providers: [{
+        provide: MathService,
+        useValue: {}
+      } ]
     })
     .compileComponents();
   });

src/app/shared/markdown-viewer/markdown-viewer.component.spec.ts

@@ -1,8 +1,35 @@
+import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { MarkdownDirective } from './markdown.directive';
+import { Component, DebugElement } from '@angular/core';
+import { By } from '@angular/platform-browser';
+import { MathService } from '../../core/shared/math.service';
+import { MockMathService } from '../../core/shared/math.service.spec';
+
+@Component({
+  template: `<div dsMarkdown="test"></div>`
+})
+class TestComponent {}
 
 describe('MarkdownDirective', () => {
-  it('should create an instance', () => {
-    const directive = new MarkdownDirective();
-    expect(directive).toBeTruthy();
+  let component: TestComponent;
+  let fixture: ComponentFixture<TestComponent>;
+  let divEl: DebugElement;
+
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      declarations: [ TestComponent, MarkdownDirective ],
+      providers: [
+        { provide: MathService, useClass: MockMathService },
+      ]
+    }).compileComponents();
+    spyOn(MarkdownDirective.prototype, 'render');
+    fixture = TestBed.createComponent(TestComponent);
+    component = fixture.componentInstance;
+    divEl = fixture.debugElement.query(By.css('div'));
+  });
+
+  it('should call render method', () => {
+    fixture.detectChanges();
+    expect(MarkdownDirective.prototype.render).toHaveBeenCalled();
   });
 });