Skip to content

Commit b73b5a6

Browse files
FrancescoMolinarovins01-4science
authored andcommitted
Merged in task/ux-plus-cris-2024_02_x/UXP-305 (pull request #88)
[UXP-305] fix grid link fallback, prevent p wrapping in quill Approved-by: Andrea Barbasso
2 parents c57a64a + b0254a2 commit b73b5a6

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

src/app/shared/explore/section-component/grid-section/grid-section.component.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ import {
5353
} from '../../../../core/shared/operators';
5454
import { SearchService } from '../../../../core/shared/search/search.service';
5555
import { Site } from '../../../../core/shared/site.model';
56-
import { hasValue } from '../../../../shared/empty.util';
56+
import {
57+
hasValue,
58+
isEmpty,
59+
} from '../../../../shared/empty.util';
5760
import { SearchResult } from '../../../../shared/search/models/search-result.model';
5861
import { followLink } from '../../../../shared/utils/follow-link-config.model';
5962
import { PaginationComponentOptions } from '../../../pagination/pagination-component-options.model';
@@ -159,7 +162,10 @@ export class GridSectionComponent implements OnInit {
159162
this.maincontentTitle = this.maincontentTitle ?? this.translateService.instant('grid.component.title');
160163
this.maincontentSubtitle = this.maincontentSubtitle ?? this.translateService.instant('grid.component.subtitle');
161164
this.maincontentAbstract = this.maincontentAbstract ?? this.translateService.instant('grid.component.abstract');
162-
this.maincontentLink = this.maincontentLink ?? this.translateService.instant('grid.component.link');
165+
166+
if (isEmpty(this.maincontentLink)) {
167+
this.maincontentLink = this.gridSection.mainContentLink ?? this.translateService.instant('grid.component.link');
168+
}
163169
}
164170

165171
private getSearchResults() {

src/app/shared/markdown-editor/markdown-editor.component.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,11 @@ export class MarkdownEditorComponent {
7979
*/
8080
updateContent(content: ContentChange) {
8181
const sanitizedContent = this.sanitizer.sanitize(SecurityContext.HTML, content.html);
82-
const normalizedContent = sanitizedContent?.replace(/ /g, ' ');
82+
let normalizedContent = sanitizedContent?.replace(/ /g, ' ');
83+
// Remove outer <p>...</p> if present as quill wraps around p by default
84+
if (normalizedContent) {
85+
normalizedContent = normalizedContent.replace(/^<p>([\s\S]*)<\/p>$/i, '$1');
86+
}
8387
this.editValueChange.emit(normalizedContent);
8488
}
8589
}

0 commit comments

Comments
 (0)