Skip to content

Commit b5ef4aa

Browse files
fix(CI-build): Use double quotes for YAML strings and add npm ci to e2e
step ref: DSC-2748
1 parent f828134 commit b5ef4aa

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/build.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ name: Build
77
on: [push, pull_request]
88

99
permissions:
10-
contents: read # to fetch code (actions/checkout)
11-
packages: read # to fetch private images from GitHub Container Registry (GHCR)
10+
contents: read # to fetch code (actions/checkout)
11+
packages: read # to fetch private images from GitHub Container Registry (GHCR)
1212

1313
jobs:
1414
tests:
@@ -19,7 +19,7 @@ jobs:
1919
# NOTE: These settings should be kept in sync with those in [src]/docker/docker-compose-ci.yml
2020
DSPACE_REST_HOST: 127.0.0.1
2121
DSPACE_REST_PORT: 8080
22-
DSPACE_REST_NAMESPACE: '/server'
22+
DSPACE_REST_NAMESPACE: "/server"
2323
DSPACE_REST_SSL: false
2424
# Spin up UI on 127.0.0.1 to avoid host resolution issues in e2e tests with Node 20+
2525
DSPACE_UI_HOST: 127.0.0.1
@@ -35,9 +35,9 @@ jobs:
3535
# Comment this out to use the latest release
3636
#CHROME_VERSION: "116.0.5845.187-1"
3737
# Bump Node heap size (OOM in CI after upgrading to Angular 15)
38-
NODE_OPTIONS: '--max-old-space-size=4096'
38+
NODE_OPTIONS: "--max-old-space-size=4096"
3939
# Project name to use when running "docker compose" prior to e2e tests
40-
COMPOSE_PROJECT_NAME: 'ci'
40+
COMPOSE_PROJECT_NAME: "ci"
4141
# Docker Registry to use for Docker compose scripts below.
4242
# We use GitHub's Container Registry to avoid aggressive rate limits at DockerHub.
4343
DOCKER_REGISTRY: ghcr.io
@@ -117,7 +117,7 @@ jobs:
117117
if: matrix.node-version == '20.x'
118118
with:
119119
name: coverage-report-${{ matrix.node-version }}
120-
path: 'coverage/dspace-angular/lcov.info'
120+
path: "coverage/dspace-angular/lcov.info"
121121
retention-days: 14
122122

123123
# Login to our Docker registry, so that we can access private Docker images using "docker compose" below.
@@ -142,6 +142,7 @@ jobs:
142142
- name: Run e2e tests (integration tests)
143143
uses: cypress-io/github-action@v6
144144
with:
145+
install-command: npm ci
145146
# Run tests in Chrome, headless mode (default)
146147
browser: chrome
147148
# Start app before running tests (will be stopped automatically after tests finish)
@@ -262,7 +263,6 @@ jobs:
262263
echo "$result"
263264
echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep "test funding"
264265
265-
266266
# Verify 301 Handle redirect behavior
267267
# Note: /handle/123456789/260 is the same test Publication used by our e2e tests
268268
- name: Verify 301 redirect from '/handle' URLs

0 commit comments

Comments
 (0)