Revert "[DURACOM-145] Fixed e2e failing tests"

This reverts commit b9c7391b1452e9a79d9c5615595b08cd7ac8b14c.

Author: alisaismailati

cypress/e2e/my-dspace.cy.ts

@@ -88,17 +88,8 @@ describe('My DSpace page', () => {
         // The Submission edit form tag should be visible
         cy.get('ds-submission-edit').should('be.visible');
 
-        // A Collection menu button should exist(based on collection visibility) & its value should be the selected collection
-        cy.get('#collectionControlsMenuButton span')
-        .should(($span) => {
-          if ($span.length > 0) {
-            // If the element exists in the DOM (it's visible or read-only)
-            expect($span).to.have.text(TEST_SUBMIT_COLLECTION_NAME);
-          } else {
-            // If the element doesn't exist in the DOM, the length will be 0
-            expect($span).to.have.length(0);
-          }
-        });
+        // A Collection menu button should exist & its value should be the selected collection
+        cy.get('#collectionControlsMenuButton span').should('have.text', TEST_SUBMIT_COLLECTION_NAME);
 
         // Now that we've created a submission, we'll test that we can go back and Edit it.
         // Get our Submission URL, to parse out the ID of this new submission

cypress/e2e/submission.cy.ts

@@ -16,17 +16,8 @@ describe('New Submission page', () => {
         // The Submission edit form tag should be visible
         cy.get('ds-submission-edit').should('be.visible');
 
-        // A Collection menu button should exist(if it's visible or read-only) & it's value should be the selected collection
-        cy.get('#collectionControlsMenuButton span')
-        .should(($span) => {
-          if ($span.length > 0) {
-            // If the element exists in the DOM (it's visible or read-only)
-            expect($span).to.have.text(TEST_SUBMIT_COLLECTION_NAME);
-          } else {
-            // If the element doesn't exist in the DOM, the length will be 0
-            expect($span).to.have.length(0);
-          }
-        });
+        // A Collection menu button should exist & it's value should be the selected collection
+        cy.get('#collectionControlsMenuButton span').should('have.text', TEST_SUBMIT_COLLECTION_NAME);
 
         // 4 sections should be visible by default
         cy.get('div#section_traditionalpageone').should('be.visible');