[DSC-2028] adapt findById in metadata link view, fix tests

Author: FrancescoMolinaro

src/app/cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/crisref/crisref.component.spec.ts

@@ -20,7 +20,7 @@ describe('CrisrefComponent', () => {
   let fixture: ComponentFixture<CrisrefComponent>;
 
   const itemService = jasmine.createSpyObj('ItemDataService', {
-    findById: jasmine.createSpy('findById')
+    findByIdWithProjections: jasmine.createSpy('findByIdWithProjections')
   });
   const metadataValue = Object.assign(new MetadataValue(), {
     'value': 'test item title',
@@ -106,7 +106,7 @@ describe('CrisrefComponent', () => {
   beforeEach(() => {
     fixture = TestBed.createComponent(CrisrefComponent);
     component = fixture.componentInstance;
-    itemService.findById.and.returnValue(createSuccessfulRemoteDataObject$(testPerson));
+    itemService.findByIdWithProjections.and.returnValue(createSuccessfulRemoteDataObject$(testPerson));
     fixture.detectChanges();
   });
 

src/app/shared/metadata-link-view/metadata-link-view.component.spec.ts

@@ -90,7 +90,7 @@ describe('MetadataLinkViewComponent', () => {
   });
 
   itemService = jasmine.createSpyObj('ItemDataService', {
-    findById: jasmine.createSpy('findById')
+    findByIdWithProjections: jasmine.createSpy('findByIdWithProjections')
   });
 
   beforeEach(waitForAsync(() => {
@@ -110,7 +110,7 @@ describe('MetadataLinkViewComponent', () => {
   describe('Check metadata without authority', () => {
     beforeEach(() => {
       fixture = TestBed.createComponent(MetadataLinkViewComponent);
-      itemService.findById.and.returnValue(createSuccessfulRemoteDataObject$(testOrgunit));
+      itemService.findByIdWithProjections.and.returnValue(createSuccessfulRemoteDataObject$(testOrgunit));
       component = fixture.componentInstance;
       component.item = testPerson;
       component.metadata = testMetadataValueWithoutAuthority;
@@ -135,7 +135,7 @@ describe('MetadataLinkViewComponent', () => {
     describe('when item is found with orcid', () => {
       beforeEach(() => {
         fixture = TestBed.createComponent(MetadataLinkViewComponent);
-        itemService.findById.and.returnValue(createSuccessfulRemoteDataObject$(testPerson));
+        itemService.findByIdWithProjections.and.returnValue(createSuccessfulRemoteDataObject$(testPerson));
         component = fixture.componentInstance;
         component.item = testPerson;
         component.metadata = testMetadataValueWithAuthority;
@@ -162,7 +162,7 @@ describe('MetadataLinkViewComponent', () => {
     describe('when item is found without orcid', () => {
       beforeEach(() => {
         fixture = TestBed.createComponent(MetadataLinkViewComponent);
-        itemService.findById.and.returnValue(createSuccessfulRemoteDataObject$(testOrgunit));
+        itemService.findByIdWithProjections.and.returnValue(createSuccessfulRemoteDataObject$(testOrgunit));
         component = fixture.componentInstance;
         component.item = testPerson;
         component.metadata = testMetadataValueWithAuthority;
@@ -189,7 +189,7 @@ describe('MetadataLinkViewComponent', () => {
     describe('when item is not found', () => {
       beforeEach(() => {
         fixture = TestBed.createComponent(MetadataLinkViewComponent);
-        itemService.findById.and.returnValue(createFailedRemoteDataObject$());
+        itemService.findByIdWithProjections.and.returnValue(createFailedRemoteDataObject$());
         component = fixture.componentInstance;
         component.item = testPerson;
         component.metadata = testMetadataValueWithAuthority;

src/app/shared/metadata-link-view/metadata-link-view.component.ts

@@ -85,7 +85,7 @@ export class MetadataLinkViewComponent implements OnInit {
     const linksToFollow = [followLink('thumbnail')];
 
     if (Metadata.hasValidAuthority(metadataValue.authority)) {
-      return this.itemService.findById(metadataValue.authority, true, false, ...linksToFollow).pipe(
+      return this.itemService.findByIdWithProjections(metadataValue.authority, ['preventMetadataSecurity'], true, false, ...linksToFollow).pipe(
         getFirstCompletedRemoteData(),
         map((itemRD: RemoteData<Item>) => this.createMetadataView(itemRD, metadataValue))
       );