Skip to content

Commit a48d199

Browse files
committed
Autofix: remove unneeded base component imports
This is part of the themed-component-usages rule; Themed* components already import the base component, we don't need to import both anymore. You'll see that all of these changes are also reflected in the base component. Double-checked and this doesn't compromise the fixes from DSpace#2984
1 parent c9d9e12 commit a48d199

7 files changed

Lines changed: 5 additions & 14 deletions

File tree

src/themes/custom/app/browse-by/browse-by-taxonomy/browse-by-taxonomy.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { RouterLink } from '@angular/router';
77
import { TranslateModule } from '@ngx-translate/core';
88

99
import { BrowseByTaxonomyComponent as BaseComponent } from '../../../../../app/browse-by/browse-by-taxonomy/browse-by-taxonomy.component';
10-
import { BrowseByComponent } from '../../../../../app/shared/browse-by/browse-by.component';
1110
import { ThemedBrowseByComponent } from '../../../../../app/shared/browse-by/themed-browse-by.component';
1211
import { ThemedComcolPageBrowseByComponent } from '../../../../../app/shared/comcol/comcol-page-browse-by/themed-comcol-page-browse-by.component';
1312
import { ComcolPageContentComponent } from '../../../../../app/shared/comcol/comcol-page-content/comcol-page-content.component';
@@ -36,7 +35,6 @@ import { VarDirective } from '../../../../../app/shared/utils/var.directive';
3635
ComcolPageContentComponent,
3736
DsoEditMenuComponent,
3837
ThemedComcolPageBrowseByComponent,
39-
BrowseByComponent,
4038
TranslateModule,
4139
ThemedLoadingComponent,
4240
ThemedBrowseByComponent,

src/themes/custom/app/collection-page/edit-item-template-page/edit-item-template-page.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { ThemedDsoEditMetadataComponent } from '../../../../../app/dso-shared/ds
1111
import { AlertComponent } from '../../../../../app/shared/alert/alert.component';
1212
import { ThemedLoadingComponent } from '../../../../../app/shared/loading/themed-loading.component';
1313
import { VarDirective } from '../../../../../app/shared/utils/var.directive';
14-
import { DsoEditMetadataComponent } from '../../dso-shared/dso-edit-metadata/dso-edit-metadata.component';
1514

1615
@Component({
1716
selector: 'ds-themed-edit-item-template-page',
@@ -21,7 +20,6 @@ import { DsoEditMetadataComponent } from '../../dso-shared/dso-edit-metadata/dso
2120
standalone: true,
2221
imports: [
2322
ThemedDsoEditMetadataComponent,
24-
DsoEditMetadataComponent,
2523
RouterLink,
2624
AsyncPipe,
2725
VarDirective,

src/themes/custom/app/forgot-password/forgot-password-email/forgot-email.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { Component } from '@angular/core';
22
import { ThemedRegisterEmailFormComponent } from 'src/app/register-email-form/themed-registry-email-form.component';
33

44
import { ForgotEmailComponent as BaseComponent } from '../../../../../app/forgot-password/forgot-password-email/forgot-email.component';
5-
import { RegisterEmailFormComponent } from '../../../../../app/register-email-form/register-email-form.component';
65

76
@Component({
87
selector: 'ds-themed-forgot-email',
@@ -12,7 +11,7 @@ import { RegisterEmailFormComponent } from '../../../../../app/register-email-fo
1211
templateUrl: '../../../../../app/forgot-password/forgot-password-email/forgot-email.component.html',
1312
standalone: true,
1413
imports: [
15-
RegisterEmailFormComponent, ThemedRegisterEmailFormComponent,
14+
ThemedRegisterEmailFormComponent,
1615
],
1716
})
1817
/**

src/themes/custom/app/header/header.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { HeaderComponent as BaseComponent } from '../../../../app/header/header.
1313
import { ThemedSearchNavbarComponent } from '../../../../app/search-navbar/themed-search-navbar.component';
1414
import { ThemedAuthNavMenuComponent } from '../../../../app/shared/auth-nav-menu/themed-auth-nav-menu.component';
1515
import { ImpersonateNavbarComponent } from '../../../../app/shared/impersonate-navbar/impersonate-navbar.component';
16-
import { LangSwitchComponent } from '../../../../app/shared/lang-switch/lang-switch.component';
1716

1817
/**
1918
* Represents the header with the logo and simple navigation
@@ -25,7 +24,7 @@ import { LangSwitchComponent } from '../../../../app/shared/lang-switch/lang-swi
2524
// templateUrl: 'header.component.html',
2625
templateUrl: '../../../../app/header/header.component.html',
2726
standalone: true,
28-
imports: [RouterLink, ThemedLangSwitchComponent, NgbDropdownModule, ThemedSearchNavbarComponent, LangSwitchComponent, ContextHelpToggleComponent, ThemedAuthNavMenuComponent, ImpersonateNavbarComponent, TranslateModule, AsyncPipe, NgIf],
27+
imports: [RouterLink, ThemedLangSwitchComponent, NgbDropdownModule, ThemedSearchNavbarComponent, ContextHelpToggleComponent, ThemedAuthNavMenuComponent, ImpersonateNavbarComponent, TranslateModule, AsyncPipe, NgIf],
2928
})
3029
export class HeaderComponent extends BaseComponent {
3130
}

src/themes/custom/app/home-page/home-page.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { HomePageComponent as BaseComponent } from '../../../../app/home-page/ho
1313
import { RecentItemListComponent } from '../../../../app/home-page/recent-item-list/recent-item-list.component';
1414
import { ThemedTopLevelCommunityListComponent } from '../../../../app/home-page/top-level-community-list/themed-top-level-community-list.component';
1515
import { SuggestionsPopupComponent } from '../../../../app/notifications/suggestions-popup/suggestions-popup.component';
16-
import { ConfigurationSearchPageComponent } from '../../../../app/search-page/configuration-search-page.component';
1716
import { ThemedConfigurationSearchPageComponent } from '../../../../app/search-page/themed-configuration-search-page.component';
1817
import { ThemedSearchFormComponent } from '../../../../app/shared/search-form/themed-search-form.component';
1918
import { PageWithSidebarComponent } from '../../../../app/shared/sidebar/page-with-sidebar.component';
@@ -26,7 +25,7 @@ import { ViewTrackerComponent } from '../../../../app/statistics/angulartics/dsp
2625
// templateUrl: './home-page.component.html'
2726
templateUrl: '../../../../app/home-page/home-page.component.html',
2827
standalone: true,
29-
imports: [ThemedHomeNewsComponent, NgTemplateOutlet, NgIf, ViewTrackerComponent, ThemedSearchFormComponent, ThemedTopLevelCommunityListComponent, RecentItemListComponent, AsyncPipe, TranslateModule, NgClass, ConfigurationSearchPageComponent, SuggestionsPopupComponent, ThemedConfigurationSearchPageComponent, PageWithSidebarComponent, HomeCoarComponent],
28+
imports: [ThemedHomeNewsComponent, NgTemplateOutlet, NgIf, ViewTrackerComponent, ThemedSearchFormComponent, ThemedTopLevelCommunityListComponent, RecentItemListComponent, AsyncPipe, TranslateModule, NgClass, SuggestionsPopupComponent, ThemedConfigurationSearchPageComponent, PageWithSidebarComponent, HomeCoarComponent],
3029
})
3130
export class HomePageComponent extends BaseComponent {
3231

src/themes/custom/app/login-page/login-page.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { TranslateModule } from '@ngx-translate/core';
33
import { ThemedLogInComponent } from 'src/app/shared/log-in/themed-log-in.component';
44

55
import { LoginPageComponent as BaseComponent } from '../../../../app/login-page/login-page.component';
6-
import { LogInComponent } from '../../../../app/shared/log-in/log-in.component';
76

87
/**
98
* This component represents the login page
@@ -15,7 +14,7 @@ import { LogInComponent } from '../../../../app/shared/log-in/log-in.component';
1514
// templateUrl: './login-page.component.html'
1615
templateUrl: '../../../../app/login-page/login-page.component.html',
1716
standalone: true,
18-
imports: [LogInComponent, ThemedLogInComponent ,TranslateModule],
17+
imports: [ThemedLogInComponent ,TranslateModule],
1918
})
2019
export class LoginPageComponent extends BaseComponent {
2120
}

src/themes/custom/app/register-page/register-email/register-email.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { Component } from '@angular/core';
22
import { ThemedRegisterEmailFormComponent } from 'src/app/register-email-form/themed-registry-email-form.component';
33

4-
import { RegisterEmailFormComponent } from '../../../../../app/register-email-form/register-email-form.component';
54
import { RegisterEmailComponent as BaseComponent } from '../../../../../app/register-page/register-email/register-email.component';
65

76
@Component({
@@ -12,7 +11,7 @@ import { RegisterEmailComponent as BaseComponent } from '../../../../../app/regi
1211
templateUrl: '../../../../../app/register-page/register-email/register-email.component.html',
1312
standalone: true,
1413
imports: [
15-
RegisterEmailFormComponent, ThemedRegisterEmailFormComponent,
14+
ThemedRegisterEmailFormComponent,
1615
],
1716
})
1817
/**

0 commit comments

Comments
 (0)