[DURACOM-426] refactor

Author: FrancescoMolinaro

config/config.example.yml

@@ -238,7 +238,7 @@ submission:
     # Icons to be displayed next to an authority controlled value, to give indication of the source.
     sourceIcons:
       # Example of configuration for authority logo based on sources.
-      # The condigured icon will be displayed next to the authority value in submission and on item page or search results.
+      # The configured icon will be displayed next to the authority value in submission and on item page or search results.
       - source: orcid
       - path: assets/images/orcid.logo.icon.svg
 #  Fallback language in which the UI will be rendered if the user's browser language is not an active language
@@ -718,13 +718,6 @@ identifierSubtypes:
     iconPosition: IdentifierSubtypesIconPositionEnum.LEFT
     link: https://ror.org
 
-# The maximum number of item to process when following authority metadata values.
-followAuthorityMaxItemLimit: 100
-
-# The maximum number of metadata values to process for each metadata key
-# when following authority metadata values.
-followAuthorityMetadataValuesLimit: 5;
-
 # When the search results are retrieved, for each item type the metadata with a valid authority value are inspected.
 # Referenced items will be fetched with a find all by id strategy to avoid individual rest requests to efficiently display the search results.
 followAuthorityMetadata:

src/app/core/data/external-source-data.service.ts

@@ -122,18 +122,4 @@ export class ExternalSourceDataService extends IdentifiableDataService<ExternalS
   public searchBy(searchMethod: string, options?: FindListOptions, useCachedVersionIfAvailable?: boolean, reRequestOnStale?: boolean, ...linksToFollow: FollowLinkConfig<ExternalSource>[]): Observable<RemoteData<PaginatedList<ExternalSource>>> {
     return this.searchData.searchBy(searchMethod, options, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow);
   }
-
-  /**
-   * Get an entry for an external source by given entry id
-   * @param externalSourceId  The id of the external source to fetch entries for
-   * @param entryId           The id of the entry to retrieve
-   */
-  getExternalSourceEntryById(externalSourceId: string, entryId: string): Observable<RemoteData<ExternalSourceEntry>> {
-    const href$ = this.getEntryIDHref(externalSourceId, entryId).pipe(
-      isNotEmptyOperator(),
-      distinctUntilChanged(),
-    );
-
-    return this.findByHref(href$) as any;
-  }
 }

src/app/core/shared/item.model.ts

@@ -100,7 +100,7 @@ export class Item extends DSpaceObject implements ChildHALResource, HandleObject
   isWithdrawn: boolean;
 
   /**
-   * A boolean representing if this Item is currently withdrawn or not
+   * A string representing the entity type of this Item
    */
   @autoserializeAs(String, 'entityType')
     entityType: string;

src/app/core/shared/metadata.models.ts

@@ -1,5 +1,4 @@
 /* eslint-disable max-classes-per-file */
-import { hasValue } from '@dspace/shared/utils/empty.util';
 import {
   autoserialize,
   Deserialize,
@@ -57,25 +56,6 @@ export class MetadataValue implements MetadataValueInterface {
   /** The authority confidence value */
   @autoserialize
   confidence: number;
-
-  /**
-   * Returns true if this Metadatum's authority key starts with 'virtual::'
-   */
-  get isVirtual(): boolean {
-    return hasValue(this.authority) && this.authority.startsWith(VIRTUAL_METADATA_PREFIX);
-  }
-
-  /**
-   * If this is a virtual Metadatum, it returns everything in the authority key after 'virtual::'.
-   * Returns undefined otherwise.
-   */
-  get virtualValue(): string {
-    if (this.isVirtual) {
-      return this.authority.substring(this.authority.indexOf(VIRTUAL_METADATA_PREFIX) + VIRTUAL_METADATA_PREFIX.length);
-    } else {
-      return undefined;
-    }
-  }
 }
 
 /** Constraints for matching metadata values. */

src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.ts

@@ -186,13 +186,14 @@ export class DsDynamicOneboxComponent extends DsDynamicVocabularyComponent imple
     this.isHierarchicalVocabulary$ = this.vocabulary$.pipe(
       filter((vocabulary: Vocabulary) => isNotEmpty(vocabulary)),
       map((vocabulary: Vocabulary) => vocabulary.hierarchical),
-      tap((isHierarchical: boolean) => {
-        if (this.model.value) {
-          this.setCurrentValue(this.model.value, isHierarchical);
-        }
-      }),
     );
 
+    this.subs.push(this.isHierarchicalVocabulary$.subscribe((isHierarchical) => {
+      if (this.model.value) {
+        this.setCurrentValue(this.model.value, isHierarchical);
+      }
+    }));
+
     this.subs.push(this.group.get(this.model.id).valueChanges.pipe(
       filter((value) => this.currentValue !== value))
       .subscribe((value) => {

src/app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.html

@@ -1,20 +1,23 @@
-<span class="d-flex align-items-center txt-value">
-  @if ((orcidUrl$ | async)) {
-    <a href="{{(orcidUrl$ | async)}}/{{metadataValue}}" target="_blank">
+@let hasBadge = hasOrcidBadge();
+@let orcidUrl = orcidUrl$ | async;
+
+@if (hasBadge || orcidUrl) {
+  <span class="d-flex align-items-center txt-value">
+  @if (orcidUrl) {
+    <a href="{{orcidUrl}}/{{metadataValue}}" target="_blank">
       {{ metadataValue }}
     </a>
   } @else {
     {{ metadataValue }}
   }
 
-
-  @if (hasOrcidBadge()) {
+  @if (hasBadge) {
     <img
       placement="top"
       ngbTooltip="{{ 'orcid.badge.tooltip' | translate }}"
       class="orcid-icon"
       alt="orcid-logo"
       src="assets/images/orcid.logo.icon.svg"/>
   }
-
 </span>
+}

src/app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.ts

@@ -5,9 +5,10 @@ import {
   OnInit,
 } from '@angular/core';
 import { ConfigurationDataService } from '@dspace/core/data/configuration-data.service';
+import { RemoteData } from '@dspace/core/data/remote-data';
 import { ConfigurationProperty } from '@dspace/core/shared/configuration-property.model';
 import { Item } from '@dspace/core/shared/item.model';
-import { getFirstSucceededRemoteDataPayload } from '@dspace/core/shared/operators';
+import { getFirstCompletedRemoteData } from '@dspace/core/shared/operators';
 import { NgbTooltipModule } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
 import {
@@ -41,9 +42,11 @@ export class MetadataLinkViewOrcidComponent implements OnInit {
     this.orcidUrl$ = this.configurationService
       .findByPropertyName('orcid.domain-url')
       .pipe(
-        getFirstSucceededRemoteDataPayload(),
-        map((property: ConfigurationProperty) =>
-          property?.values?.length > 0 ? property.values[0] : null,
+        getFirstCompletedRemoteData(),
+        map((propertyPayload: RemoteData<ConfigurationProperty>) =>
+          propertyPayload.hasSucceeded ?
+            (propertyPayload.payload?.values?.length > 0 ? propertyPayload.payload.values[0] : null)
+            : null,
         ),
       );
     this.metadataValue = this.itemValue.firstMetadataValue(