Skip to content

Commit a0515c4

Browse files
110615: Fixed related entities ay11 tab issue & removed potential duplicate ID issue by removing the unused #browseDropdown ID
1 parent e4f483c commit a0515c4

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/app/item-page/simple/related-entities/tabbed-related-entities-search/tabbed-related-entities-search.component.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
<ng-container *ngIf="relationTypes.length > 1">
2-
<ul ngbNav #tabs="ngbNav" [destroyOnHide]="true" [activeId]="activeTab$ | async" (navChange)="onTabChange($event)" class="nav-tabs">
3-
<li *ngFor="let relationType of relationTypes" [ngbNavItem]="relationType.filter">
4-
<a ngbNavLink>{{'item.page.relationships.' + relationType.label | translate}}</a>
2+
<ul ngbNav #tabs="ngbNav" [destroyOnHide]="true" [activeId]="activeTab$ | async" (navChange)="onTabChange($event)" class="nav-tabs" role="tablist">
3+
<li *ngFor="let relationType of relationTypes" [ngbNavItem]="relationType.filter" role="presentation">
4+
<a ngbNavLink role="tab">
5+
{{'item.page.relationships.' + relationType.label | translate}}
6+
</a>
57
<ng-template ngbNavContent>
68
<div class="mt-4">
79
<ds-related-entities-search [item]="item"

src/app/navbar/expandable-navbar-section/expandable-navbar-section.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
(mouseenter)="activateSection($event)"
77
(mouseleave)="deactivateSection($event)">
88
<a href="javascript:void(0);" class="nav-link dropdown-toggle" routerLinkActive="active"
9-
id="browseDropdown" (click)="toggleSection($event)"
9+
(click)="toggleSection($event)"
1010
data-toggle="dropdown">
1111
<ng-container
1212
*ngComponentOutlet="(sectionMap$ | async).get(section.id).component; injector: (sectionMap$ | async).get(section.id).injector;"></ng-container>

0 commit comments

Comments
 (0)