Skip to content

Commit 9ddd75d

Browse files
committed
Use more semantically appropriate elements and explicit names
1 parent c914b42 commit 9ddd75d

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="btn-group" data-toggle="buttons">
2-
<a *ngIf="isToShow(viewModeEnum.ListElement)"
2+
<button *ngIf="isToShow(viewModeEnum.ListElement)"
33
routerLink="."
44
[queryParams]="{view: 'list'}"
55
queryParamsHandling="merge"
@@ -8,9 +8,9 @@
88
[class.active]="currentMode === viewModeEnum.ListElement"
99
class="btn btn-secondary"
1010
[attr.data-test]="'list-view' | dsBrowserOnly">
11-
<i class="fas fa-list" title="{{'search.view-switch.show-list' | translate}}"></i>
12-
</a>
13-
<a *ngIf="isToShow(viewModeEnum.GridElement)"
11+
<span class="fas fa-list"></span><span class="sr-only">{{'search.view-switch.show-list' | translate}}</span>
12+
</button>
13+
<button *ngIf="isToShow(viewModeEnum.GridElement)"
1414
routerLink="."
1515
[queryParams]="{view: 'grid'}"
1616
queryParamsHandling="merge"
@@ -19,9 +19,9 @@
1919
[class.active]="currentMode === viewModeEnum.GridElement"
2020
class="btn btn-secondary"
2121
[attr.data-test]="'grid-view' | dsBrowserOnly">
22-
<i class="fas fa-th-large" title="{{'search.view-switch.show-grid' | translate}}"></i>
23-
</a>
24-
<a *ngIf="isToShow(viewModeEnum.DetailedListElement)"
22+
<span class="fas fa-th-large"></span><span class="sr-only">{{'search.view-switch.show-grid' | translate}}</span>
23+
</button>
24+
<button *ngIf="isToShow(viewModeEnum.DetailedListElement)"
2525
routerLink="."
2626
[queryParams]="{view: 'detailed'}"
2727
queryParamsHandling="merge"
@@ -30,6 +30,6 @@
3030
[class.active]="currentMode === viewModeEnum.DetailedListElement"
3131
class="btn btn-secondary"
3232
[attr.data-test]="'detail-view' | dsBrowserOnly">
33-
<i class="far fa-square" title="{{'search.view-switch.show-detail' | translate}}"></i>
34-
</a>
33+
<span class="far fa-square"></span><span class="sr-only">{{'search.view-switch.show-detail' | translate}}</span>
34+
</button>
3535
</div>

0 commit comments

Comments
 (0)