Add unit tests for the badge on bitstreams

Author: nibou230

src/app/shared/object-collection/shared/badges/access-status-badge/access-status-badge.component.spec.ts

@@ -9,6 +9,7 @@ import { TranslateModule } from '@ngx-translate/core';
 import { environment } from 'src/environments/environment';
 
 import { AccessStatusDataService } from '../../../../../core/data/access-status-data.service';
+import { Bitstream } from '../../../../../core/shared/bitstream.model';
 import { Item } from '../../../../../core/shared/item.model';
 import { createSuccessfulRemoteDataObject$ } from '../../../../remote-data.utils';
 import { TruncatePipe } from '../../../../utils/truncate.pipe';
@@ -28,6 +29,7 @@ describe('ItemAccessStatusBadgeComponent', () => {
   let accessStatusDataService: AccessStatusDataService;
 
   let item: Item;
+  let bitstream: Bitstream;
 
   function init() {
     unknownStatus = Object.assign(new AccessStatusObject(), {
@@ -44,6 +46,7 @@ describe('ItemAccessStatusBadgeComponent', () => {
 
     embargoStatus = Object.assign(new AccessStatusObject(), {
       status: 'embargo',
+      embargoDate: '2050-01-01',
     });
 
     restrictedStatus = Object.assign(new AccessStatusObject(), {
@@ -58,6 +61,11 @@ describe('ItemAccessStatusBadgeComponent', () => {
       uuid: 'item-uuid',
       type: 'item',
     });
+
+    bitstream = Object.assign(new Bitstream(), {
+      uuid: 'bitstream-uuid',
+      type: 'bitstream',
+    });
   }
 
   function initTestBed() {
@@ -70,7 +78,7 @@ describe('ItemAccessStatusBadgeComponent', () => {
     }).compileComponents();
   }
 
-  function initFixtureAndComponent() {
+  function initFixtureAndComponentWithItem() {
     environment.item.showAccessStatuses = true;
     fixture = TestBed.createComponent(AccessStatusBadgeComponent);
     component = fixture.componentInstance;
@@ -79,90 +87,163 @@ describe('ItemAccessStatusBadgeComponent', () => {
     environment.item.showAccessStatuses = false;
   }
 
-  function lookForAccessStatusBadge(status: string) {
+  function initFixtureAndComponentWithBitstream() {
+    environment.item.bitstream.showAccessStatuses = true;
+    fixture = TestBed.createComponent(AccessStatusBadgeComponent);
+    component = fixture.componentInstance;
+    component.object = bitstream;
+    fixture.detectChanges();
+    environment.item.bitstream.showAccessStatuses = false;
+  }
+
+  function lookForAccessStatusBadgeForItem(status: string) {
     const badge = fixture.debugElement.query(By.css('span.badge'));
     expect(badge.nativeElement.textContent).toEqual(`access-status.${status.toLowerCase()}.listelement.badge`);
   }
 
-  describe('init', () => {
+  function lookForAccessStatusBadgeForBitstream() {
+    const badge = fixture.debugElement.query(By.css('span.badge'));
+    expect(badge.nativeElement.textContent).toEqual(`embargo.listelement.badge`);
+  }
+
+  function lookForNoAccessStatusBadgeForBitstream() {
+    const badge = fixture.debugElement.query(By.css('span.badge'));
+    expect(badge.nativeElement.textContent).toEqual(``);
+  }
+
+  describe('init with Item', () => {
     beforeEach(waitForAsync(() => {
       init();
       initTestBed();
     }));
     beforeEach(() => {
-      initFixtureAndComponent();
+      initFixtureAndComponentWithItem();
     });
     it('should init the component', () => {
       expect(component).toBeTruthy();
     });
   });
 
-  describe('When the findItemAccessStatusFor method returns unknown', () => {
+  describe('When the findItemAccessStatusFor method returns unknown with Item', () => {
     beforeEach(waitForAsync(() => {
       init();
       initTestBed();
     }));
     beforeEach(() => {
-      initFixtureAndComponent();
+      initFixtureAndComponentWithItem();
     });
     it('should show the unknown badge', () => {
-      lookForAccessStatusBadge('unknown');
+      lookForAccessStatusBadgeForItem('unknown');
     });
   });
 
-  describe('When the findItemAccessStatusFor method returns metadata.only', () => {
+  describe('When the findItemAccessStatusFor method returns metadata.only with Item', () => {
     beforeEach(waitForAsync(() => {
       init();
       (accessStatusDataService.findItemAccessStatusFor as jasmine.Spy).and.returnValue(createSuccessfulRemoteDataObject$(metadataOnlyStatus));
       initTestBed();
     }));
     beforeEach(() => {
-      initFixtureAndComponent();
+      initFixtureAndComponentWithItem();
     });
     it('should show the metadata only badge', () => {
-      lookForAccessStatusBadge('metadata.only');
+      lookForAccessStatusBadgeForItem('metadata.only');
     });
   });
 
-  describe('When the findItemAccessStatusFor method returns open.access', () => {
+  describe('When the findItemAccessStatusFor method returns open.access with Item', () => {
     beforeEach(waitForAsync(() => {
       init();
       (accessStatusDataService.findItemAccessStatusFor as jasmine.Spy).and.returnValue(createSuccessfulRemoteDataObject$(openAccessStatus));
       initTestBed();
     }));
     beforeEach(() => {
-      initFixtureAndComponent();
+      initFixtureAndComponentWithItem();
     });
     it('should show the open access badge', () => {
-      lookForAccessStatusBadge('open.access');
+      lookForAccessStatusBadgeForItem('open.access');
     });
   });
 
-  describe('When the findItemAccessStatusFor method returns embargo', () => {
+  describe('When the findItemAccessStatusFor method returns embargo with Item', () => {
     beforeEach(waitForAsync(() => {
       init();
       (accessStatusDataService.findItemAccessStatusFor as jasmine.Spy).and.returnValue(createSuccessfulRemoteDataObject$(embargoStatus));
       initTestBed();
     }));
     beforeEach(() => {
-      initFixtureAndComponent();
+      initFixtureAndComponentWithItem();
     });
     it('should show the embargo badge', () => {
-      lookForAccessStatusBadge('embargo');
+      lookForAccessStatusBadgeForItem('embargo');
     });
   });
 
-  describe('When the findItemAccessStatusFor method returns restricted', () => {
+  describe('When the findItemAccessStatusFor method returns restricted with Item', () => {
     beforeEach(waitForAsync(() => {
       init();
       (accessStatusDataService.findItemAccessStatusFor as jasmine.Spy).and.returnValue(createSuccessfulRemoteDataObject$(restrictedStatus));
       initTestBed();
     }));
     beforeEach(() => {
-      initFixtureAndComponent();
+      initFixtureAndComponentWithItem();
     });
     it('should show the restricted badge', () => {
-      lookForAccessStatusBadge('restricted');
+      lookForAccessStatusBadgeForItem('restricted');
+    });
+  });
+
+  describe('init with Bitstream', () => {
+    beforeEach(waitForAsync(() => {
+      init();
+      initTestBed();
+    }));
+    beforeEach(() => {
+      initFixtureAndComponentWithBitstream();
+    });
+    it('should init the component', () => {
+      expect(component).toBeTruthy();
+    });
+  });
+
+  describe('When the bitstream have no access status', () => {
+    beforeEach(waitForAsync(() => {
+      init();
+      initTestBed();
+    }));
+    beforeEach(() => {
+      initFixtureAndComponentWithBitstream();
+    });
+    it('should not show the badge', () => {
+      lookForNoAccessStatusBadgeForBitstream();
+    });
+  });
+
+  describe('When the bitstream have an access status with no embargo date', () => {
+    beforeEach(waitForAsync(() => {
+      init();
+      initTestBed();
+    }));
+    beforeEach(() => {
+      bitstream.accessStatus = createSuccessfulRemoteDataObject$(openAccessStatus);
+      initFixtureAndComponentWithBitstream();
+    });
+    it('should not show the badge', () => {
+      lookForNoAccessStatusBadgeForBitstream();
+    });
+  });
+
+  describe('When the bitstream have an access status with an embargo date', () => {
+    beforeEach(waitForAsync(() => {
+      init();
+      initTestBed();
+    }));
+    beforeEach(() => {
+      bitstream.accessStatus = createSuccessfulRemoteDataObject$(embargoStatus);
+      initFixtureAndComponentWithBitstream();
+    });
+    it('should show the badge', () => {
+      lookForAccessStatusBadgeForBitstream();
     });
   });
 });

src/app/shared/object-collection/shared/badges/access-status-badge/access-status-badge.component.ts

@@ -135,14 +135,19 @@ export class AccessStatusBadgeComponent implements OnDestroy, OnInit {
       getFirstSucceededRemoteDataPayload(),
       map((accessStatus: AccessStatusObject) => {
         if (hasValue(accessStatus.embargoDate)) {
-          this.accessStatus$ = observableOf('embargo.listelement.badge');
           return accessStatus.embargoDate;
         } else {
-          this.accessStatus$ = observableOf(null);
           return null;
         }
       }),
       catchError(() => observableOf(null)),
     );
+    this.subs.push(
+      this.embargoDate$.pipe().subscribe((embargoDate: string) => {
+        if (hasValue(embargoDate)) {
+          this.accessStatus$ = observableOf('embargo.listelement.badge');
+        }
+      }),
+    );
   }
 }