134770: Fixed lint issues & rules

(cherry picked from commit b50bc4f)

Author: alexandrevryghem

.eslintrc.json

@@ -12,6 +12,7 @@
     "eslint-plugin-rxjs",
     "eslint-plugin-simple-import-sort",
     "eslint-plugin-import-newlines",
+    "@stylistic",
     "dspace-angular-ts",
     "dspace-angular-html"
   ],
@@ -176,15 +177,15 @@
           }
         ],
         "@angular-eslint/prefer-inject": "off",
-        "@typescript-eslint/quotes": [
+        "@stylistic/quotes": [
           "error",
           "single",
           {
             "avoidEscape": true,
             "allowTemplateLiterals": true
           }
         ],
-        "@typescript-eslint/semi": "error",
+        "@stylistic/semi": "error",
         "@typescript-eslint/no-shadow": "error",
         "@typescript-eslint/dot-notation": "error",
         "@typescript-eslint/consistent-type-definitions": "error",
@@ -207,9 +208,9 @@
             ]
           }
         ],
-        "@typescript-eslint/type-annotation-spacing": "error",
+        "@stylistic/type-annotation-spacing": "error",
         "@typescript-eslint/unified-signatures": "error",
-        "@typescript-eslint/ban-types": "error",
+        "@typescript-eslint/no-restricted-types": "error",
         "@typescript-eslint/no-floating-promises": "warn",
         "@typescript-eslint/no-misused-promises": "warn",
         "@typescript-eslint/restrict-plus-operands": "warn",
@@ -280,7 +281,7 @@
             ]
           }
         ],
-        "dspace-angular-ts/themed-component-classes": "error",
+        "dspace-angular-ts/no-default-standalone-value": "error",
         "dspace-angular-ts/themed-component-selectors": "error",
         "dspace-angular-ts/themed-component-usages": "error",
         "dspace-angular-ts/themed-decorators": [

cypress/plugins/index.ts

@@ -1,4 +1,4 @@
-const fs = require('node:fs');
+import fs from 'node:fs';
 
 // These two global variables are used to store information about the REST API used
 // by these e2e tests. They are filled out prior to running any tests in the before()

docs/lint/html/rules/themed-component-usages.md

@@ -30,11 +30,7 @@ _______
 ##### use no-prefix selectors in TypeScript templates
         
 ```html
-@Component({
-  template: '<ds-test-themeable></ds-test-themeable>'
-})
-class Test {
-}
+<ds-test-themeable></ds-test-themeable>
 ```
         
 
@@ -43,11 +39,7 @@ class Test {
 Filename: `lint/test/fixture/src/test.spec.ts`
 
 ```html
-@Component({
-  template: '<ds-test-themeable></ds-test-themeable>'
-})
-class Test {
-}
+<ds-test-themeable></ds-test-themeable>
 ```
         
 
@@ -56,11 +48,7 @@ class Test {
 Filename: `lint/test/fixture/src/test.spec.ts`
 
 ```html
-@Component({
-  template: '<ds-base-test-themeable></ds-base-test-themeable>'
-})
-class Test {
-}
+<ds-base-test-themeable></ds-base-test-themeable>
 ```
         
 

docs/lint/ts/index.md

@@ -2,8 +2,8 @@
 _______
 
 - [`dspace-angular-ts/alias-imports`](./rules/alias-imports.md): Unclear imports should be aliased for clarity
+- [`dspace-angular-ts/no-default-standalone-value`](./rules/no-default-standalone-value.md): Removes unnecessary explicit standalone declarations of the @Component decorators. Starting from Angular 19 this is now the default value.
 - [`dspace-angular-ts/sort-standalone-imports`](./rules/sort-standalone-imports.md): Sorts the standalone `@Component` imports alphabetically
-- [`dspace-angular-ts/themed-component-classes`](./rules/themed-component-classes.md): Formatting rules for themeable component classes
 - [`dspace-angular-ts/themed-component-selectors`](./rules/themed-component-selectors.md): Themeable component selectors should follow the DSpace convention
 - [`dspace-angular-ts/themed-component-usages`](./rules/themed-component-usages.md): Themeable components should be used via their `ThemedComponent` wrapper class
 - [`dspace-angular-ts/themed-decorators`](./rules/themed-decorators.md): Entry components with theme support should declare the correct theme

docs/lint/ts/rules/no-default-standalone-value.md

@@ -0,0 +1,69 @@
+[DSpace ESLint plugins](../../../../lint/README.md) > [TypeScript rules](../index.md) > `dspace-angular-ts/no-default-standalone-value`
+_______
+
+Removes unnecessary explicit standalone declarations of the @Component decorators. Starting from Angular 19 this is now the default value.
+
+_______
+
+[Source code](../../../../lint/src/rules/ts/no-default-standalone-value.ts)
+
+
+
+### Examples
+
+
+#### Valid code
+    
+##### Not setting the standalone value is valid
+        
+```typescript
+@Component({
+  selector: 'ds-test',
+})
+class TestComponent {}
+```
+        
+    
+##### Setting the standalone value to false is valid
+        
+```typescript
+@Component({
+  selector: 'ds-test',
+  standalone: false,
+})
+class TestComponent {}
+```
+        
+    
+
+
+
+#### Invalid code  & automatic fixes
+    
+##### Should not have explicit standalone declaration
+        
+```typescript
+@Component({
+  selector: 'ds-test',
+  standalone: true,
+})
+class TestComponent {}
+
+        
+
+```
+Will produce the following error(s):
+```
+Unnecessary explicit standalone declaration of the @Component decorator should be removed.
+```
+        
+Result of `yarn lint --fix`:
+```typescript
+@Component({
+  selector: 'ds-test',
+})
+class TestComponent {}
+```
+        
+    
+