[DSC-758] fix broken tests

Author: Andrea Barbasso

src/app/core/locale/locale.service.spec.ts

@@ -25,10 +25,6 @@ fdescribe('LocaleService test suite', () => {
   let document;
   let spyOnGetLanguage;
 
-  authService = jasmine.createSpyObj('AuthService', {
-    isAuthenticated: jasmine.createSpy('isAuthenticated'),
-    isAuthenticationLoaded: jasmine.createSpy('isAuthenticationLoaded')
-  });
 
   const translateServiceStub: any = {
     getLangs: () => {
@@ -38,145 +34,153 @@ fdescribe('LocaleService test suite', () => {
       return langList;
     },
     // eslint-disable-next-line @typescript-eslint/no-empty-function
-    use: (param: string) => {}
+    use: (param: string) => {
+    }
   };
 
-  const langList = ['en', 'it', 'de'];
-
-  beforeEach(waitForAsync(() => {
-    return TestBed.configureTestingModule({
-      imports: [
-        TranslateModule.forRoot({
-          loader: {
-            provide: TranslateLoader,
-            useClass: TranslateLoaderMock
-          }
-        }),
-      ],
-      providers: [
-        { provide: CookieService, useValue: new CookieServiceMock() },
-        { provide: AuthService, userValue: authService },
-        { provide: RouteService, useValue: routeServiceStub },
-        { provide: TranslateService, useValue: translateServiceStub },
-        { provide: Document, useValue: document },
-      ]
-    });
-  }));
-
-  beforeEach(() => {
-    cookieService = TestBed.inject(CookieService);
-    translateService = TestBed.inject(TranslateService);
-    routeService = TestBed.inject(RouteService);
-    window = new NativeWindowRef();
-    document = { documentElement: { lang: 'en' } };
-    service = new LocaleService(window, cookieService, translateService, authService, routeService, document);
-    serviceAsAny = service;
-    spyOnGet = spyOn(cookieService, 'get');
-    spyOnSet = spyOn(cookieService, 'set');
-    spyOnGetLanguage = spyOn(routeService, 'getQueryParameterValue').withArgs('lang');
+  authService = jasmine.createSpyObj('AuthService', {
+    isAuthenticated: jasmine.createSpy('isAuthenticated'),
+    isAuthenticationLoaded: jasmine.createSpy('isAuthenticationLoaded')
   });
+  const langList = ['en', 'xx', 'de'];
+
+  describe('with valid language', () => {
+
+    beforeEach(waitForAsync(() => {
+      return TestBed.configureTestingModule({
+        imports: [
+          TranslateModule.forRoot({
+            loader: {
+              provide: TranslateLoader,
+              useClass: TranslateLoaderMock
+            }
+          }),
+        ],
+        providers: [
+          { provide: CookieService, useValue: new CookieServiceMock() },
+          { provide: AuthService, userValue: authService },
+          { provide: RouteService, useValue: routeServiceStub },
+          { provide: TranslateService, useValue: translateServiceStub },
+          { provide: Document, useValue: document },
+        ]
+      });
+    }));
 
-  describe('getCurrentLanguageCode', () => {
-    it('should return language saved on cookie', () => {
-      spyOnGet.and.returnValue('de');
-      expect(service.getCurrentLanguageCode()).toBe('de');
+    beforeEach(() => {
+      cookieService = TestBed.inject(CookieService);
+      translateService = TestBed.inject(TranslateService);
+      routeService = TestBed.inject(RouteService);
+      window = new NativeWindowRef();
+      document = { documentElement: { lang: 'en' } };
+      service = new LocaleService(window, cookieService, translateService, authService, routeService, document);
+      serviceAsAny = service;
+      spyOnGet = spyOn(cookieService, 'get');
+      spyOnSet = spyOn(cookieService, 'set');
+      spyOnGetLanguage = spyOn(routeService, 'getQueryParameterValue').withArgs('lang');
     });
 
-    describe('', () => {
-      beforeEach(() => {
-        spyOn(translateService, 'getLangs').and.returnValue(langList);
+    describe('getCurrentLanguageCode', () => {
+      it('should return language saved on cookie', () => {
+        spyOnGet.and.returnValue('de');
+        expect(service.getCurrentLanguageCode()).toBe('de');
       });
 
-      it('should return language from browser setting', () => {
-        spyOn(translateService, 'getBrowserLang').and.returnValue('it');
-        expect(service.getCurrentLanguageCode()).toBe('it');
-      });
+      describe('', () => {
+        beforeEach(() => {
+          spyOn(translateService, 'getLangs').and.returnValue(langList);
+        });
 
-      it('should return default language from config', () => {
-        spyOn(translateService, 'getBrowserLang').and.returnValue('fr');
-        expect(service.getCurrentLanguageCode()).toBe('en');
-      });
-    });
-  });
+        it('should return language from browser setting', () => {
+          spyOn(translateService, 'getBrowserLang').and.returnValue('xx');
+          expect(service.getCurrentLanguageCode()).toBe('xx');
+        });
 
-  describe('getLanguageCodeFromCookie', () => {
-    it('should return language from cookie', () => {
-      spyOnGet.and.returnValue('de');
-      expect(service.getLanguageCodeFromCookie()).toBe('de');
+        it('should return default language from config', () => {
+          spyOn(translateService, 'getBrowserLang').and.returnValue('fr');
+          expect(service.getCurrentLanguageCode()).toBe('en');
+        });
+      });
     });
 
-  });
+    describe('getLanguageCodeFromCookie', () => {
+      it('should return language from cookie', () => {
+        spyOnGet.and.returnValue('de');
+        expect(service.getLanguageCodeFromCookie()).toBe('de');
+      });
 
-  describe('saveLanguageCodeToCookie', () => {
-    it('should save language to cookie', () => {
-      service.saveLanguageCodeToCookie('en');
-      expect(spyOnSet).toHaveBeenCalledWith(LANG_COOKIE, 'en');
     });
-  });
 
-  describe('setCurrentLanguageCode', () => {
-    beforeEach(() => {
-      spyOn(service, 'saveLanguageCodeToCookie');
-      spyOn(translateService, 'use');
+    describe('saveLanguageCodeToCookie', () => {
+      it('should save language to cookie', () => {
+        service.saveLanguageCodeToCookie('en');
+        expect(spyOnSet).toHaveBeenCalledWith(LANG_COOKIE, 'en');
+      });
     });
 
-    it('should set the given language', () => {
-      service.setCurrentLanguageCode('it');
-      expect(translateService.use).toHaveBeenCalledWith('it');
-      expect(service.saveLanguageCodeToCookie).toHaveBeenCalledWith('it');
-    });
+    describe('setCurrentLanguageCode', () => {
+      beforeEach(() => {
+        spyOn(service, 'saveLanguageCodeToCookie');
+        spyOn(translateService, 'use');
+      });
 
-    it('should set the current language', () => {
-      spyOn(service, 'getCurrentLanguageCode').and.returnValue('es');
-      service.setCurrentLanguageCode();
-      expect(translateService.use).toHaveBeenCalledWith('es');
-      expect(service.saveLanguageCodeToCookie).toHaveBeenCalledWith('es');
-    });
+      it('should set the given language', () => {
+        service.setCurrentLanguageCode('it');
+        expect(translateService.use).toHaveBeenCalledWith('it');
+        expect(service.saveLanguageCodeToCookie).toHaveBeenCalledWith('it');
+      });
 
-    it('should set the current language on the html tag', () => {
-      spyOn(service, 'getCurrentLanguageCode').and.returnValue('es');
-      service.setCurrentLanguageCode();
-      expect((service as any).document.documentElement.lang).toEqual('es');
-    });
+      it('should set the current language', () => {
+        spyOn(service, 'getCurrentLanguageCode').and.returnValue('es');
+        service.setCurrentLanguageCode();
+        expect(translateService.use).toHaveBeenCalledWith('es');
+        expect(service.saveLanguageCodeToCookie).toHaveBeenCalledWith('es');
+      });
 
-    describe('should set language on init', () => {
-      beforeEach(() => {
-        spyOn(translateService, 'getLangs').and.returnValue(langList);
-        spyOn(service, 'setCurrentLanguageCode');
+      it('should set the current language on the html tag', () => {
+        spyOn(service, 'getCurrentLanguageCode').and.returnValue('es');
+        service.setCurrentLanguageCode();
+        expect((service as any).document.documentElement.lang).toEqual('es');
       });
-      describe('whith correct lang query param ', () => {
+
+      describe('should set language on init', () => {
         beforeEach(() => {
-          spyOnGetLanguage.and.returnValue(observableOf('en'));
-          service.initDefaults();
-        });
-        it('should set correct lang', () => {
-          expect(service.setCurrentLanguageCode).toHaveBeenCalledWith('en');
+          spyOn(translateService, 'getLangs').and.returnValue(langList);
+          spyOn(service, 'setCurrentLanguageCode');
         });
-      });
-      describe('whith wrong lang query param ', () => {
-        beforeEach(() => {
-          spyOnGetLanguage.and.returnValue(observableOf('abcd'));
-          service.initDefaults();
+        describe('whith correct lang query param ', () => {
+          beforeEach(() => {
+            spyOnGetLanguage.and.returnValue(observableOf('en'));
+            service.initDefaults();
+          });
+          it('should set correct lang', () => {
+            expect(service.setCurrentLanguageCode).toHaveBeenCalledWith('en');
+          });
         });
-        it('should not set lang', () => {
-          expect(service.setCurrentLanguageCode).not.toHaveBeenCalled();
+        describe('whith wrong lang query param ', () => {
+          beforeEach(() => {
+            spyOnGetLanguage.and.returnValue(observableOf('abcd'));
+            service.initDefaults();
+          });
+          it('should not set lang', () => {
+            expect(service.setCurrentLanguageCode).not.toHaveBeenCalled();
+          });
         });
       });
     });
-  });
 
-  describe('', () => {
-    it('should set quality to current language list', () => {
-      const langListWithQuality = ['en;q=1', 'it;q=0.9', 'de;q=0.8'];
-      spyOn(service, 'setQuality').and.returnValue(langListWithQuality);
-      service.setQuality(langList, LANG_ORIGIN.BROWSER, false);
-      expect(service.setQuality).toHaveBeenCalledWith(langList, LANG_ORIGIN.BROWSER, false);
-    });
+    describe('', () => {
+      it('should set quality to current language list', () => {
+        const langListWithQuality = ['en;q=1', 'it;q=0.9', 'de;q=0.8'];
+        spyOn(service, 'setQuality').and.returnValue(langListWithQuality);
+        service.setQuality(langList, LANG_ORIGIN.BROWSER, false);
+        expect(service.setQuality).toHaveBeenCalledWith(langList, LANG_ORIGIN.BROWSER, false);
+      });
 
-    it('should return the list of language with quality factor', () => {
-      spyOn(service, 'getLanguageCodeList');
-      service.getLanguageCodeList();
-      expect(service.getLanguageCodeList).toHaveBeenCalled();
+      it('should return the list of language with quality factor', () => {
+        spyOn(service, 'getLanguageCodeList');
+        service.getLanguageCodeList();
+        expect(service.getLanguageCodeList).toHaveBeenCalled();
+      });
     });
   });
 });