Skip to content

Commit 8c52f2a

Browse files
tdonohuetdonohue
authored
Merge pull request DSpace#2235 from alexandrevryghem/themed-thumbnail_component-main
Fixed `ngOnChanges` not working for themed components & decorator components + minor fixes
2 parents e04dd9e + 8dd0b49 commit 8c52f2a

56 files changed

Lines changed: 385 additions & 194 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="container" *ngVar="(bitstreamFormatsRD$ | async) as formatsRD">
33
<div class="row" *ngIf="bitstreamRD?.hasSucceeded && formatsRD?.hasSucceeded">
44
<div class="col-md-2">
5-
<ds-thumbnail [thumbnail]="bitstreamRD?.payload"></ds-thumbnail>
5+
<ds-themed-thumbnail [thumbnail]="bitstreamRD?.payload"></ds-themed-thumbnail>
66
</div>
77
<div class="col-md-10">
88
<div class="container">

‎src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal-issue/journal-issue-search-result-grid-element.component.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width" [attr.title]="'search.results.view-result' | translate">
1010
<div>
11-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12-
</ds-thumbnail>
11+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12+
</ds-themed-thumbnail>
1313
</div>
1414
</a>
1515
<span *ngIf="linkType == linkTypes.None" class="card-img-top full-width">
1616
<div>
17-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18-
</ds-thumbnail>
17+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18+
</ds-themed-thumbnail>
1919
</div>
2020
</span>
2121
<div class="card-body">

‎src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal-volume/journal-volume-search-result-grid-element.component.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width" [attr.title]="'search.results.view-result' | translate">
1010
<div>
11-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12-
</ds-thumbnail>
11+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12+
</ds-themed-thumbnail>
1313
</div>
1414
</a>
1515
<span *ngIf="linkType == linkTypes.None" class="card-img-top full-width">
1616
<div>
17-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18-
</ds-thumbnail>
17+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18+
</ds-themed-thumbnail>
1919
</div>
2020
</span>
2121
<div class="card-body">

‎src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal/journal-search-result-grid-element.component.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width" [attr.title]="'search.results.view-result' | translate">
1010
<div>
11-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12-
</ds-thumbnail>
11+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12+
</ds-themed-thumbnail>
1313
</div>
1414
</a>
1515
<span *ngIf="linkType == linkTypes.None" class="card-img-top full-width">
1616
<div>
17-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18-
</ds-thumbnail>
17+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18+
</ds-themed-thumbnail>
1919
</div>
2020
</span>
2121
<div class="card-body">

‎src/app/entity-groups/journal-entities/item-pages/journal-issue/journal-issue.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<div class="row">
88
<div class="col-xs-12 col-md-4">
99
<ds-metadata-field-wrapper [hideIfNoTextContent]="false">
10-
<ds-thumbnail [thumbnail]="object?.thumbnail | async"></ds-thumbnail>
10+
<ds-themed-thumbnail [thumbnail]="object?.thumbnail | async"></ds-themed-thumbnail>
1111
</ds-metadata-field-wrapper>
1212
<ds-generic-item-page-field [item]="object"
1313
[fields]="['publicationvolume.volumeNumber']"

‎src/app/entity-groups/journal-entities/item-pages/journal-volume/journal-volume.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<div class="row">
88
<div class="col-xs-12 col-md-4">
99
<ds-metadata-field-wrapper [hideIfNoTextContent]="false">
10-
<ds-thumbnail [thumbnail]="object?.thumbnail | async"></ds-thumbnail>
10+
<ds-themed-thumbnail [thumbnail]="object?.thumbnail | async"></ds-themed-thumbnail>
1111
</ds-metadata-field-wrapper>
1212
<ds-generic-item-page-field [item]="object"
1313
[fields]="['publicationvolume.volumeNumber']"

‎src/app/entity-groups/journal-entities/item-pages/journal/journal.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<div class="row">
88
<div class="col-xs-12 col-md-4">
99
<ds-metadata-field-wrapper [hideIfNoTextContent]="false">
10-
<ds-thumbnail [thumbnail]="object?.thumbnail | async"></ds-thumbnail>
10+
<ds-themed-thumbnail [thumbnail]="object?.thumbnail | async"></ds-themed-thumbnail>
1111
</ds-metadata-field-wrapper>
1212
<ds-generic-item-page-field class="item-page-fields" [item]="object"
1313
[fields]="['creativeworkseries.issn']"

‎src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/org-unit/org-unit-search-result-grid-element.component.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width" [attr.title]="'search.results.view-result' | translate">
1010
<div>
11-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12-
</ds-thumbnail>
11+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12+
</ds-themed-thumbnail>
1313
</div>
1414
</a>
1515
<span *ngIf="linkType == linkTypes.None" class="card-img-top full-width">
1616
<div>
17-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18-
</ds-thumbnail>
17+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18+
</ds-themed-thumbnail>
1919
</div>
2020
</span>
2121
<div class="card-body">

‎src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/person/person-search-result-grid-element.component.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width" [attr.title]="'search.results.view-result' | translate">
1010
<div>
11-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12-
</ds-thumbnail>
11+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12+
</ds-themed-thumbnail>
1313
</div>
1414
</a>
1515
<span *ngIf="linkType == linkTypes.None" class="card-img-top full-width">
1616
<div>
17-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18-
</ds-thumbnail>
17+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18+
</ds-themed-thumbnail>
1919
</div>
2020
</span>
2121
<div class="card-body">

‎src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/project/project-search-result-grid-element.component.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width" [attr.title]="'search.results.view-result' | translate">
1010
<div>
11-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12-
</ds-thumbnail>
11+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
12+
</ds-themed-thumbnail>
1313
</div>
1414
</a>
1515
<span *ngIf="linkType == linkTypes.None" class="card-img-top full-width">
1616
<div>
17-
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18-
</ds-thumbnail>
17+
<ds-themed-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
18+
</ds-themed-thumbnail>
1919
</div>
2020
</span>
2121
<div class="card-body">

0 commit comments

Comments
 (0)