Skip to content

Commit 89447a6

Browse files
authored
Merge pull request DSpace#1927 from tdonohue/no_unused_imports
Turn on no-unused-imports rule and remove all unused imports
2 parents 340cc0a + cc86ba5 commit 89447a6

42 files changed

Lines changed: 21 additions & 81 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"eslint-plugin-import",
77
"eslint-plugin-jsdoc",
88
"eslint-plugin-deprecation",
9-
"eslint-plugin-unused-imports",
9+
"unused-imports",
1010
"eslint-plugin-lodash"
1111
],
1212
"overrides": [
@@ -205,7 +205,7 @@
205205
"import/order": "off",
206206
"import/no-deprecated": "warn",
207207
"import/no-namespace": "error",
208-
208+
"unused-imports/no-unused-imports": "error",
209209
"lodash/import-scope": [
210210
"error",
211211
"method"

src/app/admin/admin-import-metadata-page/metadata-import-page.component.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
import { Location } from '@angular/common';
2-
import { Component, OnInit } from '@angular/core';
2+
import { Component } from '@angular/core';
33
import { Router } from '@angular/router';
44
import { TranslateService } from '@ngx-translate/core';
5-
import { Observable } from 'rxjs';
6-
import { map, switchMap } from 'rxjs/operators';
7-
import { AuthService } from '../../core/auth/auth.service';
85
import { METADATA_IMPORT_SCRIPT_NAME, ScriptDataService } from '../../core/data/processes/script-data.service';
9-
import { EPerson } from '../../core/eperson/models/eperson.model';
106
import { ProcessParameter } from '../../process-page/processes/process-parameter.model';
117
import { isNotEmpty } from '../../shared/empty.util';
128
import { NotificationsService } from '../../shared/notifications/notifications.service';

src/app/admin/admin-registries/bitstream-formats/bitstream-formats.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
import { Component, OnDestroy, OnInit } from '@angular/core';
2-
import {combineLatest, combineLatest as observableCombineLatest, Observable, of as observableOf, zip} from 'rxjs';
2+
import { combineLatest as observableCombineLatest, Observable} from 'rxjs';
33
import { RemoteData } from '../../../core/data/remote-data';
44
import { PaginatedList } from '../../../core/data/paginated-list.model';
55
import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
66
import { BitstreamFormat } from '../../../core/shared/bitstream-format.model';
77
import { BitstreamFormatDataService } from '../../../core/data/bitstream-format-data.service';
88
import { map, mergeMap, switchMap, take, toArray } from 'rxjs/operators';
9-
import { hasValue } from '../../../shared/empty.util';
109
import { NotificationsService } from '../../../shared/notifications/notifications.service';
1110
import { Router } from '@angular/router';
1211
import { TranslateService } from '@ngx-translate/core';

src/app/admin/admin-registries/metadata-registry/metadata-registry.component.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,7 @@ import { RestResponse } from '../../../core/cache/response.models';
1919
import { MetadataSchema } from '../../../core/metadata/metadata-schema.model';
2020
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
2121
import { PaginationService } from '../../../core/pagination/pagination.service';
22-
import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
23-
import { SortDirection, SortOptions } from '../../../core/cache/models/sort-options.model';
2422
import { PaginationServiceStub } from '../../../shared/testing/pagination-service.stub';
25-
import { FindListOptions } from '../../../core/data/find-list-options.model';
2623

2724
describe('MetadataRegistryComponent', () => {
2825
let comp: MetadataRegistryComponent;

src/app/admin/admin-registries/metadata-schema/metadata-schema.component.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,8 @@ import { MetadataSchema } from '../../../core/metadata/metadata-schema.model';
2323
import { MetadataField } from '../../../core/metadata/metadata-field.model';
2424
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
2525
import { VarDirective } from '../../../shared/utils/var.directive';
26-
import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
27-
import { SortDirection, SortOptions } from '../../../core/cache/models/sort-options.model';
2826
import { PaginationService } from '../../../core/pagination/pagination.service';
2927
import { PaginationServiceStub } from '../../../shared/testing/pagination-service.stub';
30-
import { FindListOptions } from '../../../core/data/find-list-options.model';
3128

3229
describe('MetadataSchemaComponent', () => {
3330
let comp: MetadataSchemaComponent;

src/app/admin/admin-sidebar/admin-sidebar.component.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
1616
import { RouterTestingModule } from '@angular/router/testing';
1717
import { ActivatedRoute } from '@angular/router';
1818
import { AuthorizationDataService } from '../../core/data/feature-authorization/authorization-data.service';
19-
import { FeatureID } from '../../core/data/feature-authorization/feature-id';
2019
import createSpy = jasmine.createSpy;
2120
import { createSuccessfulRemoteDataObject } from '../../shared/remote-data.utils';
2221
import { Item } from '../../core/shared/item.model';

src/app/app.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import { models } from './core/core.module';
3131
import { ThemeService } from './shared/theme-support/theme.service';
3232
import { IdleModalComponent } from './shared/idle-modal/idle-modal.component';
3333
import { distinctNext } from './core/shared/distinct-next';
34-
import { ModalBeforeDismiss } from './shared/interfaces/modal-before-dismiss.interface';
3534

3635
@Component({
3736
selector: 'ds-app',

src/app/bitstream-page/legacy-bitstream-url.resolver.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { LegacyBitstreamUrlResolver } from './legacy-bitstream-url.resolver';
2-
import { of as observableOf, EMPTY } from 'rxjs';
2+
import { EMPTY } from 'rxjs';
33
import { BitstreamDataService } from '../core/data/bitstream-data.service';
44
import { RemoteData } from '../core/data/remote-data';
55
import { TestScheduler } from 'rxjs/testing';

src/app/browse-by/browse-by-guard.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { first } from 'rxjs/operators';
22
import { BrowseByGuard } from './browse-by-guard';
33
import { of as observableOf } from 'rxjs';
4-
import { BrowseDefinitionDataService } from '../core/browse/browse-definition-data.service';
54
import { createSuccessfulRemoteDataObject$ } from '../shared/remote-data.utils';
65
import { BrowseDefinition } from '../core/shared/browse-definition.model';
76
import { BrowseByDataType } from './browse-by-switcher/browse-by-decorator';

src/app/collection-page/collection-item-mapper/collection-item-mapper.component.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { Collection } from '../../core/shared/collection.model';
1616
import { RemoteData } from '../../core/data/remote-data';
1717
import { PaginationComponentOptions } from '../../shared/pagination/pagination-component-options.model';
1818
import { SortDirection, SortOptions } from '../../core/cache/models/sort-options.model';
19-
import { ChangeDetectionStrategy, EventEmitter } from '@angular/core';
19+
import { EventEmitter } from '@angular/core';
2020
import { HostWindowService } from '../../shared/host-window.service';
2121
import { HostWindowServiceStub } from '../../shared/testing/host-window-service.stub';
2222
import { By } from '@angular/platform-browser';
@@ -41,7 +41,7 @@ import {
4141
} from '../../shared/remote-data.utils';
4242
import { createPaginatedList } from '../../shared/testing/utils.test';
4343
import { AuthorizationDataService } from '../../core/data/feature-authorization/authorization-data.service';
44-
import { MyDSpacePageComponent, SEARCH_CONFIG_SERVICE } from '../../my-dspace-page/my-dspace-page.component';
44+
import { SEARCH_CONFIG_SERVICE } from '../../my-dspace-page/my-dspace-page.component';
4545
import { SearchConfigurationServiceStub } from '../../shared/testing/search-configuration-service.stub';
4646
import { GroupDataService } from '../../core/eperson/group-data.service';
4747
import { LinkHeadService } from '../../core/services/link-head.service';

0 commit comments

Comments
 (0)