Skip to content

Commit 828f258

Browse files
authored
Merge pull request DSpace#2261 from tdonohue/fix_unsafe_links
Fix several "potentially unsafe external link" warnings
2 parents dd6051b + edeea00 commit 828f258

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/app/shared/context-help-wrapper/context-help-wrapper.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="preserve-line-breaks ds-context-help-content">
33
<ng-container *ngFor="let elem of (parsedContent$ | async)">
44
<ng-container *ngIf="elem.href">
5-
<a href="{{elem.href}}" target="_blank">{{elem.text}}</a>
5+
<a href="{{elem.href}}" target="_blank" rel="noopener noreferrer">{{elem.text}}</a>
66
</ng-container>
77
<ng-container *ngIf="elem.href === undefined">
88
{{ elem }}

src/app/submission/sections/sherpa-policies/publication-information/publication-information.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</div>
2424
<div class="col-4">
2525
<p class="m-1">
26-
<a href="{{journal.url}}" target="_blank">
26+
<a href="{{journal.url}}" target="_blank" rel="noopener noreferrer">
2727
{{journal.url}}
2828
</a>
2929
</p>
@@ -35,7 +35,7 @@
3535
</div>
3636
<div class="col-4" *ngFor="let publisher of journal.publishers">
3737
<p class="m-1">
38-
<a href="{{publisher.uri}}" target="_blank">
38+
<a href="{{publisher.uri}}" target="_blank" rel="noopener noreferrer">
3939
{{publisher.name}}
4040
</a>
4141
</p>

src/app/submission/sections/sherpa-policies/publisher-policy/publisher-policy.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</p>
99
<ul>
1010
<li *ngFor="let url of policy.urls | keyvalue">
11-
<a href="{{url.key}}" target="_blank">{{url.value}}</a>
11+
<a href="{{url.key}}" target="_blank" rel="noopener noreferrer">{{url.value}}</a>
1212
</li>
1313
</ul>
1414
</div>

0 commit comments

Comments
 (0)