Skip to content

Commit 81a1986

Browse files
[DSC-2436] fix failed test
1 parent a3a3b42 commit 81a1986

1 file changed

Lines changed: 19 additions & 6 deletions

File tree

src/app/process-page/overview/table/process-overview-table.component.spec.ts

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { BehaviorSubject } from 'rxjs';
1515
import { take } from 'rxjs/operators';
1616

1717
import { AuthService } from '../../../core/auth/auth.service';
18+
import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
1819
import { ProcessDataService } from '../../../core/data/processes/process-data.service';
1920
import { EPersonDataService } from '../../../core/eperson/eperson-data.service';
2021
import { EPerson } from '../../../core/eperson/models/eperson.model';
@@ -34,7 +35,7 @@ import { ProcessBulkDeleteService } from '../process-bulk-delete.service';
3435
import { ProcessOverviewService } from '../process-overview.service';
3536
import { ProcessOverviewTableComponent } from './process-overview-table.component';
3637

37-
describe('ProcessOverviewTableComponent', () => {
38+
fdescribe('ProcessOverviewTableComponent', () => {
3839
let component: ProcessOverviewTableComponent;
3940
let fixture: ComponentFixture<ProcessOverviewTableComponent>;
4041

@@ -46,6 +47,7 @@ describe('ProcessOverviewTableComponent', () => {
4647
let modalService: NgbModal;
4748
let authService; // : AuthService; Not typed as the mock does not fully implement AuthService
4849
let routeService: RouteService;
50+
let authorizationService: AuthorizationDataService;
4951

5052
let processes: Process[];
5153
let ePerson: EPerson;
@@ -135,12 +137,21 @@ describe('ProcessOverviewTableComponent', () => {
135137

136138
authService = new AuthServiceMock();
137139
routeService = routeServiceStub;
140+
141+
authorizationService = jasmine.createSpyObj('authorizationService', {
142+
isAuthorized: new BehaviorSubject(true),
143+
});
138144
}
139145

140146
beforeEach(waitForAsync(() => {
141147
init();
142148

143-
translateServiceSpy = jasmine.createSpyObj('TranslateService', ['get']);
149+
translateServiceSpy = jasmine.createSpyObj('TranslateService', ['get'], {
150+
onTranslationChange: new BehaviorSubject({}),
151+
onLangChange: new BehaviorSubject({}),
152+
onDefaultLangChange: new BehaviorSubject({}),
153+
});
154+
translateServiceSpy.get.and.returnValue(new BehaviorSubject('process.overview.unknown.user'));
144155

145156
void TestBed.configureTestingModule({
146157
imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), VarDirective, ProcessOverviewTableComponent],
@@ -153,6 +164,8 @@ describe('ProcessOverviewTableComponent', () => {
153164
{ provide: NgbModal, useValue: modalService },
154165
{ provide: AuthService, useValue: authService },
155166
{ provide: RouteService, useValue: routeService },
167+
{ provide: AuthorizationDataService, useValue: authorizationService },
168+
{ provide: TranslateService, useValue: translateServiceSpy },
156169
],
157170
schemas: [NO_ERRORS_SCHEMA],
158171
}).overrideComponent(ProcessOverviewTableComponent, {
@@ -227,12 +240,14 @@ describe('ProcessOverviewTableComponent', () => {
227240
});
228241

229242
describe('getEPersonName function', () => {
243+
beforeEach(() => {
244+
translateServiceSpy.get.calls.reset();
245+
});
246+
230247
it('should return unknown user when id is null', (done: DoneFn) => {
231248
const id = null;
232249
const expectedTranslation = 'process.overview.unknown.user';
233250

234-
translateServiceSpy.get(expectedTranslation);
235-
236251
component.getEPersonName(id).subscribe((result: string) => {
237252
expect(result).toBe(expectedTranslation);
238253
done();
@@ -244,8 +259,6 @@ describe('ProcessOverviewTableComponent', () => {
244259
const id = '';
245260
const expectedTranslation = 'process.overview.unknown.user';
246261

247-
translateServiceSpy.get(expectedTranslation);
248-
249262
component.getEPersonName(id).subscribe((result: string) => {
250263
expect(result).toBe(expectedTranslation);
251264
done();

0 commit comments

Comments
 (0)