[DURACOM-455] set default as false, fix issue with missing default link, add tests

Author: FrancescoMolinaro

src/app/item-page/simple/item-types/publication/publication.component.spec.ts

@@ -95,6 +95,12 @@ describe('PublicationComponent', () => {
       getThumbnailFor(item: Item): Observable<RemoteData<Bitstream>> {
         return createSuccessfulRemoteDataObject$(new Bitstream());
       },
+      findPrimaryBitstreamByItemAndName(item: Item, bundleName: string, useCachedVersionIfAvailable: boolean, reRequestOnStale: boolean): Observable<Bitstream | null> {
+        return of(null);
+      },
+      findAllByItemAndBundleName(item: Item, bundleName: string, options: any, useCachedVersionIfAvailable: boolean, reRequestOnStale: boolean, ...linksToFollow: any[]): Observable<RemoteData<any>> {
+        return createSuccessfulRemoteDataObject$(createPaginatedList([]));
+      },
     };
     TestBed.configureTestingModule({
       imports: [
@@ -270,4 +276,63 @@ describe('PublicationComponent', () => {
     }));
 
   });
+
+  describe('when showDownloadLinkAsAttachment is false', () => {
+    beforeEach(waitForAsync(() => {
+      TestBed.overrideComponent(PublicationComponent, {
+        add: { changeDetection: ChangeDetectionStrategy.Default },
+        remove: {
+          imports: [
+            ThemedFileSectionComponent,
+          ],
+        },
+      });
+      TestBed.compileComponents();
+      fixture = TestBed.createComponent(PublicationComponent);
+      comp = fixture.componentInstance;
+      comp.object = getItem(noMetadata);
+      comp.showDownloadLinkAsAttachment = false;
+      fixture.detectChanges();
+    }));
+
+    it('should display the file section component', () => {
+      const fileSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-file-section'));
+      expect(fileSectionElements.length).toBe(1);
+    });
+
+    it('should not display the attachment section component', () => {
+      const attachmentSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-attachment-section'));
+      expect(attachmentSectionElements.length).toBe(0);
+    });
+  });
+
+  describe('when showDownloadLinkAsAttachment is true', () => {
+    beforeEach(waitForAsync(() => {
+      TestBed.overrideComponent(PublicationComponent, {
+        add: { changeDetection: ChangeDetectionStrategy.Default },
+        remove: {
+          imports: [
+            ThemedFileSectionComponent,
+          ],
+        },
+      });
+      TestBed.compileComponents();
+      fixture = TestBed.createComponent(PublicationComponent);
+      comp = fixture.componentInstance;
+      comp.object = getItem(noMetadata);
+      comp.showDownloadLinkAsAttachment = true;
+      fixture.detectChanges();
+    }));
+
+    it('should display the attachment section component', () => {
+      const attachmentSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-attachment-section'));
+      expect(attachmentSectionElements.length).toBe(1);
+    });
+
+    it('should not display the file section component', () => {
+      const fileSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-file-section'));
+      expect(fileSectionElements.length).toBe(0);
+    });
+  });
+
 });

src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html

@@ -30,7 +30,7 @@
         <ds-media-viewer [item]="object"></ds-media-viewer>
       </div>
     }
-    @if (showDownloadLinkAsAttachment) {
+    @if (showDownloadLinkAsAttachment !== true) {
       <ds-item-page-file-section [item]="object"></ds-item-page-file-section>
     }
     <ds-item-page-date-field [item]="object"></ds-item-page-date-field>

src/app/item-page/simple/item-types/untyped-item/untyped-item.component.spec.ts

@@ -97,6 +97,12 @@ describe('UntypedItemComponent', () => {
       getThumbnailFor(item: Item): Observable<RemoteData<Bitstream>> {
         return createSuccessfulRemoteDataObject$(new Bitstream());
       },
+      findPrimaryBitstreamByItemAndName(item: Item, bundleName: string, useCachedVersionIfAvailable: boolean, reRequestOnStale: boolean): Observable<Bitstream | null> {
+        return of(null);
+      },
+      findAllByItemAndBundleName(item: Item, bundleName: string, options: any, useCachedVersionIfAvailable: boolean, reRequestOnStale: boolean, ...linksToFollow: any[]): Observable<RemoteData<any>> {
+        return createSuccessfulRemoteDataObject$(createPaginatedList([]));
+      },
     };
     TestBed.configureTestingModule({
       imports: [
@@ -295,4 +301,62 @@ describe('UntypedItemComponent', () => {
 
   });
 
+  describe('when showDownloadLinkAsAttachment is false', () => {
+    beforeEach(waitForAsync(() => {
+      TestBed.overrideComponent(UntypedItemComponent, {
+        add: { changeDetection: ChangeDetectionStrategy.Default },
+        remove: {
+          imports: [
+            ThemedFileSectionComponent,
+          ],
+        },
+      });
+      TestBed.compileComponents();
+      fixture = TestBed.createComponent(UntypedItemComponent);
+      comp = fixture.componentInstance;
+      comp.object = getItem(noMetadata);
+      comp.showDownloadLinkAsAttachment = false;
+      fixture.detectChanges();
+    }));
+
+    it('should display the file section component', () => {
+      const fileSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-file-section'));
+      expect(fileSectionElements.length).toBe(1);
+    });
+
+    it('should not display the attachment section component', () => {
+      const attachmentSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-attachment-section'));
+      expect(attachmentSectionElements.length).toBe(0);
+    });
+  });
+
+  describe('when showDownloadLinkAsAttachment is true', () => {
+    beforeEach(waitForAsync(() => {
+      TestBed.overrideComponent(UntypedItemComponent, {
+        add: { changeDetection: ChangeDetectionStrategy.Default },
+        remove: {
+          imports: [
+            ThemedFileSectionComponent,
+          ],
+        },
+      });
+      TestBed.compileComponents();
+      fixture = TestBed.createComponent(UntypedItemComponent);
+      comp = fixture.componentInstance;
+      comp.object = getItem(noMetadata);
+      comp.showDownloadLinkAsAttachment = true;
+      fixture.detectChanges();
+    }));
+
+    it('should display the attachment section component', () => {
+      const attachmentSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-attachment-section'));
+      expect(attachmentSectionElements.length).toBe(1);
+    });
+
+    it('should not display the file section component', () => {
+      const fileSectionElements = fixture.debugElement.queryAll(By.css('ds-item-page-file-section'));
+      expect(fileSectionElements.length).toBe(0);
+    });
+  });
+
 });

src/config/default-app-config.ts

@@ -748,7 +748,7 @@ export class DefaultAppConfig implements AppConfig {
         },
       },
     ],
-    showDownloadLinkAsAttachment: true,
+    showDownloadLinkAsAttachment: false,
     advancedAttachmentRendering: {
       pagination: {
         enabled: true,