94060: hopefully fix cypress tests

Author: LotteHofstede

cypress/integration/my-dspace.spec.ts

@@ -107,7 +107,7 @@ describe('My DSpace page', () => {
             cy.get('[data-dismiss="alert"]').click({multiple: true});
 
             // This is the GET command that will actually run the search
-            cy.intercept('GET', '/server/api/discover/search/objects*').as('search-results');
+            cy.intercept('GET', '/server/api/discover/search/objects**').as('search-results');
             // On MyDSpace, find the submission we just created via its ID
             cy.get('[data-test="search-box"]').type(id);
             cy.get('[data-test="search-button"]').click();

cypress/integration/search-navbar.spec.ts

@@ -22,7 +22,7 @@ describe('Search from Navigation Bar', () => {
     it('should go to search page with correct query if submitted (from home)', () => {
         cy.visit('/');
         // This is the GET command that will actually run the search
-        cy.intercept('GET', '/server/api/discover/search/objects*').as('search-results');
+        cy.intercept('GET', '/server/api/discover/search/objects**').as('search-results');
         // Run the search
         page.fillOutQueryInNavBar(query);
         page.submitQueryByPressingEnter();
@@ -37,7 +37,7 @@ describe('Search from Navigation Bar', () => {
     it('should go to search page with correct query if submitted (from search)', () => {
         cy.visit('/search');
         // This is the GET command that will actually run the search
-        cy.intercept('GET', '/server/api/discover/search/objects*').as('search-results');
+        cy.intercept('GET', '/server/api/discover/search/objects**').as('search-results');
         // Run the search
         page.fillOutQueryInNavBar(query);
         page.submitQueryByPressingEnter();
@@ -52,7 +52,7 @@ describe('Search from Navigation Bar', () => {
     it('should allow user to also submit query by clicking icon', () => {
         cy.visit('/');
         // This is the GET command that will actually run the search
-        cy.intercept('GET', '/server/api/discover/search/objects*').as('search-results');
+        cy.intercept('GET', '/server/api/discover/search/objects**').as('search-results');
         // Run the search
         page.fillOutQueryInNavBar(query);
         page.submitQueryByPressingIcon();

cypress/integration/submission.spec.ts

@@ -77,7 +77,7 @@ describe('New Submission page', () => {
             cy.get('[data-dismiss="alert"]').click({multiple: true});
 
             // This is the GET command that will actually run the search
-            cy.intercept('GET', '/server/api/discover/search/objects*').as('search-results');
+            cy.intercept('GET', '/server/api/discover/search/objects**').as('search-results');
             // On MyDSpace, find the submission we just saved via its ID
             cy.get('[data-test="search-box"]').type(id);
             cy.get('[data-test="search-button"]').click();

src/app/entity-groups/research-entities/submission/item-list-elements/person/person-search-result-list-submission-element.component.html

@@ -8,13 +8,13 @@
                     [placeholder]="'thumbnail.person.placeholder'">
       </ds-thumbnail>
     </a>
-    <div *ngIf="linkType == linkTypes.None" class="dont-break-out">
+    <span *ngIf="linkType == linkTypes.None" class="dont-break-out">
       <ds-thumbnail [thumbnail]="dso?.thumbnail | async"
                     [defaultImage]="'assets/images/person-placeholder.svg'"
                     [alt]="'thumbnail.person.alt'"
                     [placeholder]="'thumbnail.person.placeholder'">
       </ds-thumbnail>
-    </div>
+    </span>
   </div>
   <div [ngClass]="showThumbnails ? 'col-9' : 'col-md-12'">
     <div class="d-flex">