Skip to content

Commit 792a614

Browse files
100553: Set the maximum amount of metadata fields shown on EditInPlaceFieldComponent back to 10
1 parent b00a0f5 commit 792a614

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/app/item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
(clickSuggestion)="update(suggestionControl)"
1313
(typeSuggestion)="update(suggestionControl)"
1414
(dsClickOutside)="checkValidity(suggestionControl)"
15-
(findSuggestions)="findMetadataFieldSuggestions($event)"
15+
(findSuggestions)="findMetadataFieldSuggestions($event, { elementsPerPage: 10 })"
1616
#suggestionControl="ngModel"
1717
[valid]="(valid | async) !== false"
1818
dsAutoFocus autoFocusSelector=".suggestion_input"

src/app/item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ describe('EditInPlaceFieldComponent', () => {
228228
}));
229229

230230
it('it should call queryMetadataFields on the metadataFieldService with the correct query', () => {
231-
expect(metadataFieldService.queryMetadataFields).toHaveBeenCalledWith(query, null, true, false, followLink('schema'));
231+
expect(metadataFieldService.queryMetadataFields).toHaveBeenCalledWith(query, {}, true, false, followLink('schema'));
232232
});
233233

234234
it('it should set metadataFieldSuggestions to the right value', () => {

src/app/item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { InputSuggestion } from '../../../../shared/input-suggestions/input-sugg
1515
import { followLink } from '../../../../shared/utils/follow-link-config.model';
1616
import { FieldUpdate } from '../../../../core/data/object-updates/field-update.model';
1717
import { FieldChangeType } from '../../../../core/data/object-updates/field-change-type.model';
18+
import { FindListOptions } from '../../../../core/data/find-list-options.model';
1819

1920
@Component({
2021
// eslint-disable-next-line @angular-eslint/component-selector
@@ -124,10 +125,11 @@ export class EditInPlaceFieldComponent implements OnInit, OnChanges {
124125
* Then sets all found metadata fields as metadataFieldSuggestions
125126
* Ignores fields from metadata schemas "relation" and "relationship"
126127
* @param query The query to look for
128+
* @param options The options that need to be given to the backend
127129
*/
128-
findMetadataFieldSuggestions(query: string) {
130+
findMetadataFieldSuggestions(query: string, options: FindListOptions = {}) {
129131
if (isNotEmpty(query)) {
130-
return this.registryService.queryMetadataFields(query, null, true, false, followLink('schema')).pipe(
132+
return this.registryService.queryMetadataFields(query, options, true, false, followLink('schema')).pipe(
131133
getFirstSucceededRemoteData(),
132134
metadataFieldsToString(),
133135
).subscribe((fieldNames: string[]) => {

0 commit comments

Comments
 (0)