100302: Add an error to prevent piping or subscribing to undefined when no href is present

YanaDePauw · YanaDePauw · commit 6c5ae4972ecd · 2023-03-30T16:53:10.000+02:00
diff --git a/src/app/core/data/base/base-data.service.ts b/src/app/core/data/base/base-data.service.ts
@@ -356,6 +356,7 @@ export class BaseDataService<T extends CacheableObject> implements HALDataServic
         }),
       );
     }
+    throw new Error(`Can't check whether there is a cached response for an empty href$`);
   }
 
   hasCachedErrorResponse(href$: string | Observable<string>): Observable<boolean> {

Original file line number	Diff line number	Diff line change
`@@ -356,6 +356,7 @@ export class BaseDataService<T extends CacheableObject> implements HALDataServic`
`356`	`356`	`}),`
`357`	`357`	`);`
`358`	`358`	`}`
	`359`	+ throw new Error(`Can't check whether there is a cached response for an empty href$`);
`359`	`360`	`}`
`360`	`361`
`361`	`362`	`hasCachedErrorResponse(href$: string \| Observable<string>): Observable<boolean> {`