[DSC-1529] [CST-13917] add url tag, ad fallback for description

FrancescoMolinaro · FrancescoMolinaro · commit 645d655d2288 · 2024-05-09T15:01:26.000+02:00
diff --git a/src/app/core/metadata/metadata.service.ts b/src/app/core/metadata/metadata.service.ts
@@ -170,6 +170,7 @@ export class MetadataService {
     this.setOpenGraphTitleTag();
     this.setOpenGraphDescriptionTag();
     this.setOpenGraphImageTag();
+    this.setOpenGraphUrlTag();
 
     this.setTwitterTitleTag();
     this.setTwitterDescriptionTag();
@@ -421,7 +422,7 @@ export class MetadataService {
    */
   private setOpenGraphDescriptionTag(): void {
     // TODO: truncate abstract
-    const value = this.getMetaTagValue('dc.description.abstract');
+    const value = this.getMetaTagValue('dc.description.abstract') ?? this.translate.instant('meta.tag.missing.description');
     this.addMetaTag('og:description', value);
   }
 
@@ -432,6 +433,14 @@ export class MetadataService {
     this.setPrimaryBitstreamInBundleTag('og:image');
   }
 
+  /**
+   * Add <meta name="og:url" ... >  to the <head>
+   */
+  private setOpenGraphUrlTag(): void {
+    const value = this.getMetaTagValue('dc.identifier.uri');
+    this.addMetaTag('og:url', value);
+}
+
 
   /**
    * Add <meta name="twitter:title" ... >  to the <head>
diff --git a/src/assets/i18n/es.json5 b/src/assets/i18n/es.json5
@@ -11728,6 +11728,9 @@
   // "access-control-option-end-date-note": "Select the date until which the related access condition is applied",
   "access-control-option-end-date-note": "Escoja la fecha hasta la cuál se aplicarán las condiciones de acceso especificadas",
 
+  // "meta.tag.missing.description": "No description available"
+  // TODO New key - Add a translation
+  "meta.tag.missing.description": "No description available"
 
 
 }

Original file line number	Diff line number	Diff line change
`@@ -11728,6 +11728,9 @@`
`11728`	`11728`	`// "access-control-option-end-date-note": "Select the date until which the related access condition is applied",`
`11729`	`11729`	`"access-control-option-end-date-note": "Escoja la fecha hasta la cuál se aplicarán las condiciones de acceso especificadas",`
`11730`	`11730`
	`11731`	`+ // "meta.tag.missing.description": "No description available"`
	`11732`	`+ // TODO New key - Add a translation`
	`11733`	`+ "meta.tag.missing.description": "No description available"`
`11731`	`11734`
`11732`	`11735`
`11733`	`11736`	`}`