Skip to content

Commit 645ce35

Browse files
committed
[UXP-114] Refactoring markdown-viewer.component by using markdown.pipe
1 parent a8cc46c commit 645ce35

4 files changed

Lines changed: 11 additions & 6 deletions

File tree

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
<nu-markdown-preview [style]="'color: inherit'" [value]="value"></nu-markdown-preview>
1+
<span class="dont-break-out" [innerHTML]="value | dsMarkdown: true | async">
2+
</span>

src/app/shared/markdown-viewer/markdown-viewer.component.spec.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
import { ComponentFixture, TestBed } from '@angular/core/testing';
22

33
import { MarkdownViewerComponent } from './markdown-viewer.component';
4+
import { MarkdownPipe } from '../utils/markdown.pipe';
5+
import { By } from '@angular/platform-browser';
46

57
describe('DsMarkdownViewerComponent', () => {
68
let component: MarkdownViewerComponent;
79
let fixture: ComponentFixture<MarkdownViewerComponent>;
810

911
beforeEach(async () => {
1012
await TestBed.configureTestingModule({
11-
declarations: [ MarkdownViewerComponent ]
13+
declarations: [ MarkdownViewerComponent, MarkdownPipe ]
1214
})
1315
.compileComponents();
1416
});
@@ -20,6 +22,7 @@ describe('DsMarkdownViewerComponent', () => {
2022
});
2123

2224
it('should create', () => {
23-
expect(component).toBeTruthy();
25+
const span = fixture.debugElement.query(By.css('span'));
26+
expect(span).toBeTruthy();
2427
});
2528
});

src/app/shared/markdown-viewer/markdown-viewer.module.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ import { NgModule } from '@angular/core';
22
import { CommonModule } from '@angular/common';
33
import { MarkdownViewerComponent } from './markdown-viewer.component';
44
import { NuMarkdownModule } from '@ng-util/markdown';
5+
import { SharedModule } from '../shared.module';
56

67
@NgModule({
78
declarations: [ MarkdownViewerComponent ],
89
exports: [ MarkdownViewerComponent ],
9-
imports: [ CommonModule, NuMarkdownModule ]
10+
imports: [CommonModule, NuMarkdownModule, SharedModule]
1011
})
1112
export class MarkdownViewerModule { }

src/app/shared/utils/markdown.pipe.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ export class MarkdownPipe implements PipeTransform {
4949
) {
5050
}
5151

52-
async transform(value: string): Promise<SafeHtml> {
53-
if (!environment.markdown.enabled) {
52+
async transform(value: string, forcePreview = false): Promise<SafeHtml> {
53+
if (!environment.markdown.enabled && !forcePreview) {
5454
return value;
5555
}
5656
const MarkdownIt = await this.markdownIt;

0 commit comments

Comments
 (0)