Skip to content

Commit 5aaa4ef

Browse files
committed
ensure the rel="noopener" attribute is only set when target="_blank" and remove "noreferrer" in all cases
1 parent 27d3c58 commit 5aaa4ef

24 files changed

Lines changed: 35 additions & 35 deletions

File tree

src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal-issue/journal-issue-search-result-grid-element.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66
<a *ngIf="linkType != linkTypes.None"
77
[target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
8-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
8+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width">
1010
<div>
1111
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
@@ -36,7 +36,7 @@ <h4 class="card-title" [innerHTML]="firstMetadataValue('dc.title')"></h4>
3636
</p>
3737
<div *ngIf="linkType != linkTypes.None" class="text-center">
3838
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
39-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
39+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
4040
class="lead btn btn-primary viewButton">View</a>
4141
</div>
4242
</div>

src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal-volume/journal-volume-search-result-grid-element.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66
<a *ngIf="linkType != linkTypes.None"
77
[target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
8-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
8+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width">
1010
<div>
1111
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
@@ -36,7 +36,7 @@ <h4 class="card-title" [innerHTML]="dso.firstMetadataValue('dc.title')"></h4>
3636
</p>
3737
<div *ngIf="linkType != linkTypes.None" class="text-center">
3838
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
39-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
39+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
4040
class="lead btn btn-primary viewButton">View</a>
4141
</div>
4242
</div>

src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal/journal-search-result-grid-element.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66
<a *ngIf="linkType != linkTypes.None"
77
[target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
8-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
8+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width">
1010
<div>
1111
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
@@ -40,7 +40,7 @@ <h4 class="card-title" [innerHTML]="firstMetadataValue('dc.title')"></h4>
4040
</p>
4141
<div *ngIf="linkType != linkTypes.None" class="text-center">
4242
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
43-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
43+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
4444
class="lead btn btn-primary viewButton">View</a>
4545
</div>
4646
</div>

src/app/entity-groups/journal-entities/item-list-elements/search-result-list-elements/journal-issue/journal-issue-search-result-list-element.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<ds-type-badge *ngIf="showLabel" [object]="dso"></ds-type-badge>
22
<ds-truncatable [id]="dso.id">
3-
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" rel="noopener noreferrer"
3+
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null"
44
[routerLink]="[itemPageRoute]" class="lead item-list-title"
55
[innerHTML]="dsoTitle"></a>
66
<span *ngIf="linkType == linkTypes.None"

src/app/entity-groups/journal-entities/item-list-elements/search-result-list-elements/journal-volume/journal-volume-search-result-list-element.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<ds-type-badge *ngIf="showLabel" [object]="dso"></ds-type-badge>
22
<ds-truncatable [id]="dso.id">
3-
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" rel="noopener noreferrer"
3+
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null"
44
[routerLink]="[itemPageRoute]" class="lead item-list-title"
55
[innerHTML]="dsoTitle"></a>
66
<span *ngIf="linkType == linkTypes.None"

src/app/entity-groups/journal-entities/item-list-elements/search-result-list-elements/journal/journal-search-result-list-element.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<ds-type-badge *ngIf="showLabel" [object]="dso"></ds-type-badge>
22
<ds-truncatable [id]="dso.id">
3-
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" rel="noopener noreferrer"
3+
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null"
44
[routerLink]="[itemPageRoute]" class="lead item-list-title"
55
[innerHTML]="dsoTitle"></a>
66
<span *ngIf="linkType == linkTypes.None"

src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/org-unit/org-unit-search-result-grid-element.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66
<a *ngIf="linkType != linkTypes.None"
77
[target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
8-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
8+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width">
1010
<div>
1111
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
@@ -42,7 +42,7 @@ <h4 class="card-title" [innerHTML]="firstMetadataValue('organization.legalName')
4242
</p>
4343
<div *ngIf="linkType != linkTypes.None" class="text-center">
4444
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
45-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
45+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
4646
class="lead btn btn-primary viewButton">View</a>
4747
</div>
4848
</div>

src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/person/person-search-result-grid-element.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66
<a *ngIf="linkType != linkTypes.None"
77
[target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
8-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
8+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width">
1010
<div>
1111
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
@@ -36,7 +36,7 @@
3636
</p>
3737
<div *ngIf="linkType != linkTypes.None" class="text-center">
3838
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
39-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
39+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
4040
class="lead btn btn-primary viewButton">View</a>
4141
</div>
4242
</div>

src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/project/project-search-result-grid-element.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
</div>
66
<a *ngIf="linkType != linkTypes.None"
77
[target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
8-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
8+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
99
class="card-img-top full-width">
1010
<div>
1111
<ds-thumbnail [thumbnail]="dso?.thumbnail | async" [limitWidth]="false">
@@ -30,7 +30,7 @@ <h4 class="card-title" [innerHTML]="firstMetadataValue('dc.title')"></h4>
3030
</p>
3131
<div *ngIf="linkType != linkTypes.None" class="text-center">
3232
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'"
33-
rel="noopener noreferrer" [routerLink]="[itemPageRoute]"
33+
[attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null" [routerLink]="[itemPageRoute]"
3434
class="lead btn btn-primary viewButton">View</a>
3535
</div>
3636
</div>

src/app/entity-groups/research-entities/item-list-elements/search-result-list-elements/org-unit/org-unit-search-result-list-element.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<ds-type-badge *ngIf="showLabel" [object]="dso"></ds-type-badge>
22
<ds-truncatable [id]="dso.id">
3-
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" rel="noopener noreferrer"
3+
<a *ngIf="linkType != linkTypes.None" [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener' : null"
44
[routerLink]="[itemPageRoute]" class="lead"
55
[innerHTML]="firstMetadataValue('organization.legalName')"></a>
66
<span *ngIf="linkType == linkTypes.None"

0 commit comments

Comments
 (0)