Skip to content

Commit 57cc34c

Browse files
Fix Bitstream format accessibility issues
- Added missing aria-labels to input checkboxes - Fixed minor css alignment
1 parent 120835c commit 57cc34c

4 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/app/admin/admin-registries/bitstream-formats/add-bitstream-format/add-bitstream-format.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
<div class="row">
33
<div class="col-12 mb-4">
44
<h2 id="sub-header"
5-
class="border-bottom mb-2">{{ 'admin.registries.bitstream-formats.create.new' | translate }}</h2>
5+
class="border-bottom pb-2">{{ 'admin.registries.bitstream-formats.create.new' | translate }}</h2>
66

77
<ds-bitstream-format-form (updatedFormat)="createBitstreamFormat($event)"></ds-bitstream-format-form>
88

99
</div>
1010
</div>
11-
</div>
11+
</div>

src/app/admin/admin-registries/bitstream-formats/bitstream-formats.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="bitstream-formats row">
33
<div class="col-12">
44

5-
<h2 id="header" class="border-bottom pb-2 ">{{'admin.registries.bitstream-formats.head' | translate}}</h2>
5+
<h2 id="header" class="border-bottom pb-2">{{'admin.registries.bitstream-formats.head' | translate}}</h2>
66

77
<p id="description">{{'admin.registries.bitstream-formats.description' | translate}}</p>
88
<p id="create-new" class="mb-2"><a [routerLink]="'add'" class="btn btn-success">{{'admin.registries.bitstream-formats.create.new' | translate}}</a></p>
@@ -19,7 +19,7 @@ <h2 id="header" class="border-bottom pb-2 ">{{'admin.registries.bitstream-format
1919
<table id="formats" class="table table-striped table-hover">
2020
<thead>
2121
<tr>
22-
<th scope="col"></th>
22+
<th scope="col" [attr.aria-label]="'admin.registries.bitstream-formats.select' | translate"></th>
2323
<th scope="col">{{'admin.registries.bitstream-formats.table.id' | translate}}</th>
2424
<th scope="col">{{'admin.registries.bitstream-formats.table.name' | translate}}</th>
2525
<th scope="col">{{'admin.registries.bitstream-formats.table.mimetype' | translate}}</th>
@@ -31,6 +31,7 @@ <h2 id="header" class="border-bottom pb-2 ">{{'admin.registries.bitstream-format
3131
<td>
3232
<label class="mb-0">
3333
<input type="checkbox"
34+
[attr.aria-label]="'admin.registries.bitstream-formats.select' | translate"
3435
[checked]="isSelected(bitstreamFormat) | async"
3536
(change)="selectBitStreamFormat(bitstreamFormat, $event)"
3637
>

src/app/admin/admin-registries/bitstream-formats/edit-bitstream-format/edit-bitstream-format.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
<div class="row">
33
<div class="col-12 mb-4">
44
<h2 id="sub-header"
5-
class="border-bottom mb-2">{{'admin.registries.bitstream-formats.edit.head' | translate:{format: (bitstreamFormatRD$ | async)?.payload.shortDescription} }}</h2>
5+
class="border-bottom pb-2">{{'admin.registries.bitstream-formats.edit.head' | translate:{format: (bitstreamFormatRD$ | async)?.payload.shortDescription} }}</h2>
66

77
<ds-bitstream-format-form [bitstreamFormat]="(bitstreamFormatRD$ | async)?.payload" (updatedFormat)="updateFormat($event)"></ds-bitstream-format-form>
88

99
</div>
1010
</div>
11-
</div>
11+
</div>

src/assets/i18n/en.json5

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,8 @@
142142

143143
"admin.registries.bitstream-formats.title": "Bitstream Format Registry",
144144

145+
"admin.registries.bitstream-formats.select": "Select bitstream format",
146+
145147
"admin.registries.metadata.breadcrumbs": "Metadata registry",
146148

147149
"admin.registries.metadata.description": "The metadata registry maintains a list of all metadata fields available in the repository. These fields may be divided amongst multiple schemas. However, DSpace requires the qualified Dublin Core schema.",

0 commit comments

Comments
 (0)