Skip to content

Commit 51127dc

Browse files
committed
Fix accessibility issue
1 parent d6b6743 commit 51127dc

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/app/shared/dso-page/dso-edit-menu/dso-edit-expandable-menu-section/dso-edit-menu-expandable-section.component.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@
22
<div class="dso-button-menu mb-1" ngbDropdown container="body" placement="bottom-right">
33
<div class="d-flex flex-row flex-nowrap"
44
[ngbTooltip]="itemModel.text | translate" container="body">
5-
<button [attr.aria-label]="itemModel.text | translate" [title]="itemModel.text | translate" class="btn btn-dark btn-sm" ngbDropdownToggle [dsBtnDisabled]="section.model?.disabled" role="menuitem">
5+
<button [attr.aria-label]="itemModel.text | translate" [title]="itemModel.text | translate" class="btn btn-dark btn-sm" ngbDropdownToggle [dsBtnDisabled]="section.model?.disabled" role="menuitem" tabindex="0">
66
<i class="fas fa-{{section.icon}} fa-fw"></i>
77
</button>
8-
<ul ngbDropdownMenu class="dso-edit-menu-dropdown p-1">
8+
<ul ngbDropdownMenu class="dso-edit-menu-dropdown p-1" role="menu">
99
@for (subSection of (subSections$ | async); track subSection) {
10-
<li class="nav-item nav-link d-flex flex-row p-2">
10+
<li class="nav-item nav-link d-flex flex-row p-2" role="presentation">
1111
@if (renderIcons$ | async) {
1212
<div class="me-2">
1313
@if (subSection.icon) {
14-
<i class="fas fa-{{subSection.icon}} fa-fw"></i>
14+
<i class="fas fa-{{subSection.icon}} fa-fw" aria-hidden="true"></i>
1515
} @else {
16-
<i class="fas fa-fw"></i>
16+
<i class="fas fa-fw" aria-hidden="true"></i>
1717
}
1818
</div>
1919
}

src/app/shared/dso-page/dso-edit-menu/dso-edit-menu.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="dso-edit-menu d-flex">
1+
<div class="dso-edit-menu d-flex" role="menubar">
22
@for (section of (sections | async); track section) {
33
<div class="ms-1">
44
<ng-container

0 commit comments

Comments
 (0)