[DSC-1708] orcid display refactor

Author: alisaismailati

src/app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.html

@@ -1,9 +1,9 @@
 <span class="d-flex align-items-center txt-value">
-  <a *ngIf="(orcidUrl$ | async); else noOrcidUrl" href="{{(orcidUrl$ | async)}}/{{metadataValue.value}}" target="_blank">
-    {{ metadataValue.value }}
+  <a *ngIf="(orcidUrl$ | async); else noOrcidUrl" href="{{(orcidUrl$ | async)}}/{{metadataValue}}" target="_blank">
+    {{ metadataValue }}
   </a>
 
-  <ng-template #noOrcidUrl>{{ metadataValue.value }}</ng-template>
+  <ng-template #noOrcidUrl>{{ metadataValue }}</ng-template>
 
   <img *ngIf="hasOrcidBadge()"
         placement="top"

src/app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.spec.ts

@@ -52,11 +52,6 @@ describe('MetadataLinkViewOrcidComponent', () => {
         }
       }), BrowserAnimationsModule],
       providers: [
-        { provide: 'fieldProvider', useValue: null },
-        { provide: 'itemProvider', useValue: testItem },
-        { provide: 'metadataValueProvider', useValue: metadataValue },
-        { provide: 'renderingSubTypeProvider', useValue: '' },
-        { provide: 'tabNameProvider', useValue: '' },
         { provide: ConfigurationDataService, useValue: configurationDataService}
       ],
     })

src/app/shared/metadata-link-view/metadata-link-view-orcid/metadata-link-view-orcid.component.ts

@@ -1,18 +1,46 @@
+import { ConfigurationProperty } from './../../../core/shared/configuration-property.model';
+import { getFirstSucceededRemoteDataPayload } from './../../../core/shared/operators';
+import { ConfigurationDataService } from './../../../core/data/configuration-data.service';
 import { Component, Input, OnInit } from '@angular/core';
 import { Item } from '../../../core/shared/item.model';
-import { OrcidComponent } from '../../../cris-layout/cris-layout-matrix/cris-layout-box-container/boxes/metadata/rendering-types/orcid/orcid.component';
+import { Observable, map } from 'rxjs';
 
 @Component({
   selector: 'ds-metadata-link-view-orcid',
   templateUrl: './metadata-link-view-orcid.component.html',
-  styleUrls: ['./metadata-link-view-orcid.component.scss']
+  styleUrls: ['./metadata-link-view-orcid.component.scss'],
 })
-export class MetadataLinkViewOrcidComponent extends OrcidComponent implements OnInit {
-
+export class MetadataLinkViewOrcidComponent implements OnInit {
+  /**
+   * Item value to display the metadata for
+   */
   @Input() itemValue: Item;
 
+  metadataValue: string;
+
+  orcidUrl$: Observable<string>;
+
+  constructor(protected configurationService: ConfigurationDataService) {}
+
   ngOnInit(): void {
-    this.item = this.itemValue;
-    super.ngOnInit();
+    this.orcidUrl$ = this.configurationService
+      .findByPropertyName('orcid.domain-url')
+      .pipe(
+        getFirstSucceededRemoteDataPayload(),
+        map((property: ConfigurationProperty) =>
+          property?.values?.length > 0 ? property.values[0] : null
+        )
+      );
+    this.metadataValue = this.itemValue.firstMetadataValue(
+      'person.identifier.orcid'
+    );
+  }
+
+  public hasOrcid(): boolean {
+    return this.itemValue.hasMetadata('person.identifier.orcid');
+  }
+
+  public hasOrcidBadge(): boolean {
+    return this.itemValue.hasMetadata('dspace.orcid.authenticated');
   }
 }