Merged in task/dspace-cris-2024_02_x/DSC-2556 (pull request DSpace#3706)

[DSC-2556] prevent double notification for eula page

Approved-by: Andrea Barbasso

Author: FrancescoMolinaro

src/app/info/end-user-agreement/end-user-agreement.component.spec.ts

@@ -1,4 +1,7 @@
-import { NO_ERRORS_SCHEMA } from '@angular/core';
+import {
+  NO_ERRORS_SCHEMA,
+  PLATFORM_ID,
+} from '@angular/core';
 import {
   ComponentFixture,
   TestBed,
@@ -74,6 +77,7 @@ describe('EndUserAgreementComponent', () => {
         { provide: Store, useValue: store },
         { provide: Router, useValue: router },
         { provide: ActivatedRoute, useValue: route },
+        { provide: PLATFORM_ID, useValue: 'browser' },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     })
@@ -198,4 +202,37 @@ describe('EndUserAgreementComponent', () => {
       });
     });
   });
+
+  describe('warning notification logic', () => {
+    beforeEach(() => {
+      (endUserAgreementService.hasCurrentUserOrCookieAcceptedAgreement as jasmine.Spy)
+        .and.returnValue(observableOf(false));
+      fixture.detectChanges();
+    });
+
+    it('should show warning once when not accepted and in browser', () => {
+      component.ngOnInit();
+      expect(notificationsService.warning).toHaveBeenCalledTimes(1);
+      component.initAccepted(); // call again
+      expect(notificationsService.warning).toHaveBeenCalledTimes(1);
+    });
+
+    it('should not show warning when already accepted', () => {
+      component.ngOnInit();
+      (notificationsService.warning as jasmine.Spy).calls.reset();
+      (endUserAgreementService.hasCurrentUserOrCookieAcceptedAgreement as jasmine.Spy)
+        .and.returnValue(observableOf(true));
+      component.initAccepted();
+      expect(notificationsService.warning).not.toHaveBeenCalled();
+    });
+
+    it('should not show warning when not in browser', () => {
+      (component as any).platformId = 'server';
+      fixture.detectChanges();
+      (notificationsService.warning as jasmine.Spy).calls.reset();
+      component.ngOnInit();
+      component.initAccepted();
+      expect(notificationsService.warning).toHaveBeenCalledTimes(0);
+    });
+  });
 });

src/app/info/end-user-agreement/end-user-agreement.component.ts

@@ -1,8 +1,13 @@
-import { NgIf } from '@angular/common';
+import {
+  isPlatformBrowser,
+  NgIf,
+} from '@angular/common';
 import {
   Component,
+  Inject,
   OnDestroy,
   OnInit,
+  PLATFORM_ID,
 } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import {
@@ -59,14 +64,16 @@ export class EndUserAgreementComponent implements OnInit, OnDestroy {
   alreadyAccepted = false;
 
   private subscription: Subscription = new Subscription();
+  private notifiedOnce = false;
 
   constructor(protected endUserAgreementService: EndUserAgreementService,
               protected notificationsService: NotificationsService,
               protected translate: TranslateService,
               protected authService: AuthService,
               protected store: Store<AppState>,
               protected router: Router,
-              protected route: ActivatedRoute) {
+              protected route: ActivatedRoute,
+              @Inject(PLATFORM_ID) private platformId: string) {
   }
 
   /**
@@ -89,8 +96,9 @@ export class EndUserAgreementComponent implements OnInit, OnDestroy {
         .subscribe(([accepted, authorized]) => {
           if (authorized) {
 
-            if (!accepted) {
-              this.notificationsService.warning(this.translate.instant('info.end-user-agreement.accept.warning'), {});
+            if (!accepted && isPlatformBrowser(this.platformId) && !this.notifiedOnce) {
+              this.notificationsService.warning(this.translate.instant('info.end-user-agreement.accept.warning'));
+              this.notifiedOnce = true;
             }
             this.accepted = accepted;
             this.alreadyAccepted = accepted;