[DSC-2140] add tests

Author: Andrea Barbasso

src/app/core/shared/metadata.utils.spec.ts

@@ -1,7 +1,7 @@
 import { isUndefined } from '../../shared/empty.util';
 import { v4 as uuidv4 } from 'uuid';
 import { MetadataMap, MetadataValue, MetadataValueFilter, MetadatumViewModel } from './metadata.models';
-import { Metadata } from './metadata.utils';
+import { Metadata, PLACEHOLDER_VALUE } from './metadata.utils';
 
 const mdValue = (value: string, language?: string, authority?: string): MetadataValue => {
   return Object.assign(new MetadataValue(), {
@@ -306,4 +306,21 @@ describe('Metadata', () => {
       testAllWithLimit(multiMap, 'dc.title', [dcTitle1], 1);
     });
   });
+
+  describe('Placeholder values', () => {
+    it('should ignore placeholder values in get methods', () => {
+      const placeholderMd = mdValue(PLACEHOLDER_VALUE);
+      const key = 'dc.test.placeholder';
+      const map = { 'dc.test.placeholder': [placeholderMd] };
+
+      expect(Metadata.all(map, key).length).toEqual(0);
+      expect(Metadata.allValues(map, key).length).toEqual(0);
+      expect(Metadata.has(map, key)).toBeFalsy();
+      expect(Metadata.first(map, key)).toBeUndefined();
+      expect(Metadata.firstValue(map, key)).toBeUndefined();
+      expect(Metadata.hasValue(placeholderMd)).toBeFalsy();
+      expect(Metadata.valueMatches(placeholderMd, null)).toBeFalsy();
+    });
+  });
+
 });

src/app/core/shared/metadata.utils.ts

@@ -157,7 +157,7 @@ export class Metadata {
       return false;
     }
     if (isObject(value) && value.hasOwnProperty('value')) {
-      return isNotEmpty(value.value);
+      return isNotEmpty(value.value) && value.value !== PLACEHOLDER_VALUE;
     }
     return true;
   }