Skip to content

Commit 3814734

Browse files
authored
Merge pull request DSpace#3080 from alexandrevryghem/w2p-115428_fixed-page-size-and-sorting-not-working-on-comcolpages
Fixed page size change and sorting not working on comcol pages
2 parents 1c325cd + 4d89a11 commit 3814734

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/app/shared/page-size-selector/page-size-selector.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
<ds-sidebar-dropdown
33
[id]="'search-sidebar-rpp'"
44
[label]="'search.sidebar.settings.rpp'"
5-
(change)="reloadRPP($event)"
5+
(changed)="reloadRPP($event)"
66
>
77
<option *ngFor="let pageSizeOption of (paginationOptions$ | async).pageSizeOptions"
88
[value]="pageSizeOption"
99
[selected]="pageSizeOption === +((paginationOptions$ | async).pageSize) ? 'selected': null">
1010
{{pageSizeOption}}
1111
</option>
1212
</ds-sidebar-dropdown>
13-
</div>
13+
</div>

src/app/shared/search/search-settings/search-settings.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h3>{{ 'search.sidebar.settings.title' | translate}}</h3>
44
<ds-sidebar-dropdown *ngIf="sortOptionsList"
55
[id]="'search-sidebar-sort'"
66
[label]="'search.sidebar.settings.sort-by'"
7-
(change)="reloadOrder($event)">
7+
(changed)="reloadOrder($event)">
88
<option *ngFor="let sortOptionsEntry of sortOptionsList"
99
[value]="sortOptionsEntry.field + ',' + sortOptionsEntry.direction.toString()"
1010
[selected]="sortOptionsEntry.field === currentSortOption?.field && sortOptionsEntry.direction === (currentSortOption?.direction)? 'selected': null">
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div class="setting-option mb-3 p-3">
22
<h4><label for="{{id}}">{{label | translate}}</label></h4>
3-
<select id="{{id}}" class="form-control" (change)="change.emit($event)">
3+
<select id="{{id}}" class="form-control" (change)="changed.emit($event)">
44
<ng-content></ng-content>
55
</select>
6-
</div>
6+
</div>

src/app/shared/sidebar/sidebar-dropdown.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ import { TranslateModule } from '@ngx-translate/core';
2020
export class SidebarDropdownComponent {
2121
@Input() id: string;
2222
@Input() label: string;
23-
@Output() change: EventEmitter<any> = new EventEmitter<number>();
23+
@Output() changed: EventEmitter<any> = new EventEmitter<number>();
2424
}

0 commit comments

Comments
 (0)